Re: [openstack-dev] [glance] Deprecating osprofiler option 'enabled' in favour of 'profiler_enabled'

2014-12-03 Thread Nikhil Komawar
(not for usage questions) Subject: Re: [openstack-dev] [glance] Deprecating osprofiler option 'enabled' in favour of 'profiler_enabled' Except for the fact that the person who implemented this was told to change the option name in other projects because it conflicted with a differ

Re: [openstack-dev] [glance] Deprecating osprofiler option 'enabled' in favour of 'profiler_enabled'

2014-12-02 Thread Ian Cordasco
Except for the fact that the person who implemented this was told to change the option name in other projects because it conflicted with a different option. We can keep this if we’re worried about being too obvious (to the point of becoming the Department of Redundancy Department) with our naming.

Re: [openstack-dev] [glance] Deprecating osprofiler option 'enabled' in favour of 'profiler_enabled'

2014-12-02 Thread Zhi Yan Liu
I totally agreed to make it to be consistent cross all projects, so I propose to change other projects. But I think keeping it as-it is clear enough for both developer and operator/configuration, for example: [profiler] enable = True instead of: [profiler] profiler_enable = True Tbh, the "prof

Re: [openstack-dev] [glance] Deprecating osprofiler option 'enabled' in favour of 'profiler_enabled'

2014-12-02 Thread Louis Taylor
On Tue, Dec 02, 2014 at 12:16:44PM +0800, Zhi Yan Liu wrote: > Why not change other services instead of glance? I see one reason is > "glance is the only one service use this option name", but to me one > reason to keep it as-it in glance is that original name makes more > sense due to the option a

Re: [openstack-dev] [glance] Deprecating osprofiler option 'enabled' in favour of 'profiler_enabled'

2014-12-02 Thread Kuvaja, Erno
> -Original Message- > From: Flavio Percoco [mailto:fla...@redhat.com] > Sent: 02 December 2014 09:45 > To: OpenStack Development Mailing List (not for usage questions) > Subject: Re: [openstack-dev] [glance] Deprecating osprofiler option 'enabled' > in favour o

Re: [openstack-dev] [glance] Deprecating osprofiler option 'enabled' in favour of 'profiler_enabled'

2014-12-02 Thread Flavio Percoco
On 02/12/14 12:16 +0800, Zhi Yan Liu wrote: Why not change other services instead of glance? I see one reason is "glance is the only one service use this option name", but to me one reason to keep it as-it in glance is that original name makes more sense due to the option already under "profiler"

Re: [openstack-dev] [glance] Deprecating osprofiler option 'enabled' in favour of 'profiler_enabled'

2014-12-01 Thread Zhi Yan Liu
Why not change other services instead of glance? I see one reason is "glance is the only one service use this option name", but to me one reason to keep it as-it in glance is that original name makes more sense due to the option already under "profiler" group, adding "profiler" prefix to it is real

Re: [openstack-dev] [glance] Deprecating osprofiler option 'enabled' in favour of 'profiler_enabled'

2014-12-01 Thread Ian Cordasco
On 12/1/14, 08:37, "Louis Taylor" wrote: >Hi all, > >In order to enable or disable osprofiler in Glance, we currently have an >option: > >[profiler] ># If False fully disable profiling feature. >enabled = False > >However, all other services with osprofiler integration use a similar >

[openstack-dev] [glance] Deprecating osprofiler option 'enabled' in favour of 'profiler_enabled'

2014-12-01 Thread Louis Taylor
Hi all, In order to enable or disable osprofiler in Glance, we currently have an option: [profiler] # If False fully disable profiling feature. enabled = False However, all other services with osprofiler integration use a similar option named profiler_enabled. For consistency, I'm p