to:openstack-dev@lists.openstack.org>>
Date: Thursday, 23 July 2015 18:11
To: "OpenStack Development Mailing List (not for usage questions)"
mailto:openstack-dev@lists.openstack.org>>
Subject: Re: [openstack-dev] [horizon] Minimum Unit Test Coverage
+1 on coverage of any kind.
>Fro
+1 on coverage of any kind.
>From a tooling perspective, are you thinking istanbul?
>From an infra perspective, are you thinking a separate job, or to have it
integrated in with npm run test? FYI- istanbul wraps the unit test
invocation, e.g. 'istanbul karma start ./karma.config.js' or something
Hi Rob
I agree. Enforcing a minimum level of coverage as a start is awesome.
I must add though keeping it at 100% and breaking the build has almost
never worked in practice for me.
Keeping a slightly lower level ~98% is slightly more pragmatic.
Also, the currently low coverages will have to be ad
Hi all,
As far as I’m aware, we don’t currently enforce any minimum unit test coverage,
despite Karma generating reports. I think as part of the review guidelines, it
would be useful to set a minimum. Since Karma’s detection is fairly relaxed,
I’d put it at 100% on the automated reports.
I thi
