Yep I totally agree that adding cores for the sake of adding cores doesn’t make
sense. Just trying to fish for ideas to prevent having to go to a single +2 to
merge as that does make me nervous. But I guess for the sake of moving code
through it needs to be done at the moment.
> On 1 Mar 2017,
Adding inexperienced cores doesn't really alleviate that issue though, and I
don't currently feel that there is anyone with the right balance of experience
and activity to be added to the core team.
Me and Richard monitor review activity very closely though, and we are actively
looking to grow
Has there been any consideration of growing the core team to help with review
bandwidth? I ask only because that resulting responsibility to the community
can drive additional review activity. Just worried that only 1x +2 could cause
issues with code being merged on a project this large that cou
Hey everyone,
Horizon is moving to requiring only a single core review for code approval.
Note that cores are not obliged to approve on a single +2; if a core would like
a second opinion for patches that are complex or high risk, that is also fine.
We still require at least one of the core revi