Re: [openstack-dev] [ironic] Remember to follow RFE process

2016-03-04 Thread Ruby Loo 
> Hi,
>>
>> > Ironic'ers, please remember to follow the RFE process; especially the
>> cores.
>> >
>> > I noticed that a patch [1] got merged yesterday. The patch was
>> associated
>> > with an RFE [2] that hadn't been approved yet :-( What caught my eye was
>> > that the commit message didn't describe the actual API change so I took
>> a
>> > quick look at the (RFE) bug and it wasn't documented there either.
>>
>
Thanks everyone! I see that the RFE has been approved, although I don't see
what the CLI/API change is. I'm guessing it was to add --driver or
something like that to 'ironic node-list' and a similar thing for the
openstack client plugin and API :)

--ruby
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [ironic] Remember to follow RFE process

2016-03-03 Thread Dmitry Tantsur 
2016-03-03 11:01 GMT+01:00 Lucas Alvares Gomes :

> Hi,
>
> > Ironic'ers, please remember to follow the RFE process; especially the
> cores.
> >
> > I noticed that a patch [1] got merged yesterday. The patch was associated
> > with an RFE [2] that hadn't been approved yet :-( What caught my eye was
> > that the commit message didn't describe the actual API change so I took a
> > quick look at the (RFE) bug and it wasn't documented there either.
> >
> > As a reminder, the RFE process is documented [3].
> >
> > Spec cores need to try to be more timely wrt specs (I admit, I am
> guilty).
> > And folks, especially cores, ought to take more care when reviewing.
> > Although I do feel like there are too many things that a reviewer needs
> to
> > keep in mind.
> >
> > Should we revert the patch [1] for now? (Disclaimer. I haven't looked at
> the
> > patch itself. But I don't think I should have to, to know what the API
> > change is.)
> >
>
> Thanks for calling it out Ruby, that's unfortunate that the patch was
> merged without the RFE being approved. About reverting the patch I
> think we shouldn't do that now because the patch is touching the API
> and introducing a new microversion to it.
>

Exactly. I've -2'ed the revert, as removing API version is even worse than
landing a change without an RFE approved. Let us make sure to approve RFE
asap, and then adjust the code according to it.


>
> And yes, as reviewers let's try to improve our process. We probably
> should talk about how we can do it in the next upstream meeting.
>
> Cheers,
> Lucas
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>



-- 
--
-- Dmitry Tantsur
--
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [ironic] Remember to follow RFE process

2016-03-03 Thread Lucas Alvares Gomes 
Hi,

> Ironic'ers, please remember to follow the RFE process; especially the cores.
>
> I noticed that a patch [1] got merged yesterday. The patch was associated
> with an RFE [2] that hadn't been approved yet :-( What caught my eye was
> that the commit message didn't describe the actual API change so I took a
> quick look at the (RFE) bug and it wasn't documented there either.
>
> As a reminder, the RFE process is documented [3].
>
> Spec cores need to try to be more timely wrt specs (I admit, I am guilty).
> And folks, especially cores, ought to take more care when reviewing.
> Although I do feel like there are too many things that a reviewer needs to
> keep in mind.
>
> Should we revert the patch [1] for now? (Disclaimer. I haven't looked at the
> patch itself. But I don't think I should have to, to know what the API
> change is.)
>

Thanks for calling it out Ruby, that's unfortunate that the patch was
merged without the RFE being approved. About reverting the patch I
think we shouldn't do that now because the patch is touching the API
and introducing a new microversion to it.

And yes, as reviewers let's try to improve our process. We probably
should talk about how we can do it in the next upstream meeting.

Cheers,
Lucas

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [ironic] Remember to follow RFE process

2016-03-02 Thread Haomeng, Wang 
Thanks Ruby to point this out.

On Thu, Mar 3, 2016 at 3:25 PM, Haomeng, Wang  wrote:

> Hi Ruby,
>
> Yes, just noticed that RFE is in 'Wishlist' status now, sorry for missing
> the bug status yesterday, so we need to follow the process, and I will help
> to revert the patch and get it back to review again once the REF is
> reviewed.
>
> -- Haomeng
>
>
>
> On Thu, Mar 3, 2016 at 3:07 AM, Ruby Loo  wrote:
>
>> Hi,
>>
>> Ironic'ers, please remember to follow the RFE process; especially the
>> cores.
>>
>> I noticed that a patch [1] got merged yesterday. The patch was associated
>> with an RFE [2] that hadn't been approved yet :-( What caught my eye was
>> that the commit message didn't describe the actual API change so I took a
>> quick look at the (RFE) bug and it wasn't documented there either.
>>
>> As a reminder, the RFE process is documented [3].
>>
>> Spec cores need to try to be more timely wrt specs (I admit, I am
>> guilty). And folks, especially cores, ought to take more care when
>> reviewing. Although I do feel like there are too many things that a
>> reviewer needs to keep in mind.
>>
>> Should we revert the patch [1] for now? (Disclaimer. I haven't looked at
>> the patch itself. But I don't think I should have to, to know what the API
>> change is.)
>>
>> --ruby
>>
>>
>> [1] https://review.openstack.org/#/c/264005/
>> [2] https://bugs.launchpad.net/ironic/+bug/1530626
>> [3]
>> http://docs.openstack.org/developer/ironic/dev/code-contribution-guide.html#adding-new-features
>>
>> __
>> OpenStack Development Mailing List (not for usage questions)
>> Unsubscribe:
>> openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>
>>
>
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [ironic] Remember to follow RFE process

2016-03-02 Thread Haomeng, Wang 
Hi Ruby,

Yes, just noticed that RFE is in 'Wishlist' status now, sorry for missing
the bug status yesterday, so we need to follow the process, and I will help
to revert the patch and get it back to review again once the REF is
reviewed.

-- Haomeng



On Thu, Mar 3, 2016 at 3:07 AM, Ruby Loo  wrote:

> Hi,
>
> Ironic'ers, please remember to follow the RFE process; especially the
> cores.
>
> I noticed that a patch [1] got merged yesterday. The patch was associated
> with an RFE [2] that hadn't been approved yet :-( What caught my eye was
> that the commit message didn't describe the actual API change so I took a
> quick look at the (RFE) bug and it wasn't documented there either.
>
> As a reminder, the RFE process is documented [3].
>
> Spec cores need to try to be more timely wrt specs (I admit, I am guilty).
> And folks, especially cores, ought to take more care when reviewing.
> Although I do feel like there are too many things that a reviewer needs to
> keep in mind.
>
> Should we revert the patch [1] for now? (Disclaimer. I haven't looked at
> the patch itself. But I don't think I should have to, to know what the API
> change is.)
>
> --ruby
>
>
> [1] https://review.openstack.org/#/c/264005/
> [2] https://bugs.launchpad.net/ironic/+bug/1530626
> [3]
> http://docs.openstack.org/developer/ironic/dev/code-contribution-guide.html#adding-new-features
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
>
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

[openstack-dev] [ironic] Remember to follow RFE process

2016-03-02 Thread Ruby Loo 
Hi,

Ironic'ers, please remember to follow the RFE process; especially the cores.

I noticed that a patch [1] got merged yesterday. The patch was associated
with an RFE [2] that hadn't been approved yet :-( What caught my eye was
that the commit message didn't describe the actual API change so I took a
quick look at the (RFE) bug and it wasn't documented there either.

As a reminder, the RFE process is documented [3].

Spec cores need to try to be more timely wrt specs (I admit, I am guilty).
And folks, especially cores, ought to take more care when reviewing.
Although I do feel like there are too many things that a reviewer needs to
keep in mind.

Should we revert the patch [1] for now? (Disclaimer. I haven't looked at
the patch itself. But I don't think I should have to, to know what the API
change is.)

--ruby


[1] https://review.openstack.org/#/c/264005/
[2] https://bugs.launchpad.net/ironic/+bug/1530626
[3]
http://docs.openstack.org/developer/ironic/dev/code-contribution-guide.html#adding-new-features
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev