Re: [openstack-dev] [ironic] network_interface, defaults, and explicitness

2016-08-02 Thread Devananda van der Veen
On 08/01/2016 05:10 AM, Jim Rollenhagen wrote: > Hey all, > > Our nova patch for networking[0] got stuck for a bit, because Nova needs > to know which network interface is in use for the node, in order to > properly set up the port. > > The code landed for network_interface follows the following

Re: [openstack-dev] [ironic] network_interface, defaults, and explicitness

2016-08-02 Thread Vasyl Saienko
The proposed approach is reasonable. Just a small adding. I think for a longterm concept it would be good to avoid setting binding_host_id in ironic virt_driver. We should force users to set it when 'binding_profile' is updated. It looks weird that we telling Neutron to bind port at one place and

Re: [openstack-dev] [ironic] network_interface, defaults, and explicitness

2016-08-01 Thread Jim Rollenhagen
On Mon, Aug 01, 2016 at 08:10:18AM -0400, Jim Rollenhagen wrote: > Hey all, > > Our nova patch for networking[0] got stuck for a bit, because Nova needs > to know which network interface is in use for the node, in order to > properly set up the port. > > The code landed for network_interface

Re: [openstack-dev] [ironic] network_interface, defaults, and explicitness

2016-08-01 Thread Sam Betts (sambetts)
On 01/08/2016 13:10, "Jim Rollenhagen" wrote: >Hey all, > >Our nova patch for networking[0] got stuck for a bit, because Nova needs >to know which network interface is in use for the node, in order to >properly set up the port. > >The code landed for network_interface

Re: [openstack-dev] [ironic] network_interface, defaults, and explicitness

2016-08-01 Thread Mathieu Mitchell
On 2016-08-01 8:10 AM, Jim Rollenhagen wrote: Hey all, I propose that if a network_interface is not sent in the node-create call, we write whatever the current default is, so that it is always set and not using an implicit value that could change. Works for me and ensures an easier

[openstack-dev] [ironic] network_interface, defaults, and explicitness

2016-08-01 Thread Jim Rollenhagen
Hey all, Our nova patch for networking[0] got stuck for a bit, because Nova needs to know which network interface is in use for the node, in order to properly set up the port. The code landed for network_interface follows the following order for what is actually used for the node: 1)