Re: [openstack-dev] [javascript] Linters

2015-06-10 Thread Michael Krotscheck
On Tue, Jun 9, 2015 at 3:37 PM Robert Collins robe...@robertcollins.net wrote: On 10 June 2015 at 04:01, Michael Krotscheck krotsch...@gmail.com wrote: Well, it looks like everyone has disqualified jslint and jshint, so let's just make a decision there and remove them from the running.

Re: [openstack-dev] [javascript] Linters

2015-06-10 Thread Robert Collins
On 11 June 2015 at 03:29, Michael Krotscheck krotsch...@gmail.com wrote: On Tue, Jun 9, 2015 at 3:37 PM Robert Collins robe...@robertcollins.net wrote: There are two package managers in the JavaScript world right now, one that focuses on node.js/server dependencies (karma, lint, express,

Re: [openstack-dev] [javascript] Linters

2015-06-10 Thread Tripp, Travis S
: [openstack-dev] [javascript] Linters On Tue, Jun 9, 2015 at 3:37 PM Robert Collins robe...@robertcollins.netmailto:robe...@robertcollins.net wrote: On 10 June 2015 at 04:01, Michael Krotscheck krotsch...@gmail.commailto:krotsch...@gmail.com wrote: Well, it looks like everyone has disqualified

Re: [openstack-dev] [javascript] Linters

2015-06-09 Thread Michael Krotscheck
Hey there, Gustavo- JSMin's a minifier, not a linter, yes? Unless I'm wrong, we're discussing the enforcement of code style rather than the concatenation step in our build, and thus jsmin's not really in the running. Once we _do_ talk about how we assemble javascript, I'm sure JSMin will have a

Re: [openstack-dev] [javascript] Linters

2015-06-09 Thread Michael Krotscheck
Well, it looks like everyone has disqualified jslint and jshint, so let's just make a decision there and remove them from the running. Unless I hear a compelling reason to use something that has the infamous do no evil license in it, let's dump it. The John Papa styles seem sane, and though I

Re: [openstack-dev] [javascript] Linters

2015-06-09 Thread Michael Krotscheck
The more I think about this, the more I think my ideas are dumb. John Papa has very opinionated guides on how an _angular_ application should be structured. Openstack's linting must be framework agnostic, because we can't predict which frameworks may or may not be used. For example, there is a

Re: [openstack-dev] [javascript] Linters

2015-06-09 Thread Robert Collins
On 10 June 2015 at 04:01, Michael Krotscheck krotsch...@gmail.com wrote: Well, it looks like everyone has disqualified jslint and jshint, so let's just make a decision there and remove them from the running. Unless I hear a compelling reason to use something that has the infamous do no evil

Re: [openstack-dev] [javascript] Linters

2015-06-08 Thread Tripp, Travis S
We¹ve adopted the John Papa style guide for Angular in horizon [0]. On cursory inspection ES lint seems to have an angular specific plugin [1] that could be very useful to us, but we¹d need to evaluate it in depth. It looks like there was some discussion on the style guide on this not too long ago

Re: [openstack-dev] [javascript] Linters

2015-06-08 Thread gustavo panizzo (gfa)
On 2015-06-06 03:26, Michael Krotscheck wrote: Right now, there are several JS linters in use in OpenStack: JSHint, JSCS, and Eslint. I really would like to only use one of them, so that I can figure out how to sanely share the configuration between projects. Can all those who have a strong

Re: [openstack-dev] [javascript] Linters

2015-06-08 Thread Matthias Runge
On Fri, Jun 05, 2015 at 07:26:24PM +, Michael Krotscheck wrote: Right now, there are several JS linters in use in OpenStack: JSHint, JSCS, and Eslint. I really would like to only use one of them, so that I can figure out how to sanely share the configuration between projects. Can all

Re: [openstack-dev] [javascript] Linters

2015-06-08 Thread Michael Krotscheck
On Mon, Jun 8, 2015 at 1:59 AM Matthias Runge mru...@redhat.com wrote: jshint: still non-free license [1] Yep! Ergo, we can't really use it. eslint seems to require to sign a CLA, if we come across an issue and were going to fix that. So does the python foundation, I'm not really

[openstack-dev] [javascript] Linters

2015-06-05 Thread Michael Krotscheck
Right now, there are several JS linters in use in OpenStack: JSHint, JSCS, and Eslint. I really would like to only use one of them, so that I can figure out how to sanely share the configuration between projects. Can all those who have a strong opinion please stand up and state their opinions?