Re: [openstack-dev] [magnum-ui][horizon] use json-schema-form on workflow

[Shuu Mutou]

Thanks Rob. Pretty good! We have confirmed 'tabs' type is same look and feel as 
previous Workflow Service.


> -Original Message-
> From: Rob Cresswell [mailto:robert.cressw...@outlook.com]
> Sent: Friday, November 25, 2016 5:39 PM
> To: OpenStack Dev Mailer <openstack-dev@lists.openstack.org>
> Subject: Re: [openstack-dev] [magnum-ui][horizon] use json-schema-form on
> workflow
> 
> From a quick scan, it looks like you're using it several times in the same
> workflow? Why not just use the existing tabs type and create a single form?
> Have a look at https://review.openstack.org/#/c/348969/
> <https://review.openstack.org/#/c/348969/> for reference.
> 
> 
> Rob
> 
> On 25 Nov 2016 08:28, "Shuu Mutou" <shu-mu...@rf.jp.nec.com
> <mailto:shu-mu...@rf.jp.nec.com> > wrote:
> 
> 
>   Hi Thai,
> 
>   We're trying to use json-schema-form in workflow, but 'required'
> attribute doesn't work. So we can push 'create' button without input. Could
> you check following patch?
> 
>   https://review.openstack.org/#/c/400701/
> <https://review.openstack.org/#/c/400701/>
> 
>   best regards,
>   Shu Muto
> 
> 
>   __
> 
>   OpenStack Development Mailing List (not for usage questions)
>   Unsubscribe:
> openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> <http://openstack-dev-requ...@lists.openstack.org?subject:unsubscribe>
>   http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-
> dev <http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev>
> 

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [magnum-ui][horizon] use json-schema-form on workflow

[Rob Cresswell]

From a quick scan, it looks like you're using it several times in the same 
workflow? Why not just use the existing tabs type and create a single form? 
Have a look at https://review.openstack.org/#/c/348969/for reference.

Rob

On 25 Nov 2016 08:28, "Shuu Mutou" 
> wrote:
Hi Thai,

We're trying to use json-schema-form in workflow, but 'required' attribute 
doesn't work. So we can push 'create' button without input. Could you check 
following patch?

https://review.openstack.org/#/c/400701/

best regards,
Shu Muto


__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: 
openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

[openstack-dev] [magnum-ui][horizon] use json-schema-form on workflow

[Shuu Mutou]

Hi Thai,

We're trying to use json-schema-form in workflow, but 'required' attribute 
doesn't work. So we can push 'create' button without input. Could you check 
following patch?

https://review.openstack.org/#/c/400701/

best regards, 
Shu Muto


__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev