Re: [openstack-dev] [neutron][nova][SR-IOV] deprecation of supported_pci_vendor_devs
+1
I think we have enough checks in Nova.
2016-08-09 12:46 GMT+03:00 Moshe Levi <mosh...@mellanox.com>:
> This is the deprecation patch [2]
>
> [2] - https://review.openstack.org/#/c/352812/
>
> -Original Message-
> From: Moshe Levi [mailto:mosh...@mellanox.com]
> Sent: Monday, August 08, 2016 3:43 PM
> To: OpenStack Development Mailing List (not for usage questions) (
> openstack-dev@lists.openstack.org) <openstack-dev@lists.openstack.org>
> Subject: [openstack-dev] [neutron][nova][SR-IOV] deprecation of
> supported_pci_vendor_devs
>
> Hi all,
>
> To reduce complexity in configuring SR-IOV I want to deprecate the
> supported_pci_vendor_devs option [1] in the neutron-server ml2 config.
> This option is doing extra validation that pci vendor id and product id
> provided by nova in the neutron port binding profile is matching to the
> vendor id and product id in supported_pci_vendor_devs.
>
> In my opinion this is redundant, nova-scheduler is the point to do
> validation and select a suitable hypervisor.
> The compute node is already validating this through the
> pci_passthrough_whitelist option in nova.conf [2].
>
> I don't see a reason why the neutron-server should validate the pci
> vendor_id and product_id again from the neutron port binding profile.
>
> If there is good reason to keep it please let me know, otherwise I will
> deprecate it.
>
> [1] - supported_pci_vendor_devs = ['15b3:1004', '8086:10ca'] [2] -
> pci_passthrough_whitelist = {"address":"*:06:00.*","
> physical_network":"physnet1"}
>
>
> Thanks,
> Moshe
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [neutron][nova][SR-IOV] deprecation of supported_pci_vendor_devs
This is the deprecation patch [2]
[2] - https://review.openstack.org/#/c/352812/
-Original Message-
From: Moshe Levi [mailto:mosh...@mellanox.com]
Sent: Monday, August 08, 2016 3:43 PM
To: OpenStack Development Mailing List (not for usage questions)
(openstack-dev@lists.openstack.org) <openstack-dev@lists.openstack.org>
Subject: [openstack-dev] [neutron][nova][SR-IOV] deprecation of
supported_pci_vendor_devs
Hi all,
To reduce complexity in configuring SR-IOV I want to deprecate the
supported_pci_vendor_devs option [1] in the neutron-server ml2 config.
This option is doing extra validation that pci vendor id and product id
provided by nova in the neutron port binding profile is matching to the vendor
id and product id in supported_pci_vendor_devs.
In my opinion this is redundant, nova-scheduler is the point to do validation
and select a suitable hypervisor.
The compute node is already validating this through the
pci_passthrough_whitelist option in nova.conf [2].
I don't see a reason why the neutron-server should validate the pci vendor_id
and product_id again from the neutron port binding profile.
If there is good reason to keep it please let me know, otherwise I will
deprecate it.
[1] - supported_pci_vendor_devs = ['15b3:1004', '8086:10ca'] [2] -
pci_passthrough_whitelist =
{"address":"*:06:00.*","physical_network":"physnet1"}
Thanks,
Moshe
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [neutron][nova][SR-IOV] deprecation of supported_pci_vendor_devs
+1
This validation in neutron is redundant.
/ludovic
-Original Message-
From: Moshe Levi [mailto:mosh...@mellanox.com]
Sent: August-08-16 8:43 AM
To: OpenStack Development Mailing List (not for usage questions)
(openstack-dev@lists.openstack.org)
Subject: [openstack-dev] [neutron][nova][SR-IOV] deprecation of
supported_pci_vendor_devs
Hi all,
To reduce complexity in configuring SR-IOV I want to deprecate the
supported_pci_vendor_devs option [1] in the neutron-server ml2 config.
This option is doing extra validation that pci vendor id and product id
provided by nova in the neutron port binding profile is matching to the vendor
id and product id in supported_pci_vendor_devs.
In my opinion this is redundant, nova-scheduler is the point to do validation
and select a suitable hypervisor.
The compute node is already validating this through the
pci_passthrough_whitelist option in nova.conf [2].
I don't see a reason why the neutron-server should validate the pci vendor_id
and product_id again from the neutron port binding profile.
If there is good reason to keep it please let me know, otherwise I will
deprecate it.
[1] - supported_pci_vendor_devs = ['15b3:1004', '8086:10ca'] [2] -
pci_passthrough_whitelist =
{"address":"*:06:00.*","physical_network":"physnet1"}
Thanks,
Moshe
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
[openstack-dev] [neutron][nova][SR-IOV] deprecation of supported_pci_vendor_devs
Hi all,
To reduce complexity in configuring SR-IOV I want to deprecate the
supported_pci_vendor_devs option [1] in the neutron-server ml2 config.
This option is doing extra validation that pci vendor id and product id
provided by nova in the neutron port binding profile is matching to the vendor
id and product id in supported_pci_vendor_devs.
In my opinion this is redundant, nova-scheduler is the point to do validation
and select a suitable hypervisor.
The compute node is already validating this through the
pci_passthrough_whitelist option in nova.conf [2].
I don't see a reason why the neutron-server should validate the pci vendor_id
and product_id again from the neutron port binding profile.
If there is good reason to keep it please let me know, otherwise I will
deprecate it.
[1] - supported_pci_vendor_devs = ['15b3:1004', '8086:10ca']
[2] - pci_passthrough_whitelist =
{"address":"*:06:00.*","physical_network":"physnet1"}
Thanks,
Moshe
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
