Re: [openstack-dev] [nova][ec2-api] Tagging functionality in nova's EC2 API

2015-02-04 Thread M Ranga Swami Reddy
The conclusion seems fine ATM, like cleanup, fixing bugs, etc. But we should review the spec(s) for EC2 tags and if the spec design looks fine, then we can review the EC2 Tags patch. If the spec design itself is not feasible, then we should revisit the spec and blueprint. Thanks Swami On Tue,

Re: [openstack-dev] [nova][ec2-api] Tagging functionality in nova's EC2 API

2015-02-04 Thread Rushi Agrawal
Thanks Alex for your detailed inspection of my work. Comments inline.. On 3 February 2015 at 21:32, Alexandre Levine alev...@cloudscaling.com wrote: I'm writing this in regard to several reviews concering tagging functionality for EC2 API in nova. The list of the reviews concerned is here:

Re: [openstack-dev] [nova][ec2-api] Tagging functionality in nova's EC2 API

2015-02-04 Thread Alexandre Levine
Rushi, Thank you for the response. I totally understand the effort and your problems with getting it through at the time. Your design is completely inline with what's currently present in Nova for EC2, no doubt about that. I did whatever I could to review your patches and consider if it's

[openstack-dev] [nova][ec2-api] Tagging functionality in nova's EC2 API

2015-02-03 Thread Alexandre Levine
I'm writing this in regard to several reviews concering tagging functionality for EC2 API in nova. The list of the reviews concerned is here: https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/ec2-volume-and-snapshot-tags,n,z I don't think it's a good

Re: [openstack-dev] [nova][ec2-api] Tagging functionality in nova's EC2 API

2015-02-03 Thread Michael Still
I agree that the priority at the moment for Nova should be getting our EC2 implementation working well enough that it buys us time to transition people to whatever the future may be. Its unfortunate that we have approved the spec for this work in Kilo, but I think that's an indication that we