Re: [openstack-dev] [nova][libvirt] Lets make libvirt's domain XML canonical

2016-11-15 Thread Matt Riedemann
On 9/30/2016 11:03 AM, Matthew Booth wrote: I thought it was a counter-argument (unless I've misunderstood). If you migrate the instance as-is without modification, you don't need to worry about whether it's currently a rescue instance. This problem goes away. The major complication I can

Re: [openstack-dev] [nova][libvirt] Lets make libvirt's domain XML canonical

2016-10-03 Thread Daniel P. Berrange
On Fri, Sep 30, 2016 at 04:36:31PM +, Murray, Paul (HP Cloud) wrote: > > We have a problem migrating rescued instances that has a fix in progress based > on regenerating the xml on unrescue, see: > > https://blueprints.launchpad.net/nova/+spec/live-migrate-rescued-instances > > That might

Re: [openstack-dev] [nova][libvirt] Lets make libvirt's domain XML canonical

2016-10-03 Thread Daniel P. Berrange
On Mon, Oct 03, 2016 at 10:11:34AM +0300, Timofei Durakov wrote: > Hi team, > > I agree that it's kind of strange thing that nova dumps xml definition to > the disk but doesn't use it(at least I do not aware of it). > How the proposed changed would be aligned with other drivers? The worst > case

Re: [openstack-dev] [nova][libvirt] Lets make libvirt's domain XML canonical

2016-10-03 Thread Roman Podoliaka
Timofei, On Mon, Oct 3, 2016 at 10:11 AM, Timofei Durakov wrote: > Hi team, > Taking that into account, the > question here would be: why not to store all required information(e.g. boot > order) in DB instead? I think, we definitely could do that, just like we currently

Re: [openstack-dev] [nova][libvirt] Lets make libvirt's domain XML canonical

2016-10-03 Thread Timofei Durakov
w Booth > Reply-To: "openstack-dev@lists.openstack.org" > Date: Friday, 30 September 2016 at 17:03 > To: "openstack-dev@lists.openstack.org" > Subject: Re: [openstack-dev] [nova][libvirt] Lets make libvirt's domain > XML canonical > > On Fri, Sep 30, 2016 at 4:

Re: [openstack-dev] [nova][libvirt] Lets make libvirt's domain XML canonical

2016-09-30 Thread Murray, Paul (HP Cloud)
From: Matthew Booth Reply-To: "openstack-dev@lists.openstack.org<mailto:openstack-dev@lists.openstack.org>" Date: Friday, 30 September 2016 at 17:03 To: "openstack-dev@lists.openstack.org<mailto:openstack-dev@lists.openstack.org>" Subject: Re: [openstac

Re: [openstack-dev] [nova][libvirt] Lets make libvirt's domain XML canonical

2016-09-30 Thread Matthew Booth
On Fri, Sep 30, 2016 at 4:38 PM, Murray, Paul (HP Cloud) wrote: > > > > > > On 27/09/2016, 18:12, "Daniel P. Berrange" wrote: > > >On Tue, Sep 27, 2016 at 10:40:34AM -0600, Chris Friesen wrote: > >> On 09/27/2016 10:17 AM, Matthew Booth wrote: > >> > >> > I

Re: [openstack-dev] [nova][libvirt] Lets make libvirt's domain XML canonical

2016-09-30 Thread Murray, Paul (HP Cloud)
On 27/09/2016, 18:12, "Daniel P. Berrange" wrote: >On Tue, Sep 27, 2016 at 10:40:34AM -0600, Chris Friesen wrote: >> On 09/27/2016 10:17 AM, Matthew Booth wrote: >> >> > I think we should be able to create a domain, but once created we should >> > never >> > redefine

Re: [openstack-dev] [nova][libvirt] Lets make libvirt's domain XML canonical

2016-09-27 Thread Artom Lifshitz
By coincidence I've just written up a spec [1] that proposes an admittedly very generic mechanism to solve this problem. I was coming at it from the perspective of keeping the relative order of PCI device addresses constant across evacuations. In that spec, I propose letting the virt driver store

Re: [openstack-dev] [nova][libvirt] Lets make libvirt's domain XML canonical

2016-09-27 Thread Daniel P. Berrange
On Tue, Sep 27, 2016 at 10:40:34AM -0600, Chris Friesen wrote: > On 09/27/2016 10:17 AM, Matthew Booth wrote: > > > I think we should be able to create a domain, but once created we should > > never > > redefine a domain. We can do adding and removing devices dynamically using > > libvirt's

Re: [openstack-dev] [nova][libvirt] Lets make libvirt's domain XML canonical

2016-09-27 Thread Chris Friesen
On 09/27/2016 10:17 AM, Matthew Booth wrote: I think we should be able to create a domain, but once created we should never redefine a domain. We can do adding and removing devices dynamically using libvirt's apis, secure in the knowledge that libvirt will persist this for us. When we upgrade

Re: [openstack-dev] [nova][libvirt] Lets make libvirt's domain XML canonical

2016-09-27 Thread Daniel P. Berrange
On Tue, Sep 27, 2016 at 05:17:29PM +0100, Matthew Booth wrote: > Currently the libvirt driver (mostly) considers the nova db canonical. That > is, we can throw away libvirt's domain XML at any time and recreate it from > Nova. Anywhere that doesn't assume this is a bug, because whatever >

[openstack-dev] [nova][libvirt] Lets make libvirt's domain XML canonical

2016-09-27 Thread Matthew Booth
Currently the libvirt driver (mostly) considers the nova db canonical. That is, we can throw away libvirt's domain XML at any time and recreate it from Nova. Anywhere that doesn't assume this is a bug, because whatever direction we choose we don't need 2 different sources of truth. The thinking