Re: [openstack-dev] [nova] [libvirt] The risk of hanging when shutdown instance.

2015-03-28 Thread Rui Chen
Thank you for reply, Chris.


2015-03-27 23:15 GMT+08:00 Chris Friesen chris.frie...@windriver.com:

 On 03/26/2015 07:44 PM, Rui Chen wrote:

 Yes, you are right, but we found our instance hang at first
 dom.shutdown() call,
 if the dom.shutdown() don't return, there is no chance to execute
 dom.destroy(),
 right?


 Correct.  The code is written assuming dom.shutdown() cannot block
 indefinitely.

 The libvirt docs at https://libvirt.org/html/libvirt-libvirt-domain.html#
 virDomainShutdown say ...this command returns as soon as the shutdown
 request is issued rather than blocking until the guest is no longer
 running.

 If dom.shutdown() blocks indefinitely, then that's a libvirt bug.


 Chris


 __
 OpenStack Development Mailing List (not for usage questions)
 Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
 http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] [nova] [libvirt] The risk of hanging when shutdown instance.

2015-03-27 Thread Chris Friesen

On 03/26/2015 07:44 PM, Rui Chen wrote:

Yes, you are right, but we found our instance hang at first dom.shutdown() call,
if the dom.shutdown() don't return, there is no chance to execute dom.destroy(),
right?


Correct.  The code is written assuming dom.shutdown() cannot block indefinitely.

The libvirt docs at 
https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainShutdown; say 
...this command returns as soon as the shutdown request is issued rather than 
blocking until the guest is no longer running.


If dom.shutdown() blocks indefinitely, then that's a libvirt bug.

Chris


__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] [nova] [libvirt] The risk of hanging when shutdown instance.

2015-03-26 Thread Rui Chen
Yes, you are right, but we found our instance hang at first dom.shutdown()
call, if the dom.shutdown() don't return, there is no chance to execute
dom.destroy(), right?

2015-03-26 23:20 GMT+08:00 Chris Friesen chris.frie...@windriver.com:

 On 03/25/2015 10:15 PM, Rui Chen wrote:

 Hi all:

  I found a discuss about the libvirt shutdown API maybe hang when
 shutdown
 instance in libvirt community,
 https://www.redhat.com/archives/libvir-list/2015-March/msg01121.html

  I'm not sure that whether there are some risks when we shutdown
 instance in
 nova.

  Three questions:
  1. Whether acpi is the default shutdown mode in QEMU/KVM hypervisor
 when we
 shutdown instance using libvirt?
  2. Whether acpi is asynchronous mode, and qemu-agent is synchronous
 mode
 when we shutdown instance?
  3. If the hypervisor use qemu-agent as default shutdown mode, how we
 can
 deal the hanging issue?



 When shutting down an instance if there is a timeout (controlled by config
 file or system metadata) the code will first attempt a clean shutdown via
 dom.shutdown().  If that doesn't terminate the instance by the time the
 timeout expires, then we'll call virt_dom.destroy().

 Chris

 __
 OpenStack Development Mailing List (not for usage questions)
 Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
 http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] [nova] [libvirt] The risk of hanging when shutdown instance.

2015-03-26 Thread Chris Friesen

On 03/25/2015 10:15 PM, Rui Chen wrote:

Hi all:

 I found a discuss about the libvirt shutdown API maybe hang when shutdown
instance in libvirt community,
https://www.redhat.com/archives/libvir-list/2015-March/msg01121.html

 I'm not sure that whether there are some risks when we shutdown instance in
nova.

 Three questions:
 1. Whether acpi is the default shutdown mode in QEMU/KVM hypervisor when we
shutdown instance using libvirt?
 2. Whether acpi is asynchronous mode, and qemu-agent is synchronous mode
when we shutdown instance?
 3. If the hypervisor use qemu-agent as default shutdown mode, how we can
deal the hanging issue?



When shutting down an instance if there is a timeout (controlled by config file 
or system metadata) the code will first attempt a clean shutdown via 
dom.shutdown().  If that doesn't terminate the instance by the time the timeout 
expires, then we'll call virt_dom.destroy().


Chris

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


[openstack-dev] [nova] [libvirt] The risk of hanging when shutdown instance.

2015-03-25 Thread Rui Chen
Hi all:

I found a discuss about the libvirt shutdown API maybe hang when
shutdown instance in libvirt community,
https://www.redhat.com/archives/libvir-list/2015-March/msg01121.html

I'm not sure that whether there are some risks when we shutdown
instance in nova.

Three questions:
1. Whether acpi is the default shutdown mode in QEMU/KVM hypervisor
when we shutdown instance using libvirt?
2. Whether acpi is asynchronous mode, and qemu-agent is synchronous
mode when we shutdown instance?
3. If the hypervisor use qemu-agent as default shutdown mode, how we
can deal the hanging issue?

Best Regards.
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev