Re: [openstack-dev] [nova] Different length limit for tags in object definition and db model definition

OK, added to my todo for the next cycle. On Tue, Jan 17, 2017 at 7:08 PM, Matt Riedemann wrote: > On 1/17/2017 3:31 AM, Roman Podoliaka wrote: > >> Hi all, >> >> Changing the type of column from VARCHAR(80) to VARCHAR(60) would also >> require a data migration (i.e.

Re: [openstack-dev] [nova] Different length limit for tags in object definition and db model definition

On 1/17/2017 3:31 AM, Roman Podoliaka wrote: Hi all, Changing the type of column from VARCHAR(80) to VARCHAR(60) would also require a data migration (i.e. a schema migration to add a new column with the "correct" type, changes to the object, data migration logic) as it is not an "online" DDL

Re: [openstack-dev] [nova] Different length limit for tags in object definition and db model definition

Hi all, Changing the type of column from VARCHAR(80) to VARCHAR(60) would also require a data migration (i.e. a schema migration to add a new column with the "correct" type, changes to the object, data migration logic) as it is not an "online" DDL operation according to [1]. Adding a new API

Re: [openstack-dev] [nova] Different length limit for tags in object definition and db model definition

OK, then, lets try to work this out. On Tue, Jan 17, 2017 at 4:19 PM, Sergey Nikitin wrote: > Hi, Zhenyu! > > I think we should ask DB guys about migration. But my personal opinion is > that DB migration is much painful than new microversion. > > But it seems too late to

Re: [openstack-dev] [nova] Different length limit for tags in object definition and db model definition

Hi, Zhenyu! I think we should ask DB guys about migration. But my personal opinion is that DB migration is much painful than new microversion. But it seems too late to have a microversion for this cycle. > Correct me if I'm wrong but I thought that Feature Freeze will be in action Jan 26.

Re: [openstack-dev] [nova] Different length limit for tags in object definition and db model definition

Hi, Sergey! Thanks for the info, but we are now to the point that should it be a microversion bump or not. The users would love to have longer tags of cause. But it seems too late to have a microversion for this cycle. But will the DB migration be a problem? From 80 to 60? On Tue, Jan 17, 2017

Re: [openstack-dev] [nova] Different length limit for tags in object definition and db model definition

Hi, folks! I guess I found the reason of the problem. The first spec was created by Jay. At that moment I was just an implementer. In this spec we have a contradiction between lines #74 and #99. https://review.openstack.org/#/c/91444/16/specs/juno/tag-instances.rst Line 74 says "A tag shall be

Re: [openstack-dev] [nova] Different length limit for tags in object definition and db model definition

On Tue, Jan 17, 2017 at 2:37 PM, Alex Xu wrote: > > > 2017-01-17 10:26 GMT+08:00 Matt Riedemann : > >> On 1/16/2017 7:12 PM, Zhenyu Zheng wrote: >> >>> Hi Nova, >>> >>> I just discovered something interesting, the tag has a limited length, >>> and in

Re: [openstack-dev] [nova] Different length limit for tags in object definition and db model definition

2017-01-17 10:26 GMT+08:00 Matt Riedemann : > On 1/16/2017 7:12 PM, Zhenyu Zheng wrote: > >> Hi Nova, >> >> I just discovered something interesting, the tag has a limited length, >> and in the current implementation, it is 60 in the tag object definition: >>

Re: [openstack-dev] [nova] Different length limit for tags in object definition and db model definition

On 1/16/2017 7:12 PM, Zhenyu Zheng wrote: Hi Nova, I just discovered something interesting, the tag has a limited length, and in the current implementation, it is 60 in the tag object definition: http://git.openstack.org/cgit/openstack/nova/tree/nova/objects/tag.py#n18 but 80 in the db model:

[openstack-dev] [nova] Different length limit for tags in object definition and db model definition

Hi Nova, I just discovered something interesting, the tag has a limited length, and in the current implementation, it is 60 in the tag object definition: http://git.openstack.org/cgit/openstack/nova/tree/nova/objects/tag.py#n18 but 80 in the db model: