[openstack-dev] [nova] How do we format/version/deprecate things from notifications?
The question came up in this patch [1], how do we deprecate and remove keys in the notification payload? In this case I need to deprecate and replace the 'instance_type' key with 'flavor' per the associated blueprint. [1] https://review.openstack.org/#/c/62430/ -- Thanks, Matt Riedemann ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [nova] How do we format/version/deprecate things from notifications?
On 12/18/2013 9:42 AM, Matt Riedemann wrote: The question came up in this patch [1], how do we deprecate and remove keys in the notification payload? In this case I need to deprecate and replace the 'instance_type' key with 'flavor' per the associated blueprint. [1] https://review.openstack.org/#/c/62430/ By the way, my thinking is it's handled like a deprecated config option, you deprecate it for a release, make sure it's documented in the release notes and then drop it in the next release. For anyone that hasn't switched over they are broken until they start consuming the new key. -- Thanks, Matt Riedemann ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [nova] How do we format/version/deprecate things from notifications?
On 12/18/2013 06:17 PM, Matt Riedemann wrote: On 12/18/2013 9:42 AM, Matt Riedemann wrote: The question came up in this patch [1], how do we deprecate and remove keys in the notification payload? In this case I need to deprecate and replace the 'instance_type' key with 'flavor' per the associated blueprint. [1] https://review.openstack.org/#/c/62430/ By the way, my thinking is it's handled like a deprecated config option, you deprecate it for a release, make sure it's documented in the release notes and then drop it in the next release. For anyone that hasn't switched over they are broken until they start consuming the new key. FWIW - I am OK with this approach - but we should at least document it. I am also thinking that we may want to make it explicit like oslo.config does it. Thanks, N. ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [nova] How do we format/version/deprecate things from notifications?
On 12/18/2013 12:44 PM, Nikola Đipanov wrote: On 12/18/2013 06:17 PM, Matt Riedemann wrote: On 12/18/2013 9:42 AM, Matt Riedemann wrote: The question came up in this patch [1], how do we deprecate and remove keys in the notification payload? In this case I need to deprecate and replace the 'instance_type' key with 'flavor' per the associated blueprint. [1] https://review.openstack.org/#/c/62430/ By the way, my thinking is it's handled like a deprecated config option, you deprecate it for a release, make sure it's documented in the release notes and then drop it in the next release. For anyone that hasn't switched over they are broken until they start consuming the new key. FWIW - I am OK with this approach - but we should at least document it. I am also thinking that we may want to make it explicit like oslo.config does it. We really need proper versioning for notifications. We've had a blueprint open for about a year, but AFAICT, nobody is actively working on it. https://blueprints.launchpad.net/nova/+spec/versioned-notifications -- Russell Bryant ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [nova] How do we format/version/deprecate things from notifications?
On 12/18/2013 01:44 PM, Nikola Đipanov wrote: On 12/18/2013 06:17 PM, Matt Riedemann wrote: On 12/18/2013 9:42 AM, Matt Riedemann wrote: The question came up in this patch [1], how do we deprecate and remove keys in the notification payload? In this case I need to deprecate and replace the 'instance_type' key with 'flavor' per the associated blueprint. [1] https://review.openstack.org/#/c/62430/ By the way, my thinking is it's handled like a deprecated config option, you deprecate it for a release, make sure it's documented in the release notes and then drop it in the next release. For anyone that hasn't switched over they are broken until they start consuming the new key. FWIW - I am OK with this approach - but we should at least document it. I am also thinking that we may want to make it explicit like oslo.config does it. Likewise ... until we get defined schemas and versioning on notifications, it seems reasonable. A post to the ML is nice too :) Thanks, N. ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [nova] How do we format/version/deprecate things from notifications?
On 12/18/2013 03:00 PM, Russell Bryant wrote: We really need proper versioning for notifications. We've had a blueprint open for about a year, but AFAICT, nobody is actively working on it. https://blueprints.launchpad.net/nova/+spec/versioned-notifications IBM is behind this effort now and are keen to get CADF support around notifications. Seems to handle all of our use cases. ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
