Re: [openstack-dev] [nova] How to microversion API code which is not in API layer
Yes. A new query parameter is a change in the contract, regardless of where the code change lies. -Deva On Jun 12, 2015 6:20 PM, "Chen CH Ji" wrote: > Hi > We have [1] in the db layer and it's directly used by API > layer , the filters is directly from client's input > In this case, when doing [2] or similar changes, do we need > to consider microversion usage when we change options? > Thanks > > [1] > https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/api.py#L4440 > [2] https://review.openstack.org/#/c/144883 > > Best Regards! > > Kevin (Chen) Ji 纪 晨 > > Engineer, zVM Development, CSTL > Notes: Chen CH Ji/China/IBM@IBMCN Internet: jiche...@cn.ibm.com > Phone: +86-10-82454158 > Address: 3/F Ring Building, ZhongGuanCun Software Park, Haidian District, > Beijing 100193, PRC > > __ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > > __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [nova] How to microversion API code which is not in API layer
On 6/12/2015 11:11 AM, Chen CH Ji wrote: Hi We have [1] in the db layer and it's directly used by API layer , the filters is directly from client's input In this case, when doing [2] or similar changes, do we need to consider microversion usage when we change options? Thanks [1] https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/api.py#L4440 [2] https://review.openstack.org/#/c/144883 Best Regards! Kevin (Chen) Ji 纪 晨 Engineer, zVM Development, CSTL Notes: Chen CH Ji/China/IBM@IBMCN Internet: jiche...@cn.ibm.com Phone: +86-10-82454158 Address: 3/F Ring Building, ZhongGuanCun Software Park, Haidian District, Beijing 100193, PRC __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev Sean has started documenting some of this here: https://review.openstack.org/#/c/191188/ -- Thanks, Matt Riedemann __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
[openstack-dev] [nova] How to microversion API code which is not in API layer
Hi We have [1] in the db layer and it's directly used by API layer , the filters is directly from client's input In this case, when doing [2] or similar changes, do we need to consider microversion usage when we change options? Thanks [1] https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/api.py#L4440 [2] https://review.openstack.org/#/c/144883 Best Regards! Kevin (Chen) Ji 纪 晨 Engineer, zVM Development, CSTL Notes: Chen CH Ji/China/IBM@IBMCN Internet: jiche...@cn.ibm.com Phone: +86-10-82454158 Address: 3/F Ring Building, ZhongGuanCun Software Park, Haidian District, Beijing 100193, PRC__ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
