Re: [openstack-dev] [nova] Making periodic tasks config consistent.

2014-02-07 Thread Matthew Gilliard
I think I mangled my explanation a bit, sorry. I'm suggesting 2 things: 1 - make Nova's use of 0-length polling period consistent with the Oslo decorator. Nova-only. 2 - have Oslo's decorator use 0-length to mean "call regularly at the default period", rather than "call whenever any other t

Re: [openstack-dev] [nova] Making periodic tasks config consistent.

2014-02-06 Thread Matthew Gilliard
If there is agreement that it's a change worth making, then I expect something like: 1/ Add a warning for users who use period of 0 or use the default. Both in the literal sense of log.warning() and in the documentation. 2/ wait for a full release-cycle 3/ make the actual change in Juno. Does th

Re: [openstack-dev] [nova] Making periodic tasks config consistent.

2014-02-06 Thread Michael Still
On Thu, Feb 6, 2014 at 8:16 PM, Matthew Gilliard wrote: > Hello everyone. > > wrt these bugs: https://bugs.launchpad.net/nova/+bug/1276203 > https://bugs.launchpad.net/nova/+bug/1272830 - I'd just like to make sure > that the approach I'm planning makes sense. > > To summarise: Currently there

[openstack-dev] [nova] Making periodic tasks config consistent.

2014-02-06 Thread Matthew Gilliard
Hello everyone. wrt these bugs: https://bugs.launchpad.net/nova/+bug/1276203 https://bugs.launchpad.net/nova/+bug/1272830 - I'd just like to make sure that the approach I'm planning makes sense. To summarise: Currently there are a number of methods in compute/manager.py that use the @periodic