Re: [openstack-dev] [nova] String translations

2015-10-27 Thread Sean Dague
On 10/27/2015 11:34 PM, Andreas Jaeger wrote: > On 2015-10-27 15:22, Marian Horban wrote: >> Hi guys, >> >> Today I found review https://review.openstack.org/#/c/236188/. >> It doesn't look like a code review :) > > From gerrit's perspective it is a code review ;) The link in the commit > message

[openstack-dev] [nova] String translations

2015-10-27 Thread Marian Horban
Hi guys, Today I found review https://review.openstack.org/#/c/236188/. It doesn't look like a code review :) I'm just wondering... Why does nova contain these huge amount of files with strings? Why don't we move all this staff into some library? Regards, Marian

Re: [openstack-dev] [nova] String translations

2015-10-27 Thread Andreas Jaeger
On 2015-10-27 15:22, Marian Horban wrote: Hi guys, Today I found review https://review.openstack.org/#/c/236188/. It doesn't look like a code review :) From gerrit's perspective it is a code review ;) The link in the commit message explains the background. I'm just wondering... Why does