Re: [openstack-dev] [nova] config options: IRC meeting at Jan. 11th
- Orijinal Mesaj - > Kimden: "Markus Zoeller" > Kime: "OpenStack Development Mailing List (not for usage questions)" > > Gönderilenler: 13 Ocak Çarşamba 2016 17:38:21 > Konu: Re: [openstack-dev] [nova] config options: IRC meeting at Jan. 11th > Esra Celik wrote on 01/13/2016 01:29:12 PM: > > From: Esra Celik > > To: "OpenStack Development Mailing List (not for usage questions)" > > > > Date: 01/13/2016 01:30 PM > > Subject: Re: [openstack-dev] [nova] config options: IRC meeting at Jan. > 11th > > > > > > I do also realize now that I didn't make you aware of the > possibility > > > > to prevent a re-introduction of options in the modules you already > > > > cleaned [1]. I think that could be useful. > > > > References: > > > > [1] > > > > https://github.com/openstack/nova/blob/ > > > > 928813ca2b23690b4468830dd70a6cc6048181fa/nova/hacking/checks.py#L567 > > > > > I am not sure if I understood this correctly. Do you mean we should > > > check if any changes to the options occurred since we moved them to > > > nove/conf directory? > > > > No, that's not what I meant. You can enhance the hacking check in your > > "move-config-option" patch to keep that area clean for the future. > > Like I did with the database options in [1]. This gives a hint to other > > contributors, who want to introduce new config options, that they > > should be declared in "nova/conf/". > > > > [1] https://review.openstack.org/#/c/263804/2/nova/hacking/checks.py > > OK, got it. I modified nova/hacking/checks.py for my patches. > > > > Thanks a lot > I think I made a mistake to suggest to you to use the "checks.py" module. > Git will again have issues to merge this (e.g. [1]) when another change > also adds a line there. That's the same mistake I made with the > "__init__.py" module. I'm really sorry for that. I think it's best when > you remove it (if you introduced it in your patches) and I introduce > these lines when things get merged. It's not crucial to have it in your > patch, it was supposed to be a helper. > [1] https://review.openstack.org/#/c/254092/9/nova/hacking/checks.py > Slightly ashamed, Markus Zoeller (markus_z) Markus, you are extremely helpful at all stages. I should thank you for that. I see how complicated it is to work concurrently on the same scope. And this experience is a good lesson for me, thanks again. I will remove checks.py changes tomorrow. Best regards esracelik __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [nova] config options: IRC meeting at Jan. 11th
Esra Celik wrote on 01/13/2016 01:29:12 PM: > From: Esra Celik > To: "OpenStack Development Mailing List (not for usage questions)" > > Date: 01/13/2016 01:30 PM > Subject: Re: [openstack-dev] [nova] config options: IRC meeting at Jan. 11th > > > > I do also realize now that I didn't make you aware of the possibility > > > to prevent a re-introduction of options in the modules you already > > > cleaned [1]. I think that could be useful. > > > References: > > > [1] > > > https://github.com/openstack/nova/blob/ > > > 928813ca2b23690b4468830dd70a6cc6048181fa/nova/hacking/checks.py#L567 > > > I am not sure if I understood this correctly. Do you mean we should > > check if any changes to the options occurred since we moved them to > > nove/conf directory? > > No, that's not what I meant. You can enhance the hacking check in your > "move-config-option" patch to keep that area clean for the future. > Like I did with the database options in [1]. This gives a hint to other > contributors, who want to introduce new config options, that they > should be declared in "nova/conf/". > > [1] https://review.openstack.org/#/c/263804/2/nova/hacking/checks.py > OK, got it. I modified nova/hacking/checks.py for my patches. > > Thanks a lot I think I made a mistake to suggest to you to use the "checks.py" module. Git will again have issues to merge this (e.g. [1]) when another change also adds a line there. That's the same mistake I made with the "__init__.py" module. I'm really sorry for that. I think it's best when you remove it (if you introduced it in your patches) and I introduce these lines when things get merged. It's not crucial to have it in your patch, it was supposed to be a helper. [1] https://review.openstack.org/#/c/254092/9/nova/hacking/checks.py Slightly ashamed, Markus Zoeller (markus_z) __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [nova] config options: IRC meeting at Jan. 11th
- Orijinal Mesaj - > Kimden: "Markus Zoeller" > Kime: "OpenStack Development Mailing List" > > Gönderilenler: 13 Ocak Çarşamba 2016 10:36:56 > Konu: Re: [openstack-dev] [nova] config options: IRC meeting at Jan. 11th > Esra Celik wrote on 01/12/2016 12:55:25 PM: > > From: Esra Celik > > To: "OpenStack Development Mailing List (not for usage questions)" > > , Markus Zoeller/Germany/IBM@IBMDE > > Date: 01/12/2016 12:55 PM > > Subject: Re: [openstack-dev] [nova] config options: IRC meeting at Jan. > 11th > > > I think we have the technical and organizational issues solved now > > > and we should focus on enhancing the help texts of the config options > > > you have moved in other patches to give the core reviewers a single > > > bucket of a finished piece of work to review. > > We will wait for the moved config options to be merged to prepare > > another patchset with improved help texts, right? > > I could actually commit a patch with improved help texts that depends > > on the first patch.. > The latter approach is the one I mean. By this approach a reviewer > can check that the move is OK (which is simple to review) and then > review the enhanced help texts (a bit more complex to review) in > a row. OK, done for configdrive options [1] [2]. I am working on others now (hyperv and cells options) [1] https://review.openstack.org/#/c/254092/ : moves configdrive options to nova/conf [2] https://review.openstack.org/#/c/266875/ : improves the help text for configdrive options > > > I do also realize now that I didn't make you aware of the possibility > > > to prevent a re-introduction of options in the modules you already > > > cleaned [1]. I think that could be useful. > > > References: > > > [1] > > > https://github.com/openstack/nova/blob/ > > > 928813ca2b23690b4468830dd70a6cc6048181fa/nova/hacking/checks.py#L567 > > I am not sure if I understood this correctly. Do you mean we should > > check if any changes to the options occurred since we moved them to > > nove/conf directory? > No, that's not what I meant. You can enhance the hacking check in your > "move-config-option" patch to keep that area clean for the future. > Like I did with the database options in [1]. This gives a hint to other > contributors, who want to introduce new config options, that they > should be declared in "nova/conf/". > [1] https://review.openstack.org/#/c/263804/2/nova/hacking/checks.py OK, got it. I modified nova/hacking/checks.py for my patches. Thanks a lot __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [nova] config options: IRC meeting at Jan. 11th
Esra Celik wrote on 01/12/2016 12:55:25 PM: > From: Esra Celik > To: "OpenStack Development Mailing List (not for usage questions)" > , Markus Zoeller/Germany/IBM@IBMDE > Date: 01/12/2016 12:55 PM > Subject: Re: [openstack-dev] [nova] config options: IRC meeting at Jan. 11th > > I think we have the technical and organizational issues solved now > > and we should focus on enhancing the help texts of the config options > > you have moved in other patches to give the core reviewers a single > > bucket of a finished piece of work to review. > We will wait for the moved config options to be merged to prepare > another patchset with improved help texts, right? > I could actually commit a patch with improved help texts that depends > on the first patch.. The latter approach is the one I mean. By this approach a reviewer can check that the move is OK (which is simple to review) and then review the enhanced help texts (a bit more complex to review) in a row. > > I do also realize now that I didn't make you aware of the possibility > > to prevent a re-introduction of options in the modules you already > > cleaned [1]. I think that could be useful. > > References: > > [1] > > https://github.com/openstack/nova/blob/ > > 928813ca2b23690b4468830dd70a6cc6048181fa/nova/hacking/checks.py#L567 > I am not sure if I understood this correctly. Do you mean we should > check if any changes to the options occurred since we moved them to > nove/conf directory? No, that's not what I meant. You can enhance the hacking check in your "move-config-option" patch to keep that area clean for the future. Like I did with the database options in [1]. This gives a hint to other contributors, who want to introduce new config options, that they should be declared in "nova/conf/". [1] https://review.openstack.org/#/c/263804/2/nova/hacking/checks.py Regards, Markus Zoeller (markus_z) __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [nova] config options: IRC meeting at Jan. 11th
- Orijinal Mesaj - > Kimden: "Markus Zoeller" > Kime: "OpenStack Development Mailing List" > > Gönderilenler: 12 Ocak Salı 2016 10:58:28 > Konu: Re: [openstack-dev] [nova] config options: IRC meeting at Jan. 11th > Esra Celik wrote on 01/12/2016 08:21:34 AM: > > From: Esra Celik > > To: "OpenStack Development Mailing List (not for usage questions)" > > , Markus Zoeller/Germany/IBM@IBMDE > > Date: 01/12/2016 08:21 AM > > Subject: Re: [openstack-dev] [nova] config options: IRC meeting at Jan. > 11th > > > > Hi Markus > > > > I am sorry that I missed the meeting. Bu it seems like sfinucan > > already asked what was in my mind, like getting the patches merged > faster.. > > From the logs I finally understood what "single point of entry for > > sample config generation" is for. So I will wait that to be merged and > > rebase my patches [1],[2],[3], is it ok? > OK, cool, that's what I hoped for :) > It got merged yesterday evening. A rebase of your open patches makes > sense now. Don't forget to adjust the return value of "list_opts" in > your modules. OK, I adjusted the return value of list_opts.. > > Now should I work on some other patches? nova/compute/manager.py > > options seem nice :) > > Or should I focus on later patches that will improve the help texts? > > > > [1] https://review.openstack.org/#/c/254092/ > > [2] https://review.openstack.org/#/c/255124/ > > [3] https://review.openstack.org/#/c/260181/ > > > > Best Regards, > > esracelik > I think we have the technical and organizational issues solved now > and we should focus on enhancing the help texts of the config options > you have moved in other patches to give the core reviewers a single > bucket of a finished piece of work to review. We will wait for the moved config options to be merged to prepare another patchset with improved help texts, right? I could actually commit a patch with improved help texts that depends on the first patch.. > I do also realize now that I didn't make you aware of the possibility > to prevent a re-introduction of options in the modules you already > cleaned [1]. I think that could be useful. I am not sure if I understood this correctly. Do you mean we should check if any changes to the options occurred since we moved them to nove/conf directory? > References: > [1] > https://github.com/openstack/nova/blob/928813ca2b23690b4468830dd70a6cc6048181fa/nova/hacking/checks.py#L567 > Regards, Markus Zoeller (markus_z) > > Kimden: "Markus Zoeller" > > Kime: "OpenStack Development Mailing List (not for usage questions)" > > > > Gönderilenler: 11 Ocak Pazartesi 2016 17:47:23 > > Konu: Re: [openstack-dev] [nova] config options: IRC meeting at Jan. > 11th > > > > Markus Zoeller/Germany/IBM@IBMDE wrote on 01/08/2016 03:21:28 PM: > > > > > From: Markus Zoeller/Germany/IBM@IBMDE > > > To: "OpenStack Development Mailing List (not for usage questions)" > > > > > > Date: 01/08/2016 03:22 PM > > > Subject: [openstack-dev] [nova] config options: IRC meeting at Jan. > 11th > > > > > > First things first, I'd like to thank those people who are > contributing > > > to this task very much! It's good to see the progress we already made > > > and that the knowledge of this area is now spread amongst more people. > > > > > > The second thing I'd like to talk about is the next steps. > > > It would be great if we could have a short realtime conversation in > IRC > > > to: > > > * make clear that the help text changes are necessary for a patch > series > > > * clarify open questions from your side > > > * discuss the impact of [1] which should be the last piece in place > > > which reduces the merge conflicts we faced to a very minimum. > > > > > > Let's use the channel #openstack-meeting-3 at coming Monday, > > > January the 11th, at 15:00 UTC for that. > > > > > > References: > > > [1] "single point of entry for sample config generation" > > > https://review.openstack.org/#/c/260015 > > > > > > Regards, Markus Zoeller (markus_z) > > > > In case you missed it (it was on short notice), here are the logs: > > http://eavesdrop.openstack.org/meetings/nova_config_options/2016/ > > nova_config_options.2016-01-11-15.01.log.html > > > > Let me know if you have questions. > > > > Regards, Markus Zoeller (markus_z) > > > > > ___
Re: [openstack-dev] [nova] config options: IRC meeting at Jan. 11th
Esra Celik wrote on 01/12/2016 08:21:34 AM: > From: Esra Celik > To: "OpenStack Development Mailing List (not for usage questions)" > , Markus Zoeller/Germany/IBM@IBMDE > Date: 01/12/2016 08:21 AM > Subject: Re: [openstack-dev] [nova] config options: IRC meeting at Jan. 11th > > Hi Markus > > I am sorry that I missed the meeting. Bu it seems like sfinucan > already asked what was in my mind, like getting the patches merged faster.. > From the logs I finally understood what "single point of entry for > sample config generation" is for. So I will wait that to be merged and > rebase my patches [1],[2],[3], is it ok? OK, cool, that's what I hoped for :) It got merged yesterday evening. A rebase of your open patches makes sense now. Don't forget to adjust the return value of "list_opts" in your modules. > Now should I work on some other patches? nova/compute/manager.py > options seem nice :) > Or should I focus on later patches that will improve the help texts? > > [1] https://review.openstack.org/#/c/254092/ > [2] https://review.openstack.org/#/c/255124/ > [3] https://review.openstack.org/#/c/260181/ > > Best Regards, > esracelik I think we have the technical and organizational issues solved now and we should focus on enhancing the help texts of the config options you have moved in other patches to give the core reviewers a single bucket of a finished piece of work to review. I do also realize now that I didn't make you aware of the possibility to prevent a re-introduction of options in the modules you already cleaned [1]. I think that could be useful. References: [1] https://github.com/openstack/nova/blob/928813ca2b23690b4468830dd70a6cc6048181fa/nova/hacking/checks.py#L567 Regards, Markus Zoeller (markus_z) > Kimden: "Markus Zoeller" > Kime: "OpenStack Development Mailing List (not for usage questions)" > > Gönderilenler: 11 Ocak Pazartesi 2016 17:47:23 > Konu: Re: [openstack-dev] [nova] config options: IRC meeting at Jan. 11th > > Markus Zoeller/Germany/IBM@IBMDE wrote on 01/08/2016 03:21:28 PM: > > > From: Markus Zoeller/Germany/IBM@IBMDE > > To: "OpenStack Development Mailing List (not for usage questions)" > > > > Date: 01/08/2016 03:22 PM > > Subject: [openstack-dev] [nova] config options: IRC meeting at Jan. 11th > > > > First things first, I'd like to thank those people who are contributing > > to this task very much! It's good to see the progress we already made > > and that the knowledge of this area is now spread amongst more people. > > > > The second thing I'd like to talk about is the next steps. > > It would be great if we could have a short realtime conversation in IRC > > to: > > * make clear that the help text changes are necessary for a patch series > > * clarify open questions from your side > > * discuss the impact of [1] which should be the last piece in place > > which reduces the merge conflicts we faced to a very minimum. > > > > Let's use the channel #openstack-meeting-3 at coming Monday, > > January the 11th, at 15:00 UTC for that. > > > > References: > > [1] "single point of entry for sample config generation" > > https://review.openstack.org/#/c/260015 > > > > Regards, Markus Zoeller (markus_z) > > In case you missed it (it was on short notice), here are the logs: > http://eavesdrop.openstack.org/meetings/nova_config_options/2016/ > nova_config_options.2016-01-11-15.01.log.html > > Let me know if you have questions. > > Regards, Markus Zoeller (markus_z) > > __ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [nova] config options: IRC meeting at Jan. 11th
Hi Markus I am sorry that I missed the meeting. Bu it seems like sfinucan already asked what was in my mind, like getting the patches merged faster.. >From the logs I finally understood what "single point of entry for sample >config g eneration" is for. So I will wait that to be merged and rebase my >patches [1],[2],[3], is it ok? Now should I work on some other patches? nova/compute/manager.py options seem nice :) Or should I focus on later patches that will improve the help texts? [1] https://review.openstack.org/#/c/254092/ [2] https://review.openstack.org/#/c/255124/ [3] https://review.openstack.org/#/c/260181/ Best Regards, esracelik - Orijinal Mesaj - > Kimden: "Markus Zoeller" > Kime: "OpenStack Development Mailing List (not for usage questions)" > > Gönderilenler: 11 Ocak Pazartesi 2016 17:47:23 > Konu: Re: [openstack-dev] [nova] config options: IRC meeting at Jan. 11th > Markus Zoeller/Germany/IBM@IBMDE wrote on 01/08/2016 03:21:28 PM: > > From: Markus Zoeller/Germany/IBM@IBMDE > > To: "OpenStack Development Mailing List (not for usage questions)" > > > > Date: 01/08/2016 03:22 PM > > Subject: [openstack-dev] [nova] config options: IRC meeting at Jan. 11th > > > > First things first, I'd like to thank those people who are contributing > > to this task very much! It's good to see the progress we already made > > and that the knowledge of this area is now spread amongst more people. > > > > The second thing I'd like to talk about is the next steps. > > It would be great if we could have a short realtime conversation in IRC > > to: > > * make clear that the help text changes are necessary for a patch series > > * clarify open questions from your side > > * discuss the impact of [1] which should be the last piece in place > > which reduces the merge conflicts we faced to a very minimum. > > > > Let's use the channel #openstack-meeting-3 at coming Monday, > > January the 11th, at 15:00 UTC for that. > > > > References: > > [1] "single point of entry for sample config generation" > > https://review.openstack.org/#/c/260015 > > > > Regards, Markus Zoeller (markus_z) > In case you missed it (it was on short notice), here are the logs: > http://eavesdrop.openstack.org/meetings/nova_config_options/2016/nova_config_options.2016-01-11-15.01.log.html > Let me know if you have questions. > Regards, Markus Zoeller (markus_z) > __ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [nova] config options: IRC meeting at Jan. 11th
Markus Zoeller/Germany/IBM@IBMDE wrote on 01/08/2016 03:21:28 PM: > From: Markus Zoeller/Germany/IBM@IBMDE > To: "OpenStack Development Mailing List (not for usage questions)" > > Date: 01/08/2016 03:22 PM > Subject: [openstack-dev] [nova] config options: IRC meeting at Jan. 11th > > First things first, I'd like to thank those people who are contributing > to this task very much! It's good to see the progress we already made > and that the knowledge of this area is now spread amongst more people. > > The second thing I'd like to talk about is the next steps. > It would be great if we could have a short realtime conversation in IRC > to: > * make clear that the help text changes are necessary for a patch series > * clarify open questions from your side > * discuss the impact of [1] which should be the last piece in place > which reduces the merge conflicts we faced to a very minimum. > > Let's use the channel #openstack-meeting-3 at coming Monday, > January the 11th, at 15:00 UTC for that. > > References: > [1] "single point of entry for sample config generation" > https://review.openstack.org/#/c/260015 > > Regards, Markus Zoeller (markus_z) In case you missed it (it was on short notice), here are the logs: http://eavesdrop.openstack.org/meetings/nova_config_options/2016/nova_config_options.2016-01-11-15.01.log.html Let me know if you have questions. Regards, Markus Zoeller (markus_z) __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
[openstack-dev] [nova] config options: IRC meeting at Jan. 11th
First things first, I'd like to thank those people who are contributing to this task very much! It's good to see the progress we already made and that the knowledge of this area is now spread amongst more people. The second thing I'd like to talk about is the next steps. It would be great if we could have a short realtime conversation in IRC to: * make clear that the help text changes are necessary for a patch series * clarify open questions from your side * discuss the impact of [1] which should be the last piece in place which reduces the merge conflicts we faced to a very minimum. Let's use the channel #openstack-meeting-3 at coming Monday, January the 11th, at 15:00 UTC for that. References: [1] "single point of entry for sample config generation" https://review.openstack.org/#/c/260015 Regards, Markus Zoeller (markus_z) __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
