Re: [openstack-dev] [nova] is it possible to microversion a static class method?

2015-03-18 Thread Matthew Gilliard
I think that both ways of doing this should be supported. Decorated private methods make sense if the different microversions have nicely interchangeable bits of functionality but not if one of the private methods would have to be a no-op. A method which just passes is noise. Additionally there ha

Re: [openstack-dev] [nova] is it possible to microversion a static class method?

2015-03-16 Thread Alex Xu
2015-03-16 12:26 GMT+08:00 Christopher Yeoh : > So ultimately I think this is a style issue rather than a technical one. I > think there > are situations where one way looks clearer than another the other way > does. Sorry I can't get around to putting up a couple of examples, > ATM but to be clea

Re: [openstack-dev] [nova] is it possible to microversion a static class method?

2015-03-16 Thread Alex Xu
not for usage questions)" < > openstack-dev@lists.openstack.org> > Date: 03/16/2015 02:53 AM > Subject: Re: [openstack-dev] [nova] is it possible to microversion a > static class method? > -- > > > > > > 2015-03-16 9:48 GMT+08:00

Re: [openstack-dev] [nova] is it possible to microversion a static class method?

2015-03-16 Thread Chen CH Ji
[openstack-dev] [nova] is it possible to microversion a static class method? 2015-03-16 9:48 GMT+08:00 Alex Xu : 2015-03-13 19:10 GMT+08:00 Sean Dague : On 03/13/2015 02:55 AM, Chris Friesen wrote: > On 03/12/2015 12:13 PM, Sean Dague wrote: >> On 03/12/2

Re: [openstack-dev] [nova] is it possible to microversion a static class method?

2015-03-15 Thread Christopher Yeoh
So ultimately I think this is a style issue rather than a technical one. I think there are situations where one way looks clearer than another the other way does. Sorry I can't get around to putting up a couple of examples, ATM but to be clear there is no difference in the end result (no different

Re: [openstack-dev] [nova] is it possible to microversion a static class method?

2015-03-15 Thread Alex Xu
2015-03-16 9:48 GMT+08:00 Alex Xu : > > > 2015-03-13 19:10 GMT+08:00 Sean Dague : > >> On 03/13/2015 02:55 AM, Chris Friesen wrote: >> > On 03/12/2015 12:13 PM, Sean Dague wrote: >> >> On 03/12/2015 02:03 PM, Chris Friesen wrote: >> >>> Hi, >> >>> >> >>> I'm having an issue with microversions. >>

Re: [openstack-dev] [nova] is it possible to microversion a static class method?

2015-03-15 Thread Alex Xu
2015-03-13 19:10 GMT+08:00 Sean Dague : > On 03/13/2015 02:55 AM, Chris Friesen wrote: > > On 03/12/2015 12:13 PM, Sean Dague wrote: > >> On 03/12/2015 02:03 PM, Chris Friesen wrote: > >>> Hi, > >>> > >>> I'm having an issue with microversions. > >>> > >>> The api_version() code has a comment sayi

Re: [openstack-dev] [nova] is it possible to microversion a static class method?

2015-03-13 Thread Sean Dague
On 03/13/2015 02:55 AM, Chris Friesen wrote: > On 03/12/2015 12:13 PM, Sean Dague wrote: >> On 03/12/2015 02:03 PM, Chris Friesen wrote: >>> Hi, >>> >>> I'm having an issue with microversions. >>> >>> The api_version() code has a comment saying "This decorator MUST appear >>> first (the outermost d

Re: [openstack-dev] [nova] is it possible to microversion a static class method?

2015-03-13 Thread Chen CH Ji
Park, Haidian District, Beijing 100193, PRC From: Chris Friesen To: Date: 03/13/2015 07:57 AM Subject:Re: [openstack-dev] [nova] is it possible to microversion a static class method? On 03/12/2015 12:13 PM, Sean Dague wrote: > On 03/12/2015 02:03 PM, Chris

Re: [openstack-dev] [nova] is it possible to microversion a static class method?

2015-03-12 Thread Chris Friesen
On 03/12/2015 12:13 PM, Sean Dague wrote: On 03/12/2015 02:03 PM, Chris Friesen wrote: Hi, I'm having an issue with microversions. The api_version() code has a comment saying "This decorator MUST appear first (the outermost decorator) on an API method for it to work correctly" I tried making

Re: [openstack-dev] [nova] is it possible to microversion a static class method?

2015-03-12 Thread Alex Xu
2015-03-13 2:13 GMT+08:00 Sean Dague : > On 03/12/2015 02:03 PM, Chris Friesen wrote: > > Hi, > > > > I'm having an issue with microversions. > > > > The api_version() code has a comment saying "This decorator MUST appear > > first (the outermost decorator) on an API method for it to work > correc

Re: [openstack-dev] [nova] is it possible to microversion a static class method?

2015-03-12 Thread Chen CH Ji
, PRC From: Sean Dague To: openstack-dev@lists.openstack.org Date: 03/12/2015 07:16 PM Subject: Re: [openstack-dev] [nova] is it possible to microversion a static class method? On 03/12/2015 02:03 PM, Chris Friesen wrote: > Hi, > > I'm having an issue with micr

Re: [openstack-dev] [nova] is it possible to microversion a static class method?

2015-03-12 Thread Sean Dague
On 03/12/2015 02:03 PM, Chris Friesen wrote: > Hi, > > I'm having an issue with microversions. > > The api_version() code has a comment saying "This decorator MUST appear > first (the outermost decorator) on an API method for it to work correctly" > > I tried making a microversioned static class

[openstack-dev] [nova] is it possible to microversion a static class method?

2015-03-12 Thread Chris Friesen
Hi, I'm having an issue with microversions. The api_version() code has a comment saying "This decorator MUST appear first (the outermost decorator) on an API method for it to work correctly" I tried making a microversioned static class method like this: @wsgi.Controller.api_version("2.4"