Re: [openstack-dev] [nova] libvirt driver: who should create the libvirt.xml file?

2016-06-23 Thread Markus Zoeller
On 23.06.2016 11:50, Daniel P. Berrange wrote: > On Mon, Jun 20, 2016 at 05:47:57PM +0200, Markus Zoeller wrote: >> White working on the change series to implement the virtlogd feature I >> got feedback [1] to move code which creates parts of the libvirt.xml >> file from the "driver" module into

Re: [openstack-dev] [nova] libvirt driver: who should create the libvirt.xml file?

2016-06-23 Thread Daniel P. Berrange
On Mon, Jun 20, 2016 at 05:47:57PM +0200, Markus Zoeller wrote: > White working on the change series to implement the virtlogd feature I > got feedback [1] to move code which creates parts of the libvirt.xml > file from the "driver" module into the "guest" module. I'm a bit > hesitant to do so as

Re: [openstack-dev] [nova] libvirt driver: who should create the libvirt.xml file?

2016-06-22 Thread Matthew Booth
On Mon, Jun 20, 2016 at 4:47 PM, Markus Zoeller wrote: > White working on the change series to implement the virtlogd feature I > got feedback [1] to move code which creates parts of the libvirt.xml > file from the "driver" module into the "guest" module. I'm a bit

[openstack-dev] [nova] libvirt driver: who should create the libvirt.xml file?

2016-06-20 Thread Markus Zoeller
White working on the change series to implement the virtlogd feature I got feedback [1] to move code which creates parts of the libvirt.xml file from the "driver" module into the "guest" module. I'm a bit hesitant to do so as the responsibility of creating a valid libvirt.xml file is then spread