Re: [openstack-dev] [nova]Libvirt error code for failing volume in nova

2016-05-19 Thread Daniel P. Berrange
On Wed, May 18, 2016 at 07:57:17PM +, Radhakrishnan, Siva wrote: > Hi All! > Currently I am working on this bug > https://bugs.launchpad.net/nova/+bug/1168011 which says we have to change > error message displayed when attaching a volume fails. Currently it catches > all operation errors

Re: [openstack-dev] [nova]Libvirt error code for failing volume in nova

2016-05-19 Thread Silvan Kaiser
Hi! Regarding 1. I'd start with giving a generic message, e.g. "error while attaching volume" that does not point to a specific reason. Regarding 2., if the reason is identifiable throwing the corresponding exception would come in handy. Only use the generic failure if there's no specific error

[openstack-dev] [nova]Libvirt error code for failing volume in nova

2016-05-18 Thread Radhakrishnan, Siva
Hi All! Currently I am working on this bug https://bugs.launchpad.net/nova/+bug/1168011 which says we have to change error message displayed when attaching a volume fails. Currently it catches all operation errors that libvirt can raise and assume that all of them are the source of device