Re: [openstack-dev] [openstack][nova][social-apects] Social aspects shouldn't impact on dev process
On Thu, Nov 21, 2013 at 6:29 AM, David Ripton drip...@redhat.com wrote: On 11/20/2013 02:06 AM, Boris Pavlovic wrote: I faced some social problems in community. We started working on purge engine for DB (before HK summit) This is very important, because at this moment we don't have any working way to purge DB... so admins should make it by hand. And we made this BP (in october) https://blueprints.launchpad.net/nova/+spec/db-purge-engine And made patch that makes this work. But only because our BP wasn't approved we got -2 from Joe Gordon. (https://review.openstack.org/#/c/51523/ ) And there was long discussion to remove this -2. And now after summit David Ripton made the similar BP (probably he didn't know): https://blueprints.launchpad.net/nova/+spec/db-purge2 That is already approved by Joe Gordon. (that already know that we are working on same problem) Why? (btw question about Purge Engine was raised by me on the summit and community accepted that) I discussed this with Boris on IRC yesterday. When I volunteered to write a DB purger at Summit, I wasn't aware that there was already one actively in progress. (So many patches around the end of Havana.) When I went to file a blueprint and noticed the existing db-purge blueprint, I saw that its patch had been -2'd and figured it was dead. But as long as Boris is working to actively improve that patch (he's on vacation now but said he'd probably have something on Monday), I won't submit a patch for the competing blueprint. Instead, I'll work to make sure Boris's code meets everyone's requirements (some that I got from Joe Gordon and Phil Day are mentioned in db-purge2), and when it does I'll withdraw the db-purge2 blueprint and retarget remove-db-archiving to depend on Boris's blueprint instead. Thanks! unless anyone else has further complaints, I think that wraps up this thread. best, Joe -- David Ripton Red Hat drip...@redhat.com ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [openstack][nova][social-apects] Social aspects shouldn't impact on dev process
On 11/20/2013 02:06 AM, Boris Pavlovic wrote: I faced some social problems in community. We started working on purge engine for DB (before HK summit) This is very important, because at this moment we don't have any working way to purge DB... so admins should make it by hand. And we made this BP (in october) https://blueprints.launchpad.net/nova/+spec/db-purge-engine And made patch that makes this work. But only because our BP wasn't approved we got -2 from Joe Gordon. (https://review.openstack.org/#/c/51523/ ) And there was long discussion to remove this -2. And now after summit David Ripton made the similar BP (probably he didn't know): https://blueprints.launchpad.net/nova/+spec/db-purge2 That is already approved by Joe Gordon. (that already know that we are working on same problem) Why? (btw question about Purge Engine was raised by me on the summit and community accepted that) I discussed this with Boris on IRC yesterday. When I volunteered to write a DB purger at Summit, I wasn't aware that there was already one actively in progress. (So many patches around the end of Havana.) When I went to file a blueprint and noticed the existing db-purge blueprint, I saw that its patch had been -2'd and figured it was dead. But as long as Boris is working to actively improve that patch (he's on vacation now but said he'd probably have something on Monday), I won't submit a patch for the competing blueprint. Instead, I'll work to make sure Boris's code meets everyone's requirements (some that I got from Joe Gordon and Phil Day are mentioned in db-purge2), and when it does I'll withdraw the db-purge2 blueprint and retarget remove-db-archiving to depend on Boris's blueprint instead. -- David Ripton Red Hat drip...@redhat.com ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [openstack][nova][social-apects] Social aspects shouldn't impact on dev process
On Wed, Nov 20, 2013 at 5:17 PM, Tom Fifield t...@openstack.org wrote: Hi Boris, I'm sorry that you've had a frustrating experience :) Even I've written purge scripts before - so I know that this is a very useful feature :) I think that some of it was probably just due to timing issues - I've observed that things behave a bit differently than normal around release and the summit. Some specific thoughts in-line. On 20/11/13 18:06, Boris Pavlovic wrote: We started working on purge engine for DB (before HK summit) This is very important, because at this moment we don't have any working way to purge DB... so admins should make it by hand. And we made this BP (in october) https://blueprints.launchpad.net/nova/+spec/db-purge-engine And made patch that makes this work. But only because our BP wasn't approved we got -2 from Joe Gordon. (https://review.openstack.org/#/c/51523/ ) And there was long discussion to remove this -2. I've had a read of the review discussion, which (specifically related to the -2) was over 1 day, with a total of 10 messages. It seems to me that Joe's initial -2 was valid - he was just working to prevent the patch getting accidentally merged before it was ready. I think your update of the commit message and tagging as WIP was a nice compromise response, and was clear enough to remove the -2. However - my guess is that the specific -2 isn't the underlying issue here. Instead, it's about the way having a -2 on the patch changes how reviewers see it. Still guessing: my impression is that you might see a -2 on a patch as a death knell, where reviewers just stop looking at the patch thinking it's a dead end. Personally, I don't spend enough time on nova reviews to say whether this is the case. Have you observed this? perhaps someone else can chip in ? And now after summit David Ripton made the similar BP (probably he didn't know): https://blueprints.launchpad.net/nova/+spec/db-purge2 The merging of these two efforts looks like something we can fix, yes? Regards, Tom ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev Just to clarify, based on what I'm following here; the issue is not the -2 really. The issue is that a -2 was given due to the submitted BP not being approved. However the same reviewer then approved a duplicate BP that was submitted after the fact. I'm sure this was an oversight and just a matter of things being busy and loosing track of BP's. The original BP is well detailed IMO and seems like it should've been approved so folks could move on with the patch that's in process. ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [openstack][nova][social-apects] Social aspects shouldn't impact on dev process
On Nov 20, 2013 5:22 PM, John Griffith john.griff...@solidfire.com wrote: On Wed, Nov 20, 2013 at 5:17 PM, Tom Fifield t...@openstack.org wrote: Hi Boris, I'm sorry that you've had a frustrating experience :) Even I've written purge scripts before - so I know that this is a very useful feature :) I think that some of it was probably just due to timing issues - I've observed that things behave a bit differently than normal around release and the summit. Some specific thoughts in-line. On 20/11/13 18:06, Boris Pavlovic wrote: We started working on purge engine for DB (before HK summit) This is very important, because at this moment we don't have any working way to purge DB... so admins should make it by hand. And we made this BP (in october) https://blueprints.launchpad.net/nova/+spec/db-purge-engine I have been busy unbreaking the gate today, and if it's working tomorrow will provide a proper response. But in short this bp didn't get targeted for icehouse, so it didn't even get reviewed for approval. This was an oversight, things have been a little hectic getting back from the summit and dealing with the gate, so sorry if something was missed. There were also some questions about the approach taken in this BP, but I will properly respond to that tommorow. Also I am not sure what you mean with the subject line. And made patch that makes this work. But only because our BP wasn't approved we got -2 from Joe Gordon. (https://review.openstack.org/#/c/51523/ ) And there was long discussion to remove this -2. I've had a read of the review discussion, which (specifically related to the -2) was over 1 day, with a total of 10 messages. It seems to me that Joe's initial -2 was valid - he was just working to prevent the patch getting accidentally merged before it was ready. I think your update of the commit message and tagging as WIP was a nice compromise response, and was clear enough to remove the -2. However - my guess is that the specific -2 isn't the underlying issue here. Instead, it's about the way having a -2 on the patch changes how reviewers see it. Still guessing: my impression is that you might see a -2 on a patch as a death knell, where reviewers just stop looking at the patch thinking it's a dead end. Personally, I don't spend enough time on nova reviews to say whether this is the case. Have you observed this? perhaps someone else can chip in ? And now after summit David Ripton made the similar BP (probably he didn't know): https://blueprints.launchpad.net/nova/+spec/db-purge2 The merging of these two efforts looks like something we can fix, yes? Regards, Tom ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev Just to clarify, based on what I'm following here; the issue is not the -2 really. The issue is that a -2 was given due to the submitted BP not being approved. However the same reviewer then approved a duplicate BP that was submitted after the fact. I'm sure this was an oversight and just a matter of things being busy and loosing track of BP's. The original BP is well detailed IMO and seems like it should've been approved so folks could move on with the patch that's in process. ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
[openstack-dev] [openstack][nova][social-apects] Social aspects shouldn't impact on dev process
Hello Stackers, I faced some social problems in community. We started working on purge engine for DB (before HK summit) This is very important, because at this moment we don't have any working way to purge DB... so admins should make it by hand. And we made this BP (in october) https://blueprints.launchpad.net/nova/+spec/db-purge-engine And made patch that makes this work. But only because our BP wasn't approved we got -2 from Joe Gordon. (https://review.openstack.org/#/c/51523/ ) And there was long discussion to remove this -2. And now after summit David Ripton made the similar BP (probably he didn't know): https://blueprints.launchpad.net/nova/+spec/db-purge2 That is already approved by Joe Gordon. (that already know that we are working on same problem) Why? (btw question about Purge Engine was raised by me on the summit and community accepted that) Joe could you explain please? Best regards, Boris Pavlovic ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
