Re: [openstack-dev] [openstack-php-sdk] pending reviews

2014-06-23 Thread Matthew Farina
Rob, This project is in PHP. We don't currently have a full test suite run for the project via the gates. When we set it up we were told not to go down that road for a PHP project, yet. Only recently have we been told to see about getting test suite gate testing going and I've started to look at d

Re: [openstack-dev] [openstack-php-sdk] pending reviews

2014-06-19 Thread Robert Collins
What does that check that the gate doesn't? -Rob On 20 June 2014 14:20, Matthew Farina wrote: > I'll dig into these on Friday. Thanks for the poke. I started to review > them on Thursday and most of them are straight forward. But, something > happened to my test environment and I want to run t

Re: [openstack-dev] [openstack-php-sdk] pending reviews

2014-06-19 Thread Matthew Farina
I'll dig into these on Friday. Thanks for the poke. I started to review them on Thursday and most of them are straight forward. But, something happened to my test environment and I want to run the full test suite on each of these. I should have that fixed and be able to finish working through these

[openstack-dev] [openstack-php-sdk] pending reviews

2014-06-19 Thread Jamie Hannaford
Hello all, Could we get some reviews through the door? This one is fairly straight-forward - we discussed and agreed on the action item in IRC: https://review.openstack.org/#/c/99633/ Here are some more trivial ones: https://review.openstack.org/#/c/100227/ https://review.openstack.org/#/c/998