Re: [openstack-dev] [osc][openstackclient][glance] broken image functional test

[Brian Rosmaita]

Top-posting a quick follow-up.

While the reversion was in the gate queue, Ian discovered the fix so
we're going to merge that [0] instead.  So anyone who was planning to
use/test community images this weekend, please go ahead!

[0] https://review.openstack.org/#/c/423499/

cheers,
brian


On 1/20/17 11:46 AM, Dean Troyer wrote:
> On Fri, Jan 20, 2017 at 10:00 AM, Brian Rosmaita
>  wrote:
>> We've approved the revert to get the OSC unblocked, though it may be a
>> while before jenkins gets around to processing it, as (of course) the
>> gate is pretty busy now.
> 
> Thanks Brian.  This is our last week before the freeze and we're
> trying to fix our own upstream-breakage before then.
> 
>> Even with sufficient caffeine, it's not obvious.  We didn't change the
>> v1 API for this (translation for v1 is being handled in the registry),
>> and the v1 test coverage is pretty good, so it looked like nothing was
>> broken.  On a closer look, the relevant v1 tests for this particular
>> problem check the response code, not the actual response content, so we
>> will beef those up a bit.
> 
> I've proposed a couple of unit tests that appear to me to illustrate
> what OSC's functional test found.  [0] runs on top of the revert, so
> this is the 'before' check, and [1] runs with the community image
> change and should show the v1 breakage.  As is often heard, "it's
> working for me that way in DevStack" :)
> 
> dt
> 
> [0] https://review.openstack.org/423344
> [1] https://review.openstack.org/423345
> 


__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [osc][openstackclient][glance] broken image functional test

[Dean Troyer]

On Fri, Jan 20, 2017 at 10:46 AM, Dean Troyer  wrote:
> I've proposed a couple of unit tests that appear to me to illustrate
> what OSC's functional test found.  [0] runs on top of the revert, so
> this is the 'before' check, and [1] runs with the community image
> change and should show the v1 breakage.  As is often heard, "it's
> working for me that way in DevStack" :)

For completeness, Ian fixed the problem and added a functional test
[0] that also passes my little canary unit tests [1].  The revert has
been abandoned.

Ian & Brian, thanks for jumping on this quickly.

dt

[0] https://review.openstack.org/#/c/423499/
[1] https://review.openstack.org/423345


-- 

Dean Troyer
dtro...@gmail.com

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [osc][openstackclient][glance] broken image functional test

[Dean Troyer]

On Fri, Jan 20, 2017 at 10:00 AM, Brian Rosmaita
 wrote:
> We've approved the revert to get the OSC unblocked, though it may be a
> while before jenkins gets around to processing it, as (of course) the
> gate is pretty busy now.

Thanks Brian.  This is our last week before the freeze and we're
trying to fix our own upstream-breakage before then.

> Even with sufficient caffeine, it's not obvious.  We didn't change the
> v1 API for this (translation for v1 is being handled in the registry),
> and the v1 test coverage is pretty good, so it looked like nothing was
> broken.  On a closer look, the relevant v1 tests for this particular
> problem check the response code, not the actual response content, so we
> will beef those up a bit.

I've proposed a couple of unit tests that appear to me to illustrate
what OSC's functional test found.  [0] runs on top of the revert, so
this is the 'before' check, and [1] runs with the community image
change and should show the v1 breakage.  As is often heard, "it's
working for me that way in DevStack" :)

dt

[0] https://review.openstack.org/423344
[1] https://review.openstack.org/423345

-- 

Dean Troyer
dtro...@gmail.com

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [osc][openstackclient][glance] broken image functional test

[Brian Rosmaita]

On 1/20/17 9:05 AM, Dean Troyer wrote:
> On Fri, Jan 20, 2017 at 6:46 AM, Steve Martinelli
>  wrote:
>> it seems the OSC gate is broken, several patches are failing the same way:
> 
> [...]
> 
>> did something break? at first glance (hehe), it seems this patch may be to
>> blame?
>> https://github.com/openstack/glance/commit/265659e8c34865331568b069fdb27ea272df4eaa
> 
> I've posted a revert of 265659e8c34865331568b069fdb27ea272df4eaa due
> to the breakage of API v1 this late in the cycle.

We've approved the revert to get the OSC unblocked, though it may be a
while before jenkins gets around to processing it, as (of course) the
gate is pretty busy now.

> 
> A couple of attempts on my part to see why the Glance unit tests did
> not catch this have fallen short due to ENO_CAFFIENE.

Even with sufficient caffeine, it's not obvious.  We didn't change the
v1 API for this (translation for v1 is being handled in the registry),
and the v1 test coverage is pretty good, so it looked like nothing was
broken.  On a closer look, the relevant v1 tests for this particular
problem check the response code, not the actual response content, so we
will beef those up a bit.

> 
> dt
> 


__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [osc][openstackclient][glance] broken image functional test

[Dean Troyer]

On Fri, Jan 20, 2017 at 6:46 AM, Steve Martinelli
 wrote:
> it seems the OSC gate is broken, several patches are failing the same way:

[...]

> did something break? at first glance (hehe), it seems this patch may be to
> blame?
> https://github.com/openstack/glance/commit/265659e8c34865331568b069fdb27ea272df4eaa

I've posted a revert of 265659e8c34865331568b069fdb27ea272df4eaa due
to the breakage of API v1 this late in the cycle.

A couple of attempts on my part to see why the Glance unit tests did
not catch this have fallen short due to ENO_CAFFIENE.

dt

-- 

Dean Troyer
dtro...@gmail.com

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

[openstack-dev] [osc][openstackclient][glance] broken image functional test

[Steve Martinelli]

hey glancerinos,

it seems the OSC gate is broken, several patches are failing the same way:

testtools.matchers._impl.MismatchError: !=:
reference = '''\
qcow2
True
4
5
d35ba06a07654721bb730ea154b9c6e7
'''
actual= u'''\
qcow2
False
4
5
d35ba06a07654721bb730ea154b9c6e7
'''


In short, the test used to use python-glanceclient's image update method to
set the "is_public" attribute of an image to True, but now it's returning
False, here's the actual OSC test:
https://github.com/openstack/python-openstackclient/blob/master/openstackclient/tests/functional/image/v1/test_image.py#L55-L61

here's an example test result:
http://logs.openstack.org/54/423154/1/check/gate-osc-dsvm-functional-ubuntu-xenial/f23fbfa/testr_results.html.gz

did something break? at first glance (hehe), it seems this patch may be to
blame?
https://github.com/openstack/glance/commit/265659e8c34865331568b069fdb27ea272df4eaa

stevemar
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev