Re: [openstack-dev] [oslo] Log spool in the context

2016-05-26 Thread Doug Hellmann
Excerpts from Alexis Lee's message of 2016-05-26 17:29:27 +0100: > Doug Hellmann said on Thu, May 26, 2016 at 10:16:31AM -0400: > > I'm not sure silencing all messages for successful requests is a good > > idea. That was not my understanding of the intent of this work, for > > sure. I thought the i

Re: [openstack-dev] [oslo] Log spool in the context

2016-05-26 Thread Alexis Lee
Doug Hellmann said on Thu, May 26, 2016 at 10:16:31AM -0400: > I'm not sure silencing all messages for successful requests is a good > idea. That was not my understanding of the intent of this work, for > sure. I thought the idea was to run the spool logger at debug, but > maintain the other normal

Re: [openstack-dev] [oslo] Log spool in the context

2016-05-26 Thread Doug Hellmann
Excerpts from Alexis Lee's message of 2016-05-26 11:58:46 +0100: > Doug Hellmann said on Wed, May 25, 2016 at 11:56:55AM -0400: > > But that leaves it up to the application or library author to have to > > make that call for every log message, which makes logging more > > complicated. > > Almost a

Re: [openstack-dev] [oslo] Log spool in the context

2016-05-26 Thread Alexis Lee
Doug Hellmann said on Wed, May 25, 2016 at 11:56:55AM -0400: > But that leaves it up to the application or library author to have to > make that call for every log message, which makes logging more > complicated. Almost all messages generated while processing a request should only go to the reques

Re: [openstack-dev] [oslo] Log spool in the context

2016-05-25 Thread Doug Hellmann
Excerpts from Alexis Lee's message of 2016-05-25 16:24:59 +0100: > Doug Hellmann said on Wed, May 25, 2016 at 11:06:35AM -0400: > > Excerpts from Alexis Lee's message of 2016-05-25 13:46:05 +0100: > > > def some_method(ctx): > > > log = tools.get_api_logger(ctx) or LOG > > > > That "or" st

Re: [openstack-dev] [oslo] Log spool in the context

2016-05-25 Thread Alexis Lee
Doug Hellmann said on Wed, May 25, 2016 at 11:06:35AM -0400: > Excerpts from Alexis Lee's message of 2016-05-25 13:46:05 +0100: > > def some_method(ctx): > > log = tools.get_api_logger(ctx) or LOG > > That "or" statement in some_method() seems to imply though that > when spool logging is o

Re: [openstack-dev] [oslo] Log spool in the context

2016-05-25 Thread Doug Hellmann
Excerpts from Alexis Lee's message of 2016-05-25 13:46:05 +0100: > Doug Hellmann said on Tue, May 24, 2016 at 02:53:51PM -0400: > > Rather than forcing SpoolManager to be a singleton, maybe the thing > > to do is build some functions for managing a singleton instance (or > > one per type or whateve

Re: [openstack-dev] [oslo] Log spool in the context

2016-05-25 Thread Alexis Lee
Doug Hellmann said on Tue, May 24, 2016 at 02:53:51PM -0400: > Rather than forcing SpoolManager to be a singleton, maybe the thing > to do is build some functions for managing a singleton instance (or > one per type or whatever), and making that API convenient enough > that using the spool logger d

Re: [openstack-dev] [oslo] Log spool in the context

2016-05-24 Thread Doug Hellmann
Excerpts from Sean Dague's message of 2016-05-24 14:16:13 -0400: > On 05/24/2016 01:18 PM, Doug Hellmann wrote: > > Excerpts from Alexis Lee's message of 2016-05-24 09:34:36 +0100: > >> Hi, > >> > >> I have a spec: https://review.openstack.org/227766 > >> and implementation: https://review.openstac

Re: [openstack-dev] [oslo] Log spool in the context

2016-05-24 Thread Sean Dague
On 05/24/2016 01:18 PM, Doug Hellmann wrote: > Excerpts from Alexis Lee's message of 2016-05-24 09:34:36 +0100: >> Hi, >> >> I have a spec: https://review.openstack.org/227766 >> and implementation: https://review.openstack.org/316162 >> for adding a spooling logger to oslo.log. Neither is merged y

Re: [openstack-dev] [oslo] Log spool in the context

2016-05-24 Thread Doug Hellmann
Excerpts from Alexis Lee's message of 2016-05-24 09:34:36 +0100: > Hi, > > I have a spec: https://review.openstack.org/227766 > and implementation: https://review.openstack.org/316162 > for adding a spooling logger to oslo.log. Neither is merged yet, reviews > welcome. > > Looking at how I'd actu

[openstack-dev] [oslo] Log spool in the context

2016-05-24 Thread Alexis Lee
Hi, I have a spec: https://review.openstack.org/227766 and implementation: https://review.openstack.org/316162 for adding a spooling logger to oslo.log. Neither is merged yet, reviews welcome. Looking at how I'd actually integrate this into Nova, most classes do: LOG = logging.getLogger(__na