Re: [openstack-dev] [oslo] Propose to normalize namespaces

2016-12-14 Thread Doug Hellmann
Excerpts from Morales, Victor's message of 2016-12-02 19:07:25 +:
> Hey there, 
> 
> There is a mismatch of namespaces in neutron which uses AGENT and agent which 
> is addressed by Ihar in the patch[1].  That raised the question is 
> olo-config-generator should be normalize this namespaces, maybe(with my 
> limited knowledge of oslo.conf) this change can be placed in _clean_opts 
> function[2].  I personally like what Doug is suggesting[3], emitting a 
> warning where is mixing case, which at least give us an idea of places where 
> is having the same issue and eventually normalize them.  Any thoughts on this?
> 
> Regards, 
> 
> Victor Morales
> 
> [1] https://review.openstack.org/#/c/404362
> [2] 
> https://github.com/openstack/oslo.config/blob/master/oslo_config/generator.py#L331-L362
> [3] https://bugs.launchpad.net/oslo.config/+bug/1646084/comments/2

That _cleanup_opts() function looks like a good place to do the
normalization to all lower-case. Remember that "DEFAULT" is properly all
upper-case, though.

Doug

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


[openstack-dev] [oslo] Propose to normalize namespaces

2016-12-02 Thread Morales, Victor
Hey there, 

There is a mismatch of namespaces in neutron which uses AGENT and agent which 
is addressed by Ihar in the patch[1].  That raised the question is 
olo-config-generator should be normalize this namespaces, maybe(with my limited 
knowledge of oslo.conf) this change can be placed in _clean_opts function[2].  
I personally like what Doug is suggesting[3], emitting a warning where is 
mixing case, which at least give us an idea of places where is having the same 
issue and eventually normalize them.  Any thoughts on this?

Regards, 

Victor Morales

[1] https://review.openstack.org/#/c/404362
[2] 
https://github.com/openstack/oslo.config/blob/master/oslo_config/generator.py#L331-L362
[3] https://bugs.launchpad.net/oslo.config/+bug/1646084/comments/2
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev