Re: [openstack-dev] [oslo] dropping namespace packages
You rock, man. Thanks, I'll steal those. :) /Ihar On 01/11/2015 09:39 PM, Davanum Srinivas wrote: Jay, I have a hacking rule in nova already [1] and am updating the rule in the 3 reviews i have for oslo_utils, oslo_middleware and oslo_config [2] in Nova thanks, dims [1] https://github.com/openstack/nova/blob/master/nova/hacking/checks.py#L452 [2] https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:remove-oslo-namespace,n,z On Sat, Jan 10, 2015 at 9:26 PM, Jay S. Bryant jsbry...@electronicjungle.net wrote: Ihar, I agree that we should do something to enforce using the appropriate namespace so that we don't have the wrong usage sneak in. I haven't gotten any rules written yet. Have had to attend to a family commitment the last few days. Hope that I can tackle the namspace changes next week. Jay On 01/08/2015 12:24 PM, Ihar Hrachyshka wrote: On 01/08/2015 07:03 PM, Doug Hellmann wrote: I’m not sure that’s something we need to enforce. Liaisons should be updating projects now as we release libraries, and then we’ll consider whether we can drop the namespace packages when we plan the next cycle. Without a hacking rule, there is a chance old namespace usage will sneak in, and then we'll need to get back to updating imports. I would rather avoid that and get migration committed with enforcement. /Ihar ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [oslo] dropping namespace packages
Jay, I have a hacking rule in nova already [1] and am updating the rule in the 3 reviews i have for oslo_utils, oslo_middleware and oslo_config [2] in Nova thanks, dims [1] https://github.com/openstack/nova/blob/master/nova/hacking/checks.py#L452 [2] https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:remove-oslo-namespace,n,z On Sat, Jan 10, 2015 at 9:26 PM, Jay S. Bryant jsbry...@electronicjungle.net wrote: Ihar, I agree that we should do something to enforce using the appropriate namespace so that we don't have the wrong usage sneak in. I haven't gotten any rules written yet. Have had to attend to a family commitment the last few days. Hope that I can tackle the namspace changes next week. Jay On 01/08/2015 12:24 PM, Ihar Hrachyshka wrote: On 01/08/2015 07:03 PM, Doug Hellmann wrote: I’m not sure that’s something we need to enforce. Liaisons should be updating projects now as we release libraries, and then we’ll consider whether we can drop the namespace packages when we plan the next cycle. Without a hacking rule, there is a chance old namespace usage will sneak in, and then we'll need to get back to updating imports. I would rather avoid that and get migration committed with enforcement. /Ihar ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev -- Davanum Srinivas :: https://twitter.com/dims __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [oslo] dropping namespace packages
Ihar, I agree that we should do something to enforce using the appropriate namespace so that we don't have the wrong usage sneak in. I haven't gotten any rules written yet. Have had to attend to a family commitment the last few days. Hope that I can tackle the namspace changes next week. Jay On 01/08/2015 12:24 PM, Ihar Hrachyshka wrote: On 01/08/2015 07:03 PM, Doug Hellmann wrote: I’m not sure that’s something we need to enforce. Liaisons should be updating projects now as we release libraries, and then we’ll consider whether we can drop the namespace packages when we plan the next cycle. Without a hacking rule, there is a chance old namespace usage will sneak in, and then we'll need to get back to updating imports. I would rather avoid that and get migration committed with enforcement. /Ihar ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [oslo] dropping namespace packages
On Jan 8, 2015, at 11:29 AM, Ihar Hrachyshka ihrac...@redhat.com wrote: On 01/05/2015 04:51 PM, Doug Hellmann wrote: As each library is released, we will send release notes to this list, as usual. At that point the Oslo liaisons should start planning patches to change imports in their projects from oslo.foo to “oslo_foo. The old imports should still work for now, but new features will not be added to the old namespace, so over time it will be necessary to make the changes anyway. We are likely to remove the old namespace package completely during the next release cycle, but that hasn't been decided. Making the switch probably requires us to add some hacking rule that would forbid old namespace based imports, right? Do we by chance have such a rule implemented anywhere? I’m not sure that’s something we need to enforce. Liaisons should be updating projects now as we release libraries, and then we’ll consider whether we can drop the namespace packages when we plan the next cycle. Doug ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [oslo] dropping namespace packages
We talked about this in Cinder. I am planning to create some hacking checks for us just to be safe. Shouldn't take a ton of effort. Jay On Jan 8, 2015 12:03 PM, Doug Hellmann d...@doughellmann.com wrote: On Jan 8, 2015, at 11:29 AM, Ihar Hrachyshka ihrac...@redhat.com wrote: On 01/05/2015 04:51 PM, Doug Hellmann wrote: As each library is released, we will send release notes to this list, as usual. At that point the Oslo liaisons should start planning patches to change imports in their projects from oslo.foo to “oslo_foo. The old imports should still work for now, but new features will not be added to the old namespace, so over time it will be necessary to make the changes anyway. We are likely to remove the old namespace package completely during the next release cycle, but that hasn't been decided. Making the switch probably requires us to add some hacking rule that would forbid old namespace based imports, right? Do we by chance have such a rule implemented anywhere? I’m not sure that’s something we need to enforce. Liaisons should be updating projects now as we release libraries, and then we’ll consider whether we can drop the namespace packages when we plan the next cycle. Doug ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [oslo] dropping namespace packages
OK, I was going to implement something for neutron, but if you're going to handle it quickly till the end of the week, I'll wait to steal. ;) On 01/08/2015 07:14 PM, Jay Bryant wrote: We talked about this in Cinder. I am planning to create some hacking checks for us just to be safe. Shouldn't take a ton of effort. Jay On Jan 8, 2015 12:03 PM, Doug Hellmann d...@doughellmann.com mailto:d...@doughellmann.com wrote: On Jan 8, 2015, at 11:29 AM, Ihar Hrachyshka ihrac...@redhat.com mailto:ihrac...@redhat.com wrote: On 01/05/2015 04:51 PM, Doug Hellmann wrote: As each library is released, we will send release notes to this list, as usual. At that point the Oslo liaisons should start planning patches to change imports in their projects from oslo.foo to “oslo_foo. The old imports should still work for now, but new features will not be added to the old namespace, so over time it will be necessary to make the changes anyway. We are likely to remove the old namespace package completely during the next release cycle, but that hasn't been decided. Making the switch probably requires us to add some hacking rule that would forbid old namespace based imports, right? Do we by chance have such a rule implemented anywhere? I’m not sure that’s something we need to enforce. Liaisons should be updating projects now as we release libraries, and then we’ll consider whether we can drop the namespace packages when we plan the next cycle. Doug ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org mailto:OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [oslo] dropping namespace packages
On 01/08/2015 07:03 PM, Doug Hellmann wrote: I’m not sure that’s something we need to enforce. Liaisons should be updating projects now as we release libraries, and then we’ll consider whether we can drop the namespace packages when we plan the next cycle. Without a hacking rule, there is a chance old namespace usage will sneak in, and then we'll need to get back to updating imports. I would rather avoid that and get migration committed with enforcement. /Ihar ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [oslo] dropping namespace packages
On 01/05/2015 04:51 PM, Doug Hellmann wrote: As each library is released, we will send release notes to this list, as usual. At that point the Oslo liaisons should start planning patches to change imports in their projects from oslo.foo to “oslo_foo. The old imports should still work for now, but new features will not be added to the old namespace, so over time it will be necessary to make the changes anyway. We are likely to remove the old namespace package completely during the next release cycle, but that hasn't been decided. Making the switch probably requires us to add some hacking rule that would forbid old namespace based imports, right? Do we by chance have such a rule implemented anywhere? /Ihar ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [oslo] dropping namespace packages
On Nov 12, 2014, at 3:32 PM, Doug Hellmann d...@doughellmann.com wrote: We rather quickly came to consensus at the summit that we should drop the use of namespace packages in Oslo libraries [1]. As far as I could tell, everyone was happy with my proposed approach [2] of moving the code from oslo.foo to oslo_foo and then creating a backwards-compatibility shim in oslo.foo that imports public symbols from oslo_foo. We also agreed that we would not rename existing libraries, and we would continue to use the same naming convention for new libraries. So the distribution and git repository both will be called “oslo.foo” and the import statement would look like “from oslo_foo import bar”. We have made good progress on this work [1]. Because the release of oslo.concurrency before the holidays exposed some issues with our process, we have held off on releasing any more libraries until those problems were worked out. We believe we are now ready to start releasing the other libraries, and are going to start doing so this week. I plan to release a new version of oslo.config later today, and then wait a few hours to see if there are any issues (if you start seeing odd behavior related to oslo.config, please report it in #openstack-oslo). When we are confident that the release is working, we will continue with the other libraries with similar pauses over the course of the rest of the week. As each library is released, we will send release notes to this list, as usual. At that point the Oslo liaisons should start planning patches to change imports in their projects from oslo.foo to “oslo_foo. The old imports should still work for now, but new features will not be added to the old namespace, so over time it will be necessary to make the changes anyway. We are likely to remove the old namespace package completely during the next release cycle, but that hasn't been decided. Doug [1] https://blueprints.launchpad.net/oslo-incubator/+spec/drop-namespace-packages ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
[openstack-dev] [oslo] dropping namespace packages
We rather quickly came to consensus at the summit that we should drop the use of namespace packages in Oslo libraries [1]. As far as I could tell, everyone was happy with my proposed approach [2] of moving the code from oslo.foo to oslo_foo and then creating a backwards-compatibility shim in oslo.foo that imports public symbols from oslo_foo. We also agreed that we would not rename existing libraries, and we would continue to use the same naming convention for new libraries. So the distribution and git repository both will be called “oslo.foo” and the import statement would look like “from oslo_foo import bar”. Doug [1] https://etherpad.openstack.org/p/kilo-oslo-namespace-packages [2] https://review.openstack.org/128759 ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [oslo] dropping namespace packages
On Nov 12, 2014, at 3:32 PM, Doug Hellmann d...@doughellmann.com wrote: We rather quickly came to consensus at the summit that we should drop the use of namespace packages in Oslo libraries [1]. As far as I could tell, everyone was happy with my proposed approach [2] of moving the code from oslo.foo to oslo_foo and then creating a backwards-compatibility shim in oslo.foo that imports public symbols from oslo_foo. We also agreed that we would not rename existing libraries, and we would continue to use the same naming convention for new libraries. So the distribution and git repository both will be called “oslo.foo” and the import statement would look like “from oslo_foo import bar”. Doug [1] https://etherpad.openstack.org/p/kilo-oslo-namespace-packages [2] https://review.openstack.org/128759 +1 for whatever my vote is worth :) --- Donald Stufft PGP: 7C6B 7C5D 5E2B 6356 A926 F04F 6E3C BCE9 3372 DCFA ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
