Re: [openstack-dev] [puppet] about $::os_service_default

[Cody Herriges]

Yanis Guenane wrote:
> 
> On 11/03/2015 02:57 PM, Emilien Macchi wrote:
>> I'm seeing a lot of patches using the new $::os_service_default.
>>
>> Please stop trying to using it at this time. The feature is not stable
>> yet and we're testing it only for puppet-cinder module.
>> I've heard Yanis found something that is not backward compatible with
>> logging, but he's away this week so I suggest we wait next week.
>>
>> In the meantime, please do not use $::os_service_default outside
>> puppet-cinder.
>>
>> Thanks a lot,
> After a deeper investigation, the issue with logging[1] is only true if
> a user is using the puppet-openstack to only configure the component and
> not relying on it to install the RDO/UCA packages.
> 
> On RDO, the file /usr/lib/systemd/system/openstack-cinder-api.service is
> provided. It specifies :
> 
>   ExecStart=/usr/bin/cinder-api --config-file
> /usr/share/cinder/cinder-dist.conf \
> --config-file /etc/cinder/cinder.conf --logfile /var/log/cinder/api.log
> 
> On Ubuntu, the file /etc/init/cinder-api.conf is provided. It specfies :
> 
>   exec start-stop-daemon --start --chuid cinder --exec /usr/bin/cinder-api \
>  -- --config-file=/etc/cinder/cinder.conf
> --log-file=/var/log/cinder/cinder-api.log
> 
> In my understanding, this means that when using packages none of log-dir
> and log-file will ever be taken in account.
> 
> So the only use case moving those values to $::os_service_default might
> impact are for the people relying directly on the python package.
> 
> This raises two questions I'd like to ask :
> 
>   * Do lot of people use puppet-openstack modules relying on the python
> package directly ?
>   * Should we be opinionated here ? If user relies on the python
> packages, we can consider that an advanced use-case and expect the user
> to know exactly what she needs to configure. Plus we do not handle the
> use case where we want a file for cinder-volume.log and cinder-backup.log.
> 
> [1]
> https://trello.com/c/XLJJJBF0/71-move-modules-to-the-os-service-default-pattern
> 

My opinion is that installing directly from python pip is not currently
officially supported in the modules and specifically trying to take that
use case into account when we do not support it either leaves us in a
place where we have to go full in on supporting them or put the modules
in a state that thoroughly frustrates and misleads users.

If we were going to put priority on which packaging systems to support
next; I'd prefer docker over pip.


-- 
Cody



signature.asc
Description: OpenPGP digital signature
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [puppet] about $::os_service_default

[Matt Fischer]

This work is already being done by Clayton (and to a lesser extent me).
>From the openstack modules POV it mainly involves moving the packaging code
into a separate place [1][2] and then integrating with puppet-os_docker[3].
This os_docker work is only done for designate and heat and of course
requires os_docker which is not official and is rather specific to us.

As long as the external hooks are in place folks could plugin their own
venv, docker, tarball, or whatever way to install code.

[1] -
https://github.com/openstack/puppet-designate/commit/5a37cc81276cb8f8ee6dca9b9b532930e6ac86de
[2] -
https://github.com/openstack/puppet-heat/commit/dca9fe942b99b9c30e31167e4736058767738f21
[3] - https://github.com/twc-openstack/puppet-os_docker



On Fri, Nov 13, 2015 at 11:13 AM, Cody Herriges  wrote:

> Yanis Guenane wrote:
> >
> > On 11/03/2015 02:57 PM, Emilien Macchi wrote:
> >> I'm seeing a lot of patches using the new $::os_service_default.
> >>
> >> Please stop trying to using it at this time. The feature is not stable
> >> yet and we're testing it only for puppet-cinder module.
> >> I've heard Yanis found something that is not backward compatible with
> >> logging, but he's away this week so I suggest we wait next week.
> >>
> >> In the meantime, please do not use $::os_service_default outside
> >> puppet-cinder.
> >>
> >> Thanks a lot,
> > After a deeper investigation, the issue with logging[1] is only true if
> > a user is using the puppet-openstack to only configure the component and
> > not relying on it to install the RDO/UCA packages.
> >
> > On RDO, the file /usr/lib/systemd/system/openstack-cinder-api.service is
> > provided. It specifies :
> >
> >   ExecStart=/usr/bin/cinder-api --config-file
> > /usr/share/cinder/cinder-dist.conf \
> > --config-file /etc/cinder/cinder.conf --logfile
> /var/log/cinder/api.log
> >
> > On Ubuntu, the file /etc/init/cinder-api.conf is provided. It specfies :
> >
> >   exec start-stop-daemon --start --chuid cinder --exec
> /usr/bin/cinder-api \
> >  -- --config-file=/etc/cinder/cinder.conf
> > --log-file=/var/log/cinder/cinder-api.log
> >
> > In my understanding, this means that when using packages none of log-dir
> > and log-file will ever be taken in account.
> >
> > So the only use case moving those values to $::os_service_default might
> > impact are for the people relying directly on the python package.
> >
> > This raises two questions I'd like to ask :
> >
> >   * Do lot of people use puppet-openstack modules relying on the python
> > package directly ?
> >   * Should we be opinionated here ? If user relies on the python
> > packages, we can consider that an advanced use-case and expect the user
> > to know exactly what she needs to configure. Plus we do not handle the
> > use case where we want a file for cinder-volume.log and
> cinder-backup.log.
> >
> > [1]
> >
> https://trello.com/c/XLJJJBF0/71-move-modules-to-the-os-service-default-pattern
> >
>
> My opinion is that installing directly from python pip is not currently
> officially supported in the modules and specifically trying to take that
> use case into account when we do not support it either leaves us in a
> place where we have to go full in on supporting them or put the modules
> in a state that thoroughly frustrates and misleads users.
>
> If we were going to put priority on which packaging systems to support
> next; I'd prefer docker over pip.
>
>
> --
> Cody
>
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
>
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [puppet] about $::os_service_default

[Clayton O'Neill]

What Matt said.

I think we don’t need to explicitly support people that aren’t using
distribution packages, we just want to try to avoid making harder things
harder.  I don’t see a need to go out of our way to support it.  Anyone
that isn’t using distro packages should be able to figure out how to set
logdir on their own.

On Fri, Nov 13, 2015 at 1:46 PM, Matt Fischer  wrote:

> This work is already being done by Clayton (and to a lesser extent me).
> From the openstack modules POV it mainly involves moving the packaging code
> into a separate place [1][2] and then integrating with puppet-os_docker[3].
> This os_docker work is only done for designate and heat and of course
> requires os_docker which is not official and is rather specific to us.
>
> As long as the external hooks are in place folks could plugin their own
> venv, docker, tarball, or whatever way to install code.
>
> [1] -
> https://github.com/openstack/puppet-designate/commit/5a37cc81276cb8f8ee6dca9b9b532930e6ac86de
> [2] -
> https://github.com/openstack/puppet-heat/commit/dca9fe942b99b9c30e31167e4736058767738f21
> [3] - https://github.com/twc-openstack/puppet-os_docker
>
>
>
> On Fri, Nov 13, 2015 at 11:13 AM, Cody Herriges 
> wrote:
>
>> Yanis Guenane wrote:
>> >
>> > On 11/03/2015 02:57 PM, Emilien Macchi wrote:
>> >> I'm seeing a lot of patches using the new $::os_service_default.
>> >>
>> >> Please stop trying to using it at this time. The feature is not stable
>> >> yet and we're testing it only for puppet-cinder module.
>> >> I've heard Yanis found something that is not backward compatible with
>> >> logging, but he's away this week so I suggest we wait next week.
>> >>
>> >> In the meantime, please do not use $::os_service_default outside
>> >> puppet-cinder.
>> >>
>> >> Thanks a lot,
>> > After a deeper investigation, the issue with logging[1] is only true if
>> > a user is using the puppet-openstack to only configure the component and
>> > not relying on it to install the RDO/UCA packages.
>> >
>> > On RDO, the file /usr/lib/systemd/system/openstack-cinder-api.service is
>> > provided. It specifies :
>> >
>> >   ExecStart=/usr/bin/cinder-api --config-file
>> > /usr/share/cinder/cinder-dist.conf \
>> > --config-file /etc/cinder/cinder.conf --logfile
>> /var/log/cinder/api.log
>> >
>> > On Ubuntu, the file /etc/init/cinder-api.conf is provided. It specfies :
>> >
>> >   exec start-stop-daemon --start --chuid cinder --exec
>> /usr/bin/cinder-api \
>> >  -- --config-file=/etc/cinder/cinder.conf
>> > --log-file=/var/log/cinder/cinder-api.log
>> >
>> > In my understanding, this means that when using packages none of log-dir
>> > and log-file will ever be taken in account.
>> >
>> > So the only use case moving those values to $::os_service_default might
>> > impact are for the people relying directly on the python package.
>> >
>> > This raises two questions I'd like to ask :
>> >
>> >   * Do lot of people use puppet-openstack modules relying on the python
>> > package directly ?
>> >   * Should we be opinionated here ? If user relies on the python
>> > packages, we can consider that an advanced use-case and expect the user
>> > to know exactly what she needs to configure. Plus we do not handle the
>> > use case where we want a file for cinder-volume.log and
>> cinder-backup.log.
>> >
>> > [1]
>> >
>> https://trello.com/c/XLJJJBF0/71-move-modules-to-the-os-service-default-pattern
>> >
>>
>> My opinion is that installing directly from python pip is not currently
>> officially supported in the modules and specifically trying to take that
>> use case into account when we do not support it either leaves us in a
>> place where we have to go full in on supporting them or put the modules
>> in a state that thoroughly frustrates and misleads users.
>>
>> If we were going to put priority on which packaging systems to support
>> next; I'd prefer docker over pip.
>>
>>
>> --
>> Cody
>>
>>
>> __
>> OpenStack Development Mailing List (not for usage questions)
>> Unsubscribe:
>> openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>
>>
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
>
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [puppet] about $::os_service_default

[Yanis Guenane]

On 11/03/2015 02:57 PM, Emilien Macchi wrote:
> I'm seeing a lot of patches using the new $::os_service_default.
>
> Please stop trying to using it at this time. The feature is not stable
> yet and we're testing it only for puppet-cinder module.
> I've heard Yanis found something that is not backward compatible with
> logging, but he's away this week so I suggest we wait next week.
>
> In the meantime, please do not use $::os_service_default outside
> puppet-cinder.
>
> Thanks a lot,
After a deeper investigation, the issue with logging[1] is only true if
a user is using the puppet-openstack to only configure the component and
not relying on it to install the RDO/UCA packages.

On RDO, the file /usr/lib/systemd/system/openstack-cinder-api.service is
provided. It specifies :

  ExecStart=/usr/bin/cinder-api --config-file
/usr/share/cinder/cinder-dist.conf \
--config-file /etc/cinder/cinder.conf --logfile /var/log/cinder/api.log

On Ubuntu, the file /etc/init/cinder-api.conf is provided. It specfies :

  exec start-stop-daemon --start --chuid cinder --exec /usr/bin/cinder-api \
 -- --config-file=/etc/cinder/cinder.conf
--log-file=/var/log/cinder/cinder-api.log

In my understanding, this means that when using packages none of log-dir
and log-file will ever be taken in account.

So the only use case moving those values to $::os_service_default might
impact are for the people relying directly on the python package.

This raises two questions I'd like to ask :

  * Do lot of people use puppet-openstack modules relying on the python
package directly ?
  * Should we be opinionated here ? If user relies on the python
packages, we can consider that an advanced use-case and expect the user
to know exactly what she needs to configure. Plus we do not handle the
use case where we want a file for cinder-volume.log and cinder-backup.log.

[1]
https://trello.com/c/XLJJJBF0/71-move-modules-to-the-os-service-default-pattern

--
Yanis Guenane

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [puppet] about $::os_service_default

[Clayton O'Neill]

What is the issue with logging?  Can someone other than Yanis look into
this?

On Tue, Nov 3, 2015 at 8:57 AM, Emilien Macchi  wrote:

> I'm seeing a lot of patches using the new $::os_service_default.
>
> Please stop trying to using it at this time. The feature is not stable
> yet and we're testing it only for puppet-cinder module.
> I've heard Yanis found something that is not backward compatible with
> logging, but he's away this week so I suggest we wait next week.
>
> In the meantime, please do not use $::os_service_default outside
> puppet-cinder.
>
> Thanks a lot,
> --
> Emilien Macchi
>
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
>
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [puppet] about $::os_service_default

[Denis Egorenko]

+1 to Emilien.

If somebody already have uploaded such patches - please, mark them as WIP,
until we finish all work for cinder.

2015-11-03 22:57 GMT+09:00 Emilien Macchi :

> I'm seeing a lot of patches using the new $::os_service_default.
>
> Please stop trying to using it at this time. The feature is not stable
> yet and we're testing it only for puppet-cinder module.
> I've heard Yanis found something that is not backward compatible with
> logging, but he's away this week so I suggest we wait next week.
>
> In the meantime, please do not use $::os_service_default outside
> puppet-cinder.
>
> Thanks a lot,
> --
> Emilien Macchi
>
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
>


-- 
Best Regards,
Egorenko Denis,
Deployment Engineer
Mirantis
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

[openstack-dev] [puppet] about $::os_service_default

[Emilien Macchi]

I'm seeing a lot of patches using the new $::os_service_default.

Please stop trying to using it at this time. The feature is not stable
yet and we're testing it only for puppet-cinder module.
I've heard Yanis found something that is not backward compatible with
logging, but he's away this week so I suggest we wait next week.

In the meantime, please do not use $::os_service_default outside
puppet-cinder.

Thanks a lot,
-- 
Emilien Macchi



signature.asc
Description: OpenPGP digital signature
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev