Re: [openstack-dev] [puppet] adding puppet-rally to OpenStack
On 12/31/2015 06:43 PM, Andy Botting wrote: > Hi Emilien, > > > I looked again at your module and I see two options: > > * import your module in OpenStack and make it compliant (your module > does not have tests, readme, and some pieces are missing), and cleanup a > lot of things > > > Just want to confirm you're looking at this new repo: > https://github.com/andybotting/puppet-rally Unfortunately, this is not the repository we were discussing in this thread and I was not aware you would create a new one. In the meantime, I created https://review.openstack.org/262970 which is a bootstrap ready for basic structure. What I suggest is to land it and then you can import your bits (init.pp mainly) in openstack module. Does it work for you? > It was created following the guides you mentioned earlier, and does > include tests, readme, etc > > cheers, > Andy -- Emilien Macchi signature.asc Description: OpenPGP digital signature __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [puppet] adding puppet-rally to OpenStack
On 12/30/2015 09:29 PM, Andy Botting wrote: > Hi Emillien, > > > I think we would love having this module part of OpenStack, if it's ok > for you. > > The process to move it is documented [1] but I can take care of it if > you prefer, just let me know. > > Thanks for your collaboration, we're looking forward to have > puppet-rally part of our forge. > > > I think I've followed the technical part of that document, but if you > wouldn't mind handing the rest, that would be great. > > I'm glad this work will be of use to the rest of the community :) I looked again at your module and I see two options: * import your module in OpenStack and make it compliant (your module does not have tests, readme, and some pieces are missing), and cleanup a lot of things * create a new module from scratch in OpenStack using our procedure with cookiebutter (we did recent changes for new coding style), import some bits from your modules. I would be in favor of the option #2 so we could start from something clean and iterate by using your experience on this work. I happy to help in this work. Working on the import now: https://review.openstack.org/262786 https://review.openstack.org/262788 Thanks, -- Emilien Macchi signature.asc Description: OpenPGP digital signature __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [puppet] adding puppet-rally to OpenStack
Hi Emilien, > I looked again at your module and I see two options: > > * import your module in OpenStack and make it compliant (your module > does not have tests, readme, and some pieces are missing), and cleanup a > lot of things > Just want to confirm you're looking at this new repo: https://github.com/andybotting/puppet-rally It was created following the guides you mentioned earlier, and does include tests, readme, etc cheers, Andy __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [puppet] adding puppet-rally to OpenStack
Hi Emillien, > I think we would love having this module part of OpenStack, if it's ok > for you. > > The process to move it is documented [1] but I can take care of it if > you prefer, just let me know. > > Thanks for your collaboration, we're looking forward to have > puppet-rally part of our forge. > I think I've followed the technical part of that document, but if you wouldn't mind handing the rest, that would be great. I'm glad this work will be of use to the rest of the community :) cheers, Andy __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [puppet] adding puppet-rally to OpenStack
On 12/24/2015 02:16 AM, Andy Botting wrote: > Hi Emilien, > > > Emilien Macchi wrote: > > I just noticed we have a second module written by Cody: > > https://github.com/ody/puppet-rally > > > > We might want to collaborate on that. > > > > Yeah...I'd actually completely forgotten that existed until Emilien > mentioned it to me in IRC. > > It was my responsibility to deploy rally for our production cloud so I > started down the road of building a rally module that I intended to ship > upstream but things never panned out. I pretty much ran cookiecutter > and then added the openstack-rally package resource that was dependent > on our internal RPM repository that contained a openstack-rally package > I built myself because one existed no where else. I never actually ran > the module through Puppet. > > Since we were behind on deployment I put rally on the back burner until > I had something fully functional in pre-production to start running > rally against. Plus, at that time we were pre-liberty release so no one > was shipping an openstack-rally package which would have made putting > the module I started into the upstream project difficult since it would > be unusable and untestable. So, instead I focussed on tying off some > other internal things and my OpenStack time was spent working on already > established Puppet OpenStack community items, reviews and CI. > > Now we are in December and Mitaka is in full swing, there are > openstack-rally packages upstream in Mitaka repos, and our internal > pre-production install is fully functional so...I am back to working on > a rally deployment. I am happy to collaborate on merging/just promoting > one of these modules to upstream. I do not have a preference for which > one does become upstream; in their current state they probably both need > a fresh run through cookiecutter and msync > > > As discussed on IRC, I've started a new puppet-rally module: > > https://github.com/andybotting/puppet-rally > > It's based on a fresh run of cookiecutter/msync and it's fairly > complete. There's a few tests in there, but they're failing due to not > being able to find an official rally package. > > When I'm back at work in the new year, I'll be looking to switch our > production system over to this new module to test it. > > Rally has a lot of config options, so I wrote a hacky script to pull all > the options from the default rally.conf file and use them in the module. > It makes the init.pp params pretty long. I thought an alternative could > have been to pass in a hash of override params, but I prefer it this way > TBH. > > Let me know what you think. I think we would love having this module part of OpenStack, if it's ok for you. The process to move it is documented [1] but I can take care of it if you prefer, just let me know. Thanks for your collaboration, we're looking forward to have puppet-rally part of our forge. [1] https://wiki.openstack.org/wiki/Puppet/New_module -- Emilien Macchi signature.asc Description: OpenPGP digital signature __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [puppet] adding puppet-rally to OpenStack
Hi Emilien, > Emilien Macchi wrote: > > I just noticed we have a second module written by Cody: > > https://github.com/ody/puppet-rally > > > > We might want to collaborate on that. > > > > Yeah...I'd actually completely forgotten that existed until Emilien > mentioned it to me in IRC. > > It was my responsibility to deploy rally for our production cloud so I > started down the road of building a rally module that I intended to ship > upstream but things never panned out. I pretty much ran cookiecutter > and then added the openstack-rally package resource that was dependent > on our internal RPM repository that contained a openstack-rally package > I built myself because one existed no where else. I never actually ran > the module through Puppet. > > Since we were behind on deployment I put rally on the back burner until > I had something fully functional in pre-production to start running > rally against. Plus, at that time we were pre-liberty release so no one > was shipping an openstack-rally package which would have made putting > the module I started into the upstream project difficult since it would > be unusable and untestable. So, instead I focussed on tying off some > other internal things and my OpenStack time was spent working on already > established Puppet OpenStack community items, reviews and CI. > > Now we are in December and Mitaka is in full swing, there are > openstack-rally packages upstream in Mitaka repos, and our internal > pre-production install is fully functional so...I am back to working on > a rally deployment. I am happy to collaborate on merging/just promoting > one of these modules to upstream. I do not have a preference for which > one does become upstream; in their current state they probably both need > a fresh run through cookiecutter and msync As discussed on IRC, I've started a new puppet-rally module: https://github.com/andybotting/puppet-rally It's based on a fresh run of cookiecutter/msync and it's fairly complete. There's a few tests in there, but they're failing due to not being able to find an official rally package. When I'm back at work in the new year, I'll be looking to switch our production system over to this new module to test it. Rally has a lot of config options, so I wrote a hacky script to pull all the options from the default rally.conf file and use them in the module. It makes the init.pp params pretty long. I thought an alternative could have been to pass in a hash of override params, but I prefer it this way TBH. Let me know what you think. cheers, Andy __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [puppet] adding puppet-rally to OpenStack
Emilien Macchi wrote: > I just noticed we have a second module written by Cody: > https://github.com/ody/puppet-rally > > We might want to collaborate on that. > Yeah...I'd actually completely forgotten that existed until Emilien mentioned it to me in IRC. It was my responsibility to deploy rally for our production cloud so I started down the road of building a rally module that I intended to ship upstream but things never panned out. I pretty much ran cookiecutter and then added the openstack-rally package resource that was dependent on our internal RPM repository that contained a openstack-rally package I built myself because one existed no where else. I never actually ran the module through Puppet. Since we were behind on deployment I put rally on the back burner until I had something fully functional in pre-production to start running rally against. Plus, at that time we were pre-liberty release so no one was shipping an openstack-rally package which would have made putting the module I started into the upstream project difficult since it would be unusable and untestable. So, instead I focussed on tying off some other internal things and my OpenStack time was spent working on already established Puppet OpenStack community items, reviews and CI. Now we are in December and Mitaka is in full swing, there are openstack-rally packages upstream in Mitaka repos, and our internal pre-production install is fully functional so...I am back to working on a rally deployment. I am happy to collaborate on merging/just promoting one of these modules to upstream. I do not have a preference for which one does become upstream; in their current state they probably both need a fresh run through cookiecutter and msync. -- Cody signature.asc Description: OpenPGP digital signature __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [puppet] adding puppet-rally to OpenStack
I just noticed we have a second module written by Cody: https://github.com/ody/puppet-rally We might want to collaborate on that. On 12/16/2015 02:03 PM, Emilien Macchi wrote: > [adding openstack-dev mailing list for public discussion] > > Hi Andy, > > I was wondering if you would be interested to move puppet-rally [1] to > OpenStack? > We have some documentation about the process [2] but feel free to ping > us on IRC #puppet-openstack or by this thread if you're interested to > contribute. > > I think that would be awesome for OpenStack to have this module part of > our list. We would have a bit of work to bring it consistent but from > what I'm seeing, that's not a ton of things. > We also could add it in our integration testing CI and eventually run > more testing beside Tempest. > > What do you think? > > Thanks, > > [1] https://github.com/NeCTAR-RC/puppet-rally > (2] https://wiki.openstack.org/wiki/Puppet/New_module > > > > __ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > -- Emilien Macchi signature.asc Description: OpenPGP digital signature __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
[openstack-dev] [puppet] adding puppet-rally to OpenStack
[adding openstack-dev mailing list for public discussion] Hi Andy, I was wondering if you would be interested to move puppet-rally [1] to OpenStack? We have some documentation about the process [2] but feel free to ping us on IRC #puppet-openstack or by this thread if you're interested to contribute. I think that would be awesome for OpenStack to have this module part of our list. We would have a bit of work to bring it consistent but from what I'm seeing, that's not a ton of things. We also could add it in our integration testing CI and eventually run more testing beside Tempest. What do you think? Thanks, [1] https://github.com/NeCTAR-RC/puppet-rally (2] https://wiki.openstack.org/wiki/Puppet/New_module -- Emilien Macchi signature.asc Description: OpenPGP digital signature __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
