Re: [openstack-dev] [requirements] Cruft entries found in global-requirements.txt

[Vasyl Saienko]

netmiko is in networking-generic-switch requirements.txt
https://github.com/openstack/networking-generic-switch/blob/master/requirements.txt#L2

On Sat, May 7, 2016 at 5:35 AM, Haïkel  wrote:

> Started on removing some entries, I guess I have big cleanup to do RDO
> side.
>
> H.
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [requirements] Cruft entries found in global-requirements.txt

[Haïkel]

Started on removing some entries, I guess I have big cleanup to do RDO side.

H.

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [requirements] Cruft entries found in global-requirements.txt

[Jeremy Stanley]

On 2016-05-06 17:18:52 -0400 (-0400), Matthew Treinish wrote:
> On Fri, May 06, 2016 at 04:40:28PM -0400, Davanum Srinivas wrote:
[...]
> > Example feedparser is in a few projects, but not used in those
> > projects, so we can file reviews to clean up entries in specific
> > projects (except openstack-health where it is definitely used), and
> 
> FWIW, openstack-health doesn't subscribe to global-requirements,
> there isn't any reason to, it's a standalone project so
> co-installability with openstack services isn't necessary. So,
> feel free to drop it from g-r if nothing else is using it.

Yep, in general if codesearch turns up use in a repo which isn't
mentioned in
http://git.openstack.org/cgit/openstack/requirements/tree/projects.txt
then the cruft requirement is probably still a candidate for
cleanup.
-- 
Jeremy Stanley

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [requirements] Cruft entries found in global-requirements.txt

[Matthew Treinish]

On Fri, May 06, 2016 at 04:40:28PM -0400, Davanum Srinivas wrote:
> Thanks Jeremy,
> 
> Since the following folks volunteered to help with requirements:
> Dirk Mueller (SUSE)
> Haïkel Guémar (RDO/CentOS)
> Igor Yozhikov (MOS)
> Alan Pevec (RDO)
> Tony Breeds (Rackspace)
> Ghe Rivero (HPE)
> 
> So Dirk, Haïkel, Igor, Alan, Tony, Ghe, Can you please do more
> research and file reviews where ever need to cleanup?
> 
> Example feedparser is in a few projects, but not used in those
> projects, so we can file reviews to clean up entries in specific
> projects (except openstack-health where it is definitely used), and

FWIW, openstack-health doesn't subscribe to global-requirements, there isn't
any reason to, it's a standalone project so co-installability with openstack
services isn't necessary. So, feel free to drop it from g-r if nothing else is
using it.

-Matt Treinish

> also file a review against g-r and u-c to clean up the entries in the
> requirements repo as well.
> 
> If anyone else wants to get involved in requirements, please join the
> fun as well.
> 
> Thanks,
> Dims
> 
> 
> On Fri, May 6, 2016 at 2:44 PM, Jeremy Stanley  wrote:
> > On 2016-05-06 13:38:43 -0500 (-0500), Brant Knudson wrote:
> >> python-ldap and ldappool are in keystone's setup.cfg:
> >> http://git.openstack.org/cgit/openstack/keystone/tree/setup.cfg#n24
> >
> > Yep, that script will miss things like optional dependencies
> > declared in setup.cfg or things installed directly from setup.py.
> > Also I'm pretty sure it predates our python-version-specific entries
> > so it may not be parsing those entirely correctly. Plugging
> > potential cruft into http://codesearch.openstack.org/ might help
> > rule out some possibilities. When I started trying to clean this up
> > a while back (2014 maybe?) I noticed at least a few where `git blame
> > global-requirements.txt` led me back to commit messages mentioning
> > corresponding changes to consuming projects which were still in
> > review (some for many months) or had been abandoned.


signature.asc
Description: PGP signature
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [requirements] Cruft entries found in global-requirements.txt

[Davanum Srinivas]

Thanks Jeremy,

Since the following folks volunteered to help with requirements:
Dirk Mueller (SUSE)
Haïkel Guémar (RDO/CentOS)
Igor Yozhikov (MOS)
Alan Pevec (RDO)
Tony Breeds (Rackspace)
Ghe Rivero (HPE)

So Dirk, Haïkel, Igor, Alan, Tony, Ghe, Can you please do more
research and file reviews where ever need to cleanup?

Example feedparser is in a few projects, but not used in those
projects, so we can file reviews to clean up entries in specific
projects (except openstack-health where it is definitely used), and
also file a review against g-r and u-c to clean up the entries in the
requirements repo as well.

If anyone else wants to get involved in requirements, please join the
fun as well.

Thanks,
Dims


On Fri, May 6, 2016 at 2:44 PM, Jeremy Stanley  wrote:
> On 2016-05-06 13:38:43 -0500 (-0500), Brant Knudson wrote:
>> python-ldap and ldappool are in keystone's setup.cfg:
>> http://git.openstack.org/cgit/openstack/keystone/tree/setup.cfg#n24
>
> Yep, that script will miss things like optional dependencies
> declared in setup.cfg or things installed directly from setup.py.
> Also I'm pretty sure it predates our python-version-specific entries
> so it may not be parsing those entirely correctly. Plugging
> potential cruft into http://codesearch.openstack.org/ might help
> rule out some possibilities. When I started trying to clean this up
> a while back (2014 maybe?) I noticed at least a few where `git blame
> global-requirements.txt` led me back to commit messages mentioning
> corresponding changes to consuming projects which were still in
> review (some for many months) or had been abandoned.
> --
> Jeremy Stanley
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev



-- 
Davanum Srinivas :: https://twitter.com/dims

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [requirements] Cruft entries found in global-requirements.txt

[Jeremy Stanley]

On 2016-05-06 13:38:43 -0500 (-0500), Brant Knudson wrote:
> python-ldap and ldappool are in keystone's setup.cfg:
> http://git.openstack.org/cgit/openstack/keystone/tree/setup.cfg#n24

Yep, that script will miss things like optional dependencies
declared in setup.cfg or things installed directly from setup.py.
Also I'm pretty sure it predates our python-version-specific entries
so it may not be parsing those entirely correctly. Plugging
potential cruft into http://codesearch.openstack.org/ might help
rule out some possibilities. When I started trying to clean this up
a while back (2014 maybe?) I noticed at least a few where `git blame
global-requirements.txt` led me back to commit messages mentioning
corresponding changes to consuming projects which were still in
review (some for many months) or had been abandoned.
-- 
Jeremy Stanley

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [requirements] Cruft entries found in global-requirements.txt

[Steve Martinelli]

python-ldap is definitely used by keystone. I think expanding your search
to include setup.cfg in addition to req.txt and test-req.txt would catch
this case.
ldap is optional for keystone and we use setuptool's optional dependencies
expose it. i'll update the etherpad.

On Fri, May 6, 2016 at 2:20 PM, Davanum Srinivas  wrote:

> Folks,
>
> Thanks to Jeremy for pointing to [1]. Please see list below with
> things that are considered cruft as they don't seem to appear in
> requirements/test-requirements in projects. Some of them are clearly
> needed by us :) like libvirt-python. Others are questionable. Example
> sockjs-tornado added for Horizon ended up not being used AFAICT.
>
> Please add notes in etherpad if anyone has an idea if these are needed or
> not:
> https://etherpad.openstack.org/p/requirements-cruft
>
> Thanks,
> Dims
>
> [1]
> http://git.openstack.org/cgit/openstack/requirements/tree/tools/cruft.sh
> [2] https://review.openstack.org/#/q/topic:bp/sparklines,n,z
>
>
> ==
> XStatic-Angular-FileUpload
> XStatic-JQuery.Bootstrap.Wizard
> XStatic-Magic-Search
> XStatic-QUnit
> XenAPI
> aodhclient
> argcomplete
> botocore
> ceilometermiddleware
> dcos
> django-bootstrap-form
> extras
> fairy-slipper
> feedparser
> hgtools
> influxdb
> ironic-discoverd
> ldappool
> libvirt-python
> mimic
> netmiko
> notifier
> os-apply-config
> os-cloud-config
> os-net-config
> os-refresh-config
> posix_ipc
> pyghmi
> pylxd
> pysqlite;python_version
> python-consul
> python-ldap
> python-solumclient
> requestsexceptions
> singledispatch
> sockjs-tornado
> sphinxcontrib-blockdiag
> tripleo-image-elements
> weakrefmethod;python_version
> xmltodict
> ==
>
> --
> Davanum Srinivas :: https://twitter.com/dims
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [requirements] Cruft entries found in global-requirements.txt

[Brant Knudson]

On Fri, May 6, 2016 at 1:20 PM, Davanum Srinivas  wrote:

> Folks,
>
> Thanks to Jeremy for pointing to [1]. Please see list below with
> things that are considered cruft as they don't seem to appear in
> requirements/test-requirements in projects. Some of them are clearly
> needed by us :) like libvirt-python. Others are questionable. Example
> sockjs-tornado added for Horizon ended up not being used AFAICT.
>
> Please add notes in etherpad if anyone has an idea if these are needed or
> not:
> https://etherpad.openstack.org/p/requirements-cruft
>
> Thanks,
> Dims
>
> [1]
> http://git.openstack.org/cgit/openstack/requirements/tree/tools/cruft.sh
> [2] https://review.openstack.org/#/q/topic:bp/sparklines,n,z
>
>
> ==
> XStatic-Angular-FileUpload
> XStatic-JQuery.Bootstrap.Wizard
> XStatic-Magic-Search
> XStatic-QUnit
> XenAPI
> aodhclient
> argcomplete
> botocore
> ceilometermiddleware
> dcos
> django-bootstrap-form
> extras
> fairy-slipper
> feedparser
> hgtools
> influxdb
> ironic-discoverd
> ldappool
> libvirt-python
> mimic
> netmiko
> notifier
> os-apply-config
> os-cloud-config
> os-net-config
> os-refresh-config
> posix_ipc
> pyghmi
> pylxd
> pysqlite;python_version
> python-consul
> python-ldap
> python-solumclient
> requestsexceptions
> singledispatch
> sockjs-tornado
> sphinxcontrib-blockdiag
> tripleo-image-elements
> weakrefmethod;python_version
> xmltodict
> ==
>
>
python-ldap and ldappool are in keystone's setup.cfg:
http://git.openstack.org/cgit/openstack/keystone/tree/setup.cfg#n24

-- 
- Brant
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

[openstack-dev] [requirements] Cruft entries found in global-requirements.txt

[Davanum Srinivas]

Folks,

Thanks to Jeremy for pointing to [1]. Please see list below with
things that are considered cruft as they don't seem to appear in
requirements/test-requirements in projects. Some of them are clearly
needed by us :) like libvirt-python. Others are questionable. Example
sockjs-tornado added for Horizon ended up not being used AFAICT.

Please add notes in etherpad if anyone has an idea if these are needed or not:
https://etherpad.openstack.org/p/requirements-cruft

Thanks,
Dims

[1] http://git.openstack.org/cgit/openstack/requirements/tree/tools/cruft.sh
[2] https://review.openstack.org/#/q/topic:bp/sparklines,n,z


==
XStatic-Angular-FileUpload
XStatic-JQuery.Bootstrap.Wizard
XStatic-Magic-Search
XStatic-QUnit
XenAPI
aodhclient
argcomplete
botocore
ceilometermiddleware
dcos
django-bootstrap-form
extras
fairy-slipper
feedparser
hgtools
influxdb
ironic-discoverd
ldappool
libvirt-python
mimic
netmiko
notifier
os-apply-config
os-cloud-config
os-net-config
os-refresh-config
posix_ipc
pyghmi
pylxd
pysqlite;python_version
python-consul
python-ldap
python-solumclient
requestsexceptions
singledispatch
sockjs-tornado
sphinxcontrib-blockdiag
tripleo-image-elements
weakrefmethod;python_version
xmltodict
==

-- 
Davanum Srinivas :: https://twitter.com/dims

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev