Re: [openstack-dev] [requirements] race in keystone unit tests

2016-08-03 Thread Sean Dague
On 08/03/2016 12:26 PM, Lance Bragstad wrote: > Sending a follow-up because I think we ended up finding something > relevant to this discussion. > > As keystone moves towards making fernet the default, one of our work > items was to mock the system clock in tests. This allows us to advance > the

Re: [openstack-dev] [requirements] race in keystone unit tests

2016-08-03 Thread Doug Hellmann
Excerpts from Lance Bragstad's message of 2016-08-03 11:26:56 -0500: > Sending a follow-up because I think we ended up finding something relevant > to this discussion. > > As keystone moves towards making fernet the default, one of our work items > was to mock the system clock in tests. This

Re: [openstack-dev] [requirements] race in keystone unit tests

2016-08-03 Thread Lance Bragstad
Sending a follow-up because I think we ended up finding something relevant to this discussion. As keystone moves towards making fernet the default, one of our work items was to mock the system clock in tests. This allows us to advance the clock by one second where we need to avoid sub-second race

Re: [openstack-dev] [requirements] race in keystone unit tests

2016-08-02 Thread Lance Bragstad
Hi Sean, Thanks for the information. This obviously looks Fernet-related and I would be happy to spend some cycles on it. We recently landed a bunch of refactors in keystone to improve Fernet test coverage. This could be related to those refactors. Just double checking - but you haven't opened a

[openstack-dev] [requirements] race in keystone unit tests

2016-08-02 Thread Sean Dague
One of my concerns about stacking up project unit tests in the requirements jobs, is the unit tests aren't as free of races as you would imagine. Because they only previously impacted the one project team, those teams are often just fast to recheck instead of get to the bottom of it. Cross testing