Re: [openstack-dev] [savanna] Undoing a change in the alembic migrations
Just to clarify, new migration scripts should be added. You can find details on how to do it here - https://github.com/openstack/savanna/blob/master/savanna/db/migration/alembic_migrations/README On Thu, Jan 30, 2014 at 8:16 AM, Alexander Ignatov wrote: > Yes, you need create new migration script. Btw, we already have started > doing this. > The first example was when Jon added 'neutron' param to the > 'job_execution' object: > > https://review.openstack.org/#/c/63517/17/savanna/db/migration/alembic_migrations/versions/002_add_job_exec_extra.py > > Regards, > Alexander Ignatov > > > > On 30 Jan 2014, at 02:25, Andrew Lazarev wrote: > > +1 on new migration script. Just to be consecutive. > > Andrew. > > > On Wed, Jan 29, 2014 at 2:17 PM, Trevor McKay wrote: > >> Hi Sergey, >> >> In https://review.openstack.org/#/c/69982/1 we are moving the >> 'main_class' and 'java_opts' fields for a job execution into the >> job_configs['configs'] dictionary. This means that 'main_class' and >> 'java_opts' don't need to be in the database anymore. >> >> These fields were just added in the initial version of the migration >> scripts. The README says that migrations work "from icehouse". Since >> this is the initial script, does that mean we can just remove references >> to those fields from the db models and the script, or do we need a new >> migration script (002) to erase them? >> >> Thanks, >> >> Trevor >> >> >> ___ >> OpenStack-dev mailing list >> OpenStack-dev@lists.openstack.org >> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev >> > > ___ > OpenStack-dev mailing list > OpenStack-dev@lists.openstack.org > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > > > > ___ > OpenStack-dev mailing list > OpenStack-dev@lists.openstack.org > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > > -- Sincerely yours, Sergey Lukjanov Savanna Technical Lead Mirantis Inc. ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [savanna] Undoing a change in the alembic migrations
Yes, you need create new migration script. Btw, we already have started doing this. The first example was when Jon added ‘neutron’ param to the ‘job_execution’ object: https://review.openstack.org/#/c/63517/17/savanna/db/migration/alembic_migrations/versions/002_add_job_exec_extra.py Regards, Alexander Ignatov On 30 Jan 2014, at 02:25, Andrew Lazarev wrote: > +1 on new migration script. Just to be consecutive. > > Andrew. > > > On Wed, Jan 29, 2014 at 2:17 PM, Trevor McKay wrote: > Hi Sergey, > > In https://review.openstack.org/#/c/69982/1 we are moving the > 'main_class' and 'java_opts' fields for a job execution into the > job_configs['configs'] dictionary. This means that 'main_class' and > 'java_opts' don't need to be in the database anymore. > > These fields were just added in the initial version of the migration > scripts. The README says that migrations work "from icehouse". Since > this is the initial script, does that mean we can just remove references > to those fields from the db models and the script, or do we need a new > migration script (002) to erase them? > > Thanks, > > Trevor > > > ___ > OpenStack-dev mailing list > OpenStack-dev@lists.openstack.org > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > > ___ > OpenStack-dev mailing list > OpenStack-dev@lists.openstack.org > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [savanna] Undoing a change in the alembic migrations
+1 on new migration script. Just to be consecutive. Andrew. On Wed, Jan 29, 2014 at 2:17 PM, Trevor McKay wrote: > Hi Sergey, > > In https://review.openstack.org/#/c/69982/1 we are moving the > 'main_class' and 'java_opts' fields for a job execution into the > job_configs['configs'] dictionary. This means that 'main_class' and > 'java_opts' don't need to be in the database anymore. > > These fields were just added in the initial version of the migration > scripts. The README says that migrations work "from icehouse". Since > this is the initial script, does that mean we can just remove references > to those fields from the db models and the script, or do we need a new > migration script (002) to erase them? > > Thanks, > > Trevor > > > ___ > OpenStack-dev mailing list > OpenStack-dev@lists.openstack.org > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
[openstack-dev] [savanna] Undoing a change in the alembic migrations
Hi Sergey, In https://review.openstack.org/#/c/69982/1 we are moving the 'main_class' and 'java_opts' fields for a job execution into the job_configs['configs'] dictionary. This means that 'main_class' and 'java_opts' don't need to be in the database anymore. These fields were just added in the initial version of the migration scripts. The README says that migrations work "from icehouse". Since this is the initial script, does that mean we can just remove references to those fields from the db models and the script, or do we need a new migration script (002) to erase them? Thanks, Trevor ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
