Re: [openstack-dev] [savanna] savannaclient v2 api

2014-01-28 Thread Alexander Ignatov
“EDP internal” I meant current EDP specific code. And since job configs are job-specific I’d prefer to have urls containing /jobs or at least /edp for that. Regards, Alexander Ignatov On 24 Jan 2014, at 23:20, Matthew Farrellee m...@redhat.com wrote: what do you consider EDP internal, and

Re: [openstack-dev] [savanna] savannaclient v2 api

2014-01-28 Thread Sergey Lukjanov
Additionally, I think that we should explicitly specify the need to ensure that all outputs doesn't contain any sensitive information like credentials. On Tue, Jan 28, 2014 at 4:06 PM, Alexander Ignatov aigna...@mirantis.comwrote: EDP internal I meant current EDP specific code. And since job

Re: [openstack-dev] [savanna] savannaclient v2 api

2014-01-27 Thread Trevor McKay
We should consider turning mains into a string instead of a list for v2. Hive and Pig Oozie actions use mains, and each may only specify a single script element. There is no utility akaik for having multiple mains associated with a job. Workflows with multiple actions might need multiple mains,

Re: [openstack-dev] [savanna] savannaclient v2 api

2014-01-24 Thread Matthew Farrellee
what do you consider EDP internal, and how does it relate to the v1.1 or v2 API? i'm ok with making it plugin independent. i'd just suggest moving it out of /jobs and to something like /extra/config-hints/{type}, maybe along with /extra/validations/config. best, matt On 01/22/2014 06:25

Re: [openstack-dev] [savanna] savannaclient v2 api

2014-01-22 Thread Alexander Ignatov
Current EDP config-hints are not only plugin specific. Several types of jobs must have certain key/values and without it job will fail. For instance, MapReduce (former Jar) job type requires Mapper/Reducer classes parameters to be set[1]. Moreover, for such kind of jobs we already have separated

Re: [openstack-dev] [savanna] savannaclient v2 api

2014-01-20 Thread Matthew Farrellee
(inline, trying to make this readable by a text-only mail client that doesn't use tabs to indicate quoting) On 01/20/2014 02:50 AM, Andrey Lazarev wrote: -- FIX - @rest.get('/jobs/config-hints/__job_type') - should move to GET /plugins/plugin_name/__plugin_version,

Re: [openstack-dev] [savanna] savannaclient v2 api

2014-01-20 Thread Matthew Farrellee
(inline-ish) On 01/20/2014 02:36 AM, Andrey Lazarev wrote: On Sun, Jan 19, 2014 at 7:53 AM, Matthew Farrellee m...@redhat.com mailto:m...@redhat.com wrote: On 01/16/2014 09:19 PM, Andrey Lazarev wrote: REMOVE -

Re: [openstack-dev] [savanna] savannaclient v2 api

2014-01-20 Thread Andrey Lazarev
Inlined. On Mon, Jan 20, 2014 at 8:15 AM, Matthew Farrellee m...@redhat.com wrote: (inline, trying to make this readable by a text-only mail client that doesn't use tabs to indicate quoting) On 01/20/2014 02:50 AM, Andrey Lazarev wrote: -- FIX -

Re: [openstack-dev] [savanna] savannaclient v2 api

2014-01-20 Thread Matthew Farrellee
On 01/20/2014 12:50 PM, Andrey Lazarev wrote: Inlined. On Mon, Jan 20, 2014 at 8:15 AM, Matthew Farrellee m...@redhat.com mailto:m...@redhat.com wrote: (inline, trying to make this readable by a text-only mail client that doesn't use tabs to indicate quoting) On 01/20/2014 02:50

Re: [openstack-dev] [savanna] savannaclient v2 api

2014-01-19 Thread Matthew Farrellee
On 01/16/2014 08:10 AM, Alexander Ignatov wrote: Matthew, I'm ok with proposed solution. Some comments/thoughts below: - FIX - @rest.post_file('/plugins/plugin_name/version/convert-config/name') - this is an RPC call, made only by a client to do input validation, move to POST

Re: [openstack-dev] [savanna] savannaclient v2 api

2014-01-19 Thread Matthew Farrellee
On 01/16/2014 09:19 PM, Andrey Lazarev wrote: My 5 cents: -- REMOVE - @rest.put('/node-group-templates/node_group_template_id') - Not Implemented REMOVE - @rest.put('/cluster-templates/cluster_template_id') - Not Implemented -- Disagree with that. Samsung people did great job in both

Re: [openstack-dev] [savanna] savannaclient v2 api

2014-01-19 Thread Andrey Lazarev
On Sun, Jan 19, 2014 at 7:53 AM, Matthew Farrellee m...@redhat.com wrote: On 01/16/2014 09:19 PM, Andrey Lazarev wrote: My 5 cents: -- REMOVE - @rest.put('/node-group-templates/node_group_template_id') - Not Implemented REMOVE - @rest.put('/cluster-templates/cluster_template_id') -

Re: [openstack-dev] [savanna] savannaclient v2 api

2014-01-19 Thread Andrey Lazarev
Inlined. Thanks, Andrew. On Sun, Jan 19, 2014 at 7:50 AM, Matthew Farrellee m...@redhat.com wrote: On 01/16/2014 08:10 AM, Alexander Ignatov wrote: Matthew, I'm ok with proposed solution. Some comments/thoughts below: - FIX - @rest.post_file('/plugins/plugin_name/version/

Re: [openstack-dev] [savanna] savannaclient v2 api

2014-01-17 Thread Alexander Ignatov
++ for generic PUT for both ‘cancel’ and ‘refresh-status’, Andrew. Thanks! Regards, Alexander Ignatov On 17 Jan 2014, at 06:19, Andrey Lazarev alaza...@mirantis.com wrote: My 5 cents: -- REMOVE - @rest.put('/node-group-templates/node_group_template_id') - Not Implemented REMOVE -

Re: [openstack-dev] [savanna] savannaclient v2 api

2014-01-16 Thread Alexander Ignatov
Matthew, I'm ok with proposed solution. Some comments/thoughts below: - FIX - @rest.post_file('/plugins/plugin_name/version/convert-config/name') - this is an RPC call, made only by a client to do input validation, move to POST /validations/plugins/:name/:version/check-config-import

Re: [openstack-dev] [savanna] savannaclient v2 api

2014-01-16 Thread Andrey Lazarev
My 5 cents: -- REMOVE - @rest.put('/node-group-templates/node_group_template_id') - Not Implemented REMOVE - @rest.put('/cluster-templates/cluster_template_id') - Not Implemented -- Disagree with that. Samsung people did great job in both savanna/savanna-dashboard to make this implemented

[openstack-dev] [savanna] savannaclient v2 api

2014-01-14 Thread Matthew Farrellee
https://blueprints.launchpad.net/savanna/+spec/v2-api I've finished a review of the v1.0 and v1.1 APIs with an eye to making them more consistent and RESTful. Please use this thread to comment on my suggestions for v1.0 v1.1, or to make further suggestions. Best, matt