Re: [openstack-dev] [tc][nova][mogan] How to show respect to the original authors?

2017-09-22 Thread Zhenguo Niu
Thanks Sean for the suggestion, os-brick is indeed a good example for sharing codes. Will discuss with the team to see if it's possible to move that code into such a library. On Fri, Sep 22, 2017 at 9:26 PM, Sean McGinnis wrote: > > > > > > Luckily, since these things are

Re: [openstack-dev] [tc][nova][mogan] How to show respect to the original authors?

2017-09-22 Thread Sean McGinnis
> > > > Luckily, since these things are part of the ABI of Nova, they are > > versioned in many cases, and in all have a well defined interfaces on > > one side. Seems like it should be relatively straight forward to wrap > > the other side of them and call it a library. > > > >

Re: [openstack-dev] [tc][nova][mogan] How to show respect to the original authors?

2017-09-22 Thread Zhenguo Niu
@Dims, sure, will make a formal request, thanks! On Fri, Sep 22, 2017 at 8:45 PM, Davanum Srinivas wrote: > @Zhenguo, > > Can you make a formal request via email? add "[infra]" and "[mogan]" > tags so everyone in mogan is aware of this and the infra folks give > their ok.

Re: [openstack-dev] [tc][nova][mogan] How to show respect to the original authors?

2017-09-22 Thread Davanum Srinivas
@Zhenguo, Can you make a formal request via email? add "[infra]" and "[mogan]" tags so everyone in mogan is aware of this and the infra folks give their ok. Then we can ping infra using "infra-root" on the #openstack-infra channel and ask them to replace. Sounds good? Thanks, Dims On Fri, Sep

Re: [openstack-dev] [tc][nova][mogan] How to show respect to the original authors?

2017-09-22 Thread Zhenguo Niu
@Dims, Yes, I think the history is OK, do I need to ping some infra guys or if you can help to replace the repo? On Fri, Sep 22, 2017 at 7:22 PM, Davanum Srinivas wrote: > @Zhenguo, > > Can you please confirm that the history looks good? > > Thanks, > Dims > > On Fri, Sep

Re: [openstack-dev] [tc][nova][mogan] How to show respect to the original authors?

2017-09-22 Thread Davanum Srinivas
@Zhenguo, Can you please confirm that the history looks good? Thanks, Dims On Fri, Sep 22, 2017 at 1:35 AM, Zhenguo Niu wrote: > Thanks dims, that's cool :D > > I'll make sure there's no new patches landed to master before replacing the > repo. > > On Fri, Sep 22, 2017

Re: [openstack-dev] [tc][nova][mogan] How to show respect to the original authors?

2017-09-21 Thread Zhenguo Niu
Thanks dims, that's cool :D I'll make sure there's no new patches landed to master before replacing the repo. On Fri, Sep 22, 2017 at 9:53 AM, Davanum Srinivas wrote: > Zhenguo, > > I did some fancy surgery with both cinder and nova repos to add the > history, please check

Re: [openstack-dev] [tc][nova][mogan] How to show respect to the original authors?

2017-09-21 Thread Davanum Srinivas
Zhenguo, I did some fancy surgery with both cinder and nova repos to add the history, please check my repo here: https://github.com/dims/mogan/commits/master (Needed quota.py from cinder and rest of the files from Nova) If that repo looks good, then we can request infra folks to replace the

Re: [openstack-dev] [tc][nova][mogan] How to show respect to the original authors?

2017-09-21 Thread Zhenguo Niu
On Thu, Sep 21, 2017 at 1:33 PM, Clint Byrum wrote: > Excerpts from Michael Still's message of 2017-09-20 10:25:17 -0600: > > Dims, I'm not sure that's actually possible though. Many of these files > > have been through rewrites and developed over a large number of years. > >

Re: [openstack-dev] [tc][nova][mogan] How to show respect to the original authors?

2017-09-21 Thread Zhenguo Niu
On Wed, Sep 20, 2017 at 7:51 PM, Davanum Srinivas wrote: > Zhenguo, > > Thanks for bringing this up. > > For #1, yes please indicate which file from Nova, so if anyone wanted > to cross check for fixes etc can go look in Nova > For #2, When you pick up a commit from Nova,

Re: [openstack-dev] [tc][nova][mogan] How to show respect to the original authors?

2017-09-21 Thread Zhenguo Niu
Thanks John Dickinson, we can follow Swift's way but as Michael Still mentioned seems listing all authors isn't practical. On Thu, Sep 21, 2017 at 5:43 AM, John Dickinson wrote: > > > On 20 Sep 2017, at 9:25, Michael Still wrote: > > > Dims, I'm not sure that's actually possible

Re: [openstack-dev] [tc][nova][mogan] How to show respect to the original authors?

2017-09-21 Thread Zhenguo Niu
On Fri, Sep 22, 2017 at 5:48 AM, Matt Riedemann wrote: > On 9/21/2017 11:55 AM, Mike Perez wrote: > >> On 15:56 Sep 20, Flavio Percoco wrote: >> >>> On 20/09/17 12:21 +, Jeremy Stanley wrote: >>> On 2017-09-20 07:51:29 -0400 (-0400), Davanum Srinivas wrote:

Re: [openstack-dev] [tc][nova][mogan] How to show respect to the original authors?

2017-09-21 Thread Matt Riedemann
On 9/21/2017 11:55 AM, Mike Perez wrote: On 15:56 Sep 20, Flavio Percoco wrote: On 20/09/17 12:21 +, Jeremy Stanley wrote: On 2017-09-20 07:51:29 -0400 (-0400), Davanum Srinivas wrote: [...] please indicate which file from Nova, so if anyone wanted to cross check for fixes etc can go look

Re: [openstack-dev] [tc][nova][mogan] How to show respect to the original authors?

2017-09-21 Thread Mike Perez
On 15:56 Sep 20, Flavio Percoco wrote: > On 20/09/17 12:21 +, Jeremy Stanley wrote: > > On 2017-09-20 07:51:29 -0400 (-0400), Davanum Srinivas wrote: > > [...] > > > please indicate which file from Nova, so if anyone wanted to cross > > > check for fixes etc can go look in Nova > > [...] > >

Re: [openstack-dev] [tc][nova][mogan] How to show respect to the original authors?

2017-09-20 Thread Clint Byrum
Excerpts from Michael Still's message of 2017-09-20 10:25:17 -0600: > Dims, I'm not sure that's actually possible though. Many of these files > have been through rewrites and developed over a large number of years. > Listing all authors isn't practical. > > Given the horse has bolted on forking

Re: [openstack-dev] [tc][nova][mogan] How to show respect to the original authors?

2017-09-20 Thread John Dickinson
On 20 Sep 2017, at 9:25, Michael Still wrote: > Dims, I'm not sure that's actually possible though. Many of these files > have been through rewrites and developed over a large number of years. > Listing all authors isn't practical. > > Given the horse has bolted on forking these files, I feel

Re: [openstack-dev] [tc][nova][mogan] How to show respect to the original authors?

2017-09-20 Thread Michael Still
Dims, I'm not sure that's actually possible though. Many of these files have been through rewrites and developed over a large number of years. Listing all authors isn't practical. Given the horse has bolted on forking these files, I feel like a comment acknowledging the original source file is

Re: [openstack-dev] [tc][nova][mogan] How to show respect to the original authors?

2017-09-20 Thread Flavio Percoco
On 20/09/17 12:21 +, Jeremy Stanley wrote: On 2017-09-20 07:51:29 -0400 (-0400), Davanum Srinivas wrote: [...] please indicate which file from Nova, so if anyone wanted to cross check for fixes etc can go look in Nova [...] While the opportunity has probably passed in this case, the ideal

Re: [openstack-dev] [tc][nova][mogan] How to show respect to the original authors?

2017-09-20 Thread Jeremy Stanley
On 2017-09-20 07:51:29 -0400 (-0400), Davanum Srinivas wrote: [...] > please indicate which file from Nova, so if anyone wanted to cross > check for fixes etc can go look in Nova [...] While the opportunity has probably passed in this case, the ideal method is to start with a Git fork of the

Re: [openstack-dev] [tc][nova][mogan] How to show respect to the original authors?

2017-09-20 Thread Davanum Srinivas
Zhenguo, Thanks for bringing this up. For #1, yes please indicate which file from Nova, so if anyone wanted to cross check for fixes etc can go look in Nova For #2, When you pick up a commit from Nova, please make sure the commit message in Mogan has the following * The gerrit change id(s) of

[openstack-dev] [tc][nova][mogan] How to show respect to the original authors?

2017-09-20 Thread Zhenguo Niu
Hi all, I'm from Mogan team, we copied some codes/frameworks from Nova since we want to be a Nova with a bare metal specific API. About why reinventing the wheel, you can find more informations here [1]. I would like to know what's the decent way to show our respect to the original authors we