Re: [openstack-dev] [tc][nova][mogan] How to show respect to the original authors?

[Zhenguo Niu]

Thanks Sean for the suggestion, os-brick is indeed a good example for
sharing codes. Will discuss with the team to see if it's possible to move
that code into such a library.

On Fri, Sep 22, 2017 at 9:26 PM, Sean McGinnis 
wrote:

> > >
> > > Luckily, since these things are part of the ABI of Nova, they are
> > > versioned in many cases, and in all have a well defined interfaces on
> > > one side. Seems like it should be relatively straight forward to wrap
> > > the other side of them and call it a library.
> > >
> > > 
> __
> > > OpenStack Development Mailing List (not for usage questions)
> > > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:
> unsubscribe
> > > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> > >
> >
> > Sounds great if we can call these ABI as a library, but seems still need
> > some refactoring on Nova side to make other projects be able to leverage
> it.
> >
>
> I wouldn't drop the idea because of that. In the case of the os-brick
> library, there was common code for interacting with local storage
> management in both Cinder and Nova. We recognized this and started the
> os-brick library to move that code into one place.
>
> Cinder started using it right away, but it was at least a couple cycles
> before Nova started looking at it. I think that's perfectly fine. If
> you are able to start a library for your own use, and it has good and
> useful common functionality, then Nova can make the decision later if
> they want to take advantage of it.
>
> Sean
>
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>



-- 
Best Regards,
Zhenguo Niu
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [tc][nova][mogan] How to show respect to the original authors?

[Sean McGinnis]

> >
> > Luckily, since these things are part of the ABI of Nova, they are
> > versioned in many cases, and in all have a well defined interfaces on
> > one side. Seems like it should be relatively straight forward to wrap
> > the other side of them and call it a library.
> >
> > __
> > OpenStack Development Mailing List (not for usage questions)
> > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> >
> 
> Sounds great if we can call these ABI as a library, but seems still need
> some refactoring on Nova side to make other projects be able to leverage it.
> 

I wouldn't drop the idea because of that. In the case of the os-brick
library, there was common code for interacting with local storage
management in both Cinder and Nova. We recognized this and started the
os-brick library to move that code into one place.

Cinder started using it right away, but it was at least a couple cycles
before Nova started looking at it. I think that's perfectly fine. If
you are able to start a library for your own use, and it has good and
useful common functionality, then Nova can make the decision later if
they want to take advantage of it.

Sean


__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [tc][nova][mogan] How to show respect to the original authors?

[Zhenguo Niu]

@Dims, sure, will make a formal request, thanks!

On Fri, Sep 22, 2017 at 8:45 PM, Davanum Srinivas  wrote:

> @Zhenguo,
>
> Can you make a formal request via email? add "[infra]" and "[mogan]"
> tags so everyone in mogan is aware of this and the infra folks give
> their ok. Then we can ping infra using "infra-root" on the
> #openstack-infra channel and ask them to replace.
>
> Sounds good?
>
> Thanks,
> Dims
>
> On Fri, Sep 22, 2017 at 8:41 AM, Zhenguo Niu 
> wrote:
> > @Dims,
> >
> > Yes, I think the history is OK, do I need to ping some infra guys or if
> you
> > can help to replace the repo?
> >
> > On Fri, Sep 22, 2017 at 7:22 PM, Davanum Srinivas 
> wrote:
> >>
> >> @Zhenguo,
> >>
> >> Can you please confirm that the history looks good?
> >>
> >> Thanks,
> >> Dims
> >>
> >> On Fri, Sep 22, 2017 at 1:35 AM, Zhenguo Niu 
> >> wrote:
> >> > Thanks dims, that's cool :D
> >> >
> >> > I'll make sure there's no new patches landed to master before
> replacing
> >> > the
> >> > repo.
> >> >
> >> > On Fri, Sep 22, 2017 at 9:53 AM, Davanum Srinivas 
> >> > wrote:
> >> >>
> >> >> Zhenguo,
> >> >>
> >> >> I did some fancy surgery with both cinder and nova repos to add the
> >> >> history, please check my repo here:
> >> >> https://github.com/dims/mogan/commits/master
> >> >>
> >> >> (Needed quota.py from cinder and rest of the files from Nova)
> >> >>
> >> >> If that repo looks good, then we can request infra folks to replace
> >> >> the current master with that one.
> >> >>
> >> >> Thanks,
> >> >> Dims
> >> >>
> >> >> On Thu, Sep 21, 2017 at 9:21 PM, Zhenguo Niu 
> >> >> wrote:
> >> >> >
> >> >> >
> >> >> > On Fri, Sep 22, 2017 at 5:48 AM, Matt Riedemann <
> mriede...@gmail.com>
> >> >> > wrote:
> >> >> >>
> >> >> >> On 9/21/2017 11:55 AM, Mike Perez wrote:
> >> >> >>>
> >> >> >>> On 15:56 Sep 20, Flavio Percoco wrote:
> >> >> 
> >> >>  On 20/09/17 12:21 +, Jeremy Stanley wrote:
> >> >> >
> >> >> > On 2017-09-20 07:51:29 -0400 (-0400), Davanum Srinivas wrote:
> >> >> > [...]
> >> >> >>
> >> >> >> please indicate which file from Nova, so if anyone wanted to
> >> >> >> cross
> >> >> >> check for fixes etc can go look in Nova
> >> >> >
> >> >> > [...]
> >> >> >
> >> >> > While the opportunity has probably passed in this case, the
> ideal
> >> >> > method is to start with a Git fork of the original as your seed
> >> >> > project (perhaps with history pruned to just the files you're
> >> >> > reusing via git filter-branch or similar). This way the
> complete
> >> >> > change history of the files in question is preserved for future
> >> >> > inspection.
> >> >> 
> >> >> 
> >> >>  If it's not too late, I would definitely recommend going with a
> >> >>  fork,
> >> >>  fwiw.
> >> >> 
> >> >>  Flavio
> >> >> 
> >> >>  --
> >> >>  @flaper87
> >> >>  Flavio Percoco
> >> >> >>>
> >> >> >>>
> >> >> >>> +1 please fork instead.
> >> >> >>>
> >> >> >>>
> >> >> >>>
> >> >> >>>
> >> >> >>>
> >> >> >>>
> >> >> >>> 
> __
> >> >> >>> OpenStack Development Mailing List (not for usage questions)
> >> >> >>> Unsubscribe:
> >> >> >>> openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> >> >> >>> http://lists.openstack.org/cgi-bin/mailman/listinfo/
> openstack-dev
> >> >> >>>
> >> >> >>
> >> >> >> I'm pretty sure this ship has sailed. Mogan has been around since
> >> >> >> before
> >> >> >> the PTG in Atlanta.
> >> >> >>
> >> >> >> --
> >> >> >>
> >> >> >> Thanks,
> >> >> >>
> >> >> >> Matt
> >> >> >>
> >> >> >>
> >> >> >>
> >> >> >>
> >> >> >> 
> __
> >> >> >> OpenStack Development Mailing List (not for usage questions)
> >> >> >> Unsubscribe:
> >> >> >> openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> >> >> >> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> >> >> >
> >> >> >
> >> >> > Yes, we are way past that, and there are already 1000+ commits
> since
> >> >> > Mogan
> >> >> > created,
> >> >> >
> >> >> > --
> >> >> > Best Regards,
> >> >> > Zhenguo Niu
> >> >> >
> >> >> >
> >> >> >
> >> >> > 
> __
> >> >> > OpenStack Development Mailing List (not for usage questions)
> >> >> > Unsubscribe:
> >> >> > openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> >> >> > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> >> >> >
> >> >>
> >> >>
> >> >>
> >> >> --
> >> >> Davanum Srinivas :: https://twitter.com/dims
> >> >>
> >> >>
> >> >> 
> __
> >> >> OpenStack Development Mailing List (not for usage questions)
> >> >> Unsubscribe:
> >> >> 

Re: [openstack-dev] [tc][nova][mogan] How to show respect to the original authors?

[Davanum Srinivas]

@Zhenguo,

Can you make a formal request via email? add "[infra]" and "[mogan]"
tags so everyone in mogan is aware of this and the infra folks give
their ok. Then we can ping infra using "infra-root" on the
#openstack-infra channel and ask them to replace.

Sounds good?

Thanks,
Dims

On Fri, Sep 22, 2017 at 8:41 AM, Zhenguo Niu  wrote:
> @Dims,
>
> Yes, I think the history is OK, do I need to ping some infra guys or if you
> can help to replace the repo?
>
> On Fri, Sep 22, 2017 at 7:22 PM, Davanum Srinivas  wrote:
>>
>> @Zhenguo,
>>
>> Can you please confirm that the history looks good?
>>
>> Thanks,
>> Dims
>>
>> On Fri, Sep 22, 2017 at 1:35 AM, Zhenguo Niu 
>> wrote:
>> > Thanks dims, that's cool :D
>> >
>> > I'll make sure there's no new patches landed to master before replacing
>> > the
>> > repo.
>> >
>> > On Fri, Sep 22, 2017 at 9:53 AM, Davanum Srinivas 
>> > wrote:
>> >>
>> >> Zhenguo,
>> >>
>> >> I did some fancy surgery with both cinder and nova repos to add the
>> >> history, please check my repo here:
>> >> https://github.com/dims/mogan/commits/master
>> >>
>> >> (Needed quota.py from cinder and rest of the files from Nova)
>> >>
>> >> If that repo looks good, then we can request infra folks to replace
>> >> the current master with that one.
>> >>
>> >> Thanks,
>> >> Dims
>> >>
>> >> On Thu, Sep 21, 2017 at 9:21 PM, Zhenguo Niu 
>> >> wrote:
>> >> >
>> >> >
>> >> > On Fri, Sep 22, 2017 at 5:48 AM, Matt Riedemann 
>> >> > wrote:
>> >> >>
>> >> >> On 9/21/2017 11:55 AM, Mike Perez wrote:
>> >> >>>
>> >> >>> On 15:56 Sep 20, Flavio Percoco wrote:
>> >> 
>> >>  On 20/09/17 12:21 +, Jeremy Stanley wrote:
>> >> >
>> >> > On 2017-09-20 07:51:29 -0400 (-0400), Davanum Srinivas wrote:
>> >> > [...]
>> >> >>
>> >> >> please indicate which file from Nova, so if anyone wanted to
>> >> >> cross
>> >> >> check for fixes etc can go look in Nova
>> >> >
>> >> > [...]
>> >> >
>> >> > While the opportunity has probably passed in this case, the ideal
>> >> > method is to start with a Git fork of the original as your seed
>> >> > project (perhaps with history pruned to just the files you're
>> >> > reusing via git filter-branch or similar). This way the complete
>> >> > change history of the files in question is preserved for future
>> >> > inspection.
>> >> 
>> >> 
>> >>  If it's not too late, I would definitely recommend going with a
>> >>  fork,
>> >>  fwiw.
>> >> 
>> >>  Flavio
>> >> 
>> >>  --
>> >>  @flaper87
>> >>  Flavio Percoco
>> >> >>>
>> >> >>>
>> >> >>> +1 please fork instead.
>> >> >>>
>> >> >>>
>> >> >>>
>> >> >>>
>> >> >>>
>> >> >>>
>> >> >>> __
>> >> >>> OpenStack Development Mailing List (not for usage questions)
>> >> >>> Unsubscribe:
>> >> >>> openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
>> >> >>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>> >> >>>
>> >> >>
>> >> >> I'm pretty sure this ship has sailed. Mogan has been around since
>> >> >> before
>> >> >> the PTG in Atlanta.
>> >> >>
>> >> >> --
>> >> >>
>> >> >> Thanks,
>> >> >>
>> >> >> Matt
>> >> >>
>> >> >>
>> >> >>
>> >> >>
>> >> >> __
>> >> >> OpenStack Development Mailing List (not for usage questions)
>> >> >> Unsubscribe:
>> >> >> openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
>> >> >> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>> >> >
>> >> >
>> >> > Yes, we are way past that, and there are already 1000+ commits since
>> >> > Mogan
>> >> > created,
>> >> >
>> >> > --
>> >> > Best Regards,
>> >> > Zhenguo Niu
>> >> >
>> >> >
>> >> >
>> >> > __
>> >> > OpenStack Development Mailing List (not for usage questions)
>> >> > Unsubscribe:
>> >> > openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
>> >> > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>> >> >
>> >>
>> >>
>> >>
>> >> --
>> >> Davanum Srinivas :: https://twitter.com/dims
>> >>
>> >>
>> >> __
>> >> OpenStack Development Mailing List (not for usage questions)
>> >> Unsubscribe:
>> >> openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
>> >> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>> >
>> >
>> >
>> >
>> > --
>> > Best Regards,
>> > Zhenguo Niu
>> >
>> >
>> > __
>> > OpenStack Development Mailing List (not for usage questions)
>> > Unsubscribe:
>> > openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
>> > 

Re: [openstack-dev] [tc][nova][mogan] How to show respect to the original authors?

[Zhenguo Niu]

@Dims,

Yes, I think the history is OK, do I need to ping some infra guys or if you
can help to replace the repo?

On Fri, Sep 22, 2017 at 7:22 PM, Davanum Srinivas  wrote:

> @Zhenguo,
>
> Can you please confirm that the history looks good?
>
> Thanks,
> Dims
>
> On Fri, Sep 22, 2017 at 1:35 AM, Zhenguo Niu 
> wrote:
> > Thanks dims, that's cool :D
> >
> > I'll make sure there's no new patches landed to master before replacing
> the
> > repo.
> >
> > On Fri, Sep 22, 2017 at 9:53 AM, Davanum Srinivas 
> wrote:
> >>
> >> Zhenguo,
> >>
> >> I did some fancy surgery with both cinder and nova repos to add the
> >> history, please check my repo here:
> >> https://github.com/dims/mogan/commits/master
> >>
> >> (Needed quota.py from cinder and rest of the files from Nova)
> >>
> >> If that repo looks good, then we can request infra folks to replace
> >> the current master with that one.
> >>
> >> Thanks,
> >> Dims
> >>
> >> On Thu, Sep 21, 2017 at 9:21 PM, Zhenguo Niu 
> >> wrote:
> >> >
> >> >
> >> > On Fri, Sep 22, 2017 at 5:48 AM, Matt Riedemann 
> >> > wrote:
> >> >>
> >> >> On 9/21/2017 11:55 AM, Mike Perez wrote:
> >> >>>
> >> >>> On 15:56 Sep 20, Flavio Percoco wrote:
> >> 
> >>  On 20/09/17 12:21 +, Jeremy Stanley wrote:
> >> >
> >> > On 2017-09-20 07:51:29 -0400 (-0400), Davanum Srinivas wrote:
> >> > [...]
> >> >>
> >> >> please indicate which file from Nova, so if anyone wanted to
> cross
> >> >> check for fixes etc can go look in Nova
> >> >
> >> > [...]
> >> >
> >> > While the opportunity has probably passed in this case, the ideal
> >> > method is to start with a Git fork of the original as your seed
> >> > project (perhaps with history pruned to just the files you're
> >> > reusing via git filter-branch or similar). This way the complete
> >> > change history of the files in question is preserved for future
> >> > inspection.
> >> 
> >> 
> >>  If it's not too late, I would definitely recommend going with a
> fork,
> >>  fwiw.
> >> 
> >>  Flavio
> >> 
> >>  --
> >>  @flaper87
> >>  Flavio Percoco
> >> >>>
> >> >>>
> >> >>> +1 please fork instead.
> >> >>>
> >> >>>
> >> >>>
> >> >>>
> >> >>>
> >> >>> 
> __
> >> >>> OpenStack Development Mailing List (not for usage questions)
> >> >>> Unsubscribe:
> >> >>> openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> >> >>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> >> >>>
> >> >>
> >> >> I'm pretty sure this ship has sailed. Mogan has been around since
> >> >> before
> >> >> the PTG in Atlanta.
> >> >>
> >> >> --
> >> >>
> >> >> Thanks,
> >> >>
> >> >> Matt
> >> >>
> >> >>
> >> >>
> >> >> 
> __
> >> >> OpenStack Development Mailing List (not for usage questions)
> >> >> Unsubscribe:
> >> >> openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> >> >> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> >> >
> >> >
> >> > Yes, we are way past that, and there are already 1000+ commits since
> >> > Mogan
> >> > created,
> >> >
> >> > --
> >> > Best Regards,
> >> > Zhenguo Niu
> >> >
> >> >
> >> > 
> __
> >> > OpenStack Development Mailing List (not for usage questions)
> >> > Unsubscribe:
> >> > openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> >> > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> >> >
> >>
> >>
> >>
> >> --
> >> Davanum Srinivas :: https://twitter.com/dims
> >>
> >> 
> __
> >> OpenStack Development Mailing List (not for usage questions)
> >> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:
> unsubscribe
> >> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> >
> >
> >
> >
> > --
> > Best Regards,
> > Zhenguo Niu
> >
> > 
> __
> > OpenStack Development Mailing List (not for usage questions)
> > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:
> unsubscribe
> > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> >
>
>
>
> --
> Davanum Srinivas :: https://twitter.com/dims
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>



-- 
Best Regards,
Zhenguo Niu
__
OpenStack Development Mailing List (not for usage questions)

Re: [openstack-dev] [tc][nova][mogan] How to show respect to the original authors?

[Davanum Srinivas]

@Zhenguo,

Can you please confirm that the history looks good?

Thanks,
Dims

On Fri, Sep 22, 2017 at 1:35 AM, Zhenguo Niu  wrote:
> Thanks dims, that's cool :D
>
> I'll make sure there's no new patches landed to master before replacing the
> repo.
>
> On Fri, Sep 22, 2017 at 9:53 AM, Davanum Srinivas  wrote:
>>
>> Zhenguo,
>>
>> I did some fancy surgery with both cinder and nova repos to add the
>> history, please check my repo here:
>> https://github.com/dims/mogan/commits/master
>>
>> (Needed quota.py from cinder and rest of the files from Nova)
>>
>> If that repo looks good, then we can request infra folks to replace
>> the current master with that one.
>>
>> Thanks,
>> Dims
>>
>> On Thu, Sep 21, 2017 at 9:21 PM, Zhenguo Niu 
>> wrote:
>> >
>> >
>> > On Fri, Sep 22, 2017 at 5:48 AM, Matt Riedemann 
>> > wrote:
>> >>
>> >> On 9/21/2017 11:55 AM, Mike Perez wrote:
>> >>>
>> >>> On 15:56 Sep 20, Flavio Percoco wrote:
>> 
>>  On 20/09/17 12:21 +, Jeremy Stanley wrote:
>> >
>> > On 2017-09-20 07:51:29 -0400 (-0400), Davanum Srinivas wrote:
>> > [...]
>> >>
>> >> please indicate which file from Nova, so if anyone wanted to cross
>> >> check for fixes etc can go look in Nova
>> >
>> > [...]
>> >
>> > While the opportunity has probably passed in this case, the ideal
>> > method is to start with a Git fork of the original as your seed
>> > project (perhaps with history pruned to just the files you're
>> > reusing via git filter-branch or similar). This way the complete
>> > change history of the files in question is preserved for future
>> > inspection.
>> 
>> 
>>  If it's not too late, I would definitely recommend going with a fork,
>>  fwiw.
>> 
>>  Flavio
>> 
>>  --
>>  @flaper87
>>  Flavio Percoco
>> >>>
>> >>>
>> >>> +1 please fork instead.
>> >>>
>> >>>
>> >>>
>> >>>
>> >>>
>> >>> __
>> >>> OpenStack Development Mailing List (not for usage questions)
>> >>> Unsubscribe:
>> >>> openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
>> >>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>> >>>
>> >>
>> >> I'm pretty sure this ship has sailed. Mogan has been around since
>> >> before
>> >> the PTG in Atlanta.
>> >>
>> >> --
>> >>
>> >> Thanks,
>> >>
>> >> Matt
>> >>
>> >>
>> >>
>> >> __
>> >> OpenStack Development Mailing List (not for usage questions)
>> >> Unsubscribe:
>> >> openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
>> >> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>> >
>> >
>> > Yes, we are way past that, and there are already 1000+ commits since
>> > Mogan
>> > created,
>> >
>> > --
>> > Best Regards,
>> > Zhenguo Niu
>> >
>> >
>> > __
>> > OpenStack Development Mailing List (not for usage questions)
>> > Unsubscribe:
>> > openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
>> > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>> >
>>
>>
>>
>> --
>> Davanum Srinivas :: https://twitter.com/dims
>>
>> __
>> OpenStack Development Mailing List (not for usage questions)
>> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
>
>
>
> --
> Best Regards,
> Zhenguo Niu
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>



-- 
Davanum Srinivas :: https://twitter.com/dims

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [tc][nova][mogan] How to show respect to the original authors?

[Zhenguo Niu]

Thanks dims, that's cool :D

I'll make sure there's no new patches landed to master before replacing the
repo.

On Fri, Sep 22, 2017 at 9:53 AM, Davanum Srinivas  wrote:

> Zhenguo,
>
> I did some fancy surgery with both cinder and nova repos to add the
> history, please check my repo here:
> https://github.com/dims/mogan/commits/master
>
> (Needed quota.py from cinder and rest of the files from Nova)
>
> If that repo looks good, then we can request infra folks to replace
> the current master with that one.
>
> Thanks,
> Dims
>
> On Thu, Sep 21, 2017 at 9:21 PM, Zhenguo Niu 
> wrote:
> >
> >
> > On Fri, Sep 22, 2017 at 5:48 AM, Matt Riedemann 
> wrote:
> >>
> >> On 9/21/2017 11:55 AM, Mike Perez wrote:
> >>>
> >>> On 15:56 Sep 20, Flavio Percoco wrote:
> 
>  On 20/09/17 12:21 +, Jeremy Stanley wrote:
> >
> > On 2017-09-20 07:51:29 -0400 (-0400), Davanum Srinivas wrote:
> > [...]
> >>
> >> please indicate which file from Nova, so if anyone wanted to cross
> >> check for fixes etc can go look in Nova
> >
> > [...]
> >
> > While the opportunity has probably passed in this case, the ideal
> > method is to start with a Git fork of the original as your seed
> > project (perhaps with history pruned to just the files you're
> > reusing via git filter-branch or similar). This way the complete
> > change history of the files in question is preserved for future
> > inspection.
> 
> 
>  If it's not too late, I would definitely recommend going with a fork,
>  fwiw.
> 
>  Flavio
> 
>  --
>  @flaper87
>  Flavio Percoco
> >>>
> >>>
> >>> +1 please fork instead.
> >>>
> >>>
> >>>
> >>>
> >>> 
> __
> >>> OpenStack Development Mailing List (not for usage questions)
> >>> Unsubscribe:
> >>> openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> >>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> >>>
> >>
> >> I'm pretty sure this ship has sailed. Mogan has been around since before
> >> the PTG in Atlanta.
> >>
> >> --
> >>
> >> Thanks,
> >>
> >> Matt
> >>
> >>
> >> 
> __
> >> OpenStack Development Mailing List (not for usage questions)
> >> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:
> unsubscribe
> >> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> >
> >
> > Yes, we are way past that, and there are already 1000+ commits since
> Mogan
> > created,
> >
> > --
> > Best Regards,
> > Zhenguo Niu
> >
> > 
> __
> > OpenStack Development Mailing List (not for usage questions)
> > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:
> unsubscribe
> > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> >
>
>
>
> --
> Davanum Srinivas :: https://twitter.com/dims
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>



-- 
Best Regards,
Zhenguo Niu
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [tc][nova][mogan] How to show respect to the original authors?

[Davanum Srinivas]

Zhenguo,

I did some fancy surgery with both cinder and nova repos to add the
history, please check my repo here:
https://github.com/dims/mogan/commits/master

(Needed quota.py from cinder and rest of the files from Nova)

If that repo looks good, then we can request infra folks to replace
the current master with that one.

Thanks,
Dims

On Thu, Sep 21, 2017 at 9:21 PM, Zhenguo Niu  wrote:
>
>
> On Fri, Sep 22, 2017 at 5:48 AM, Matt Riedemann  wrote:
>>
>> On 9/21/2017 11:55 AM, Mike Perez wrote:
>>>
>>> On 15:56 Sep 20, Flavio Percoco wrote:

 On 20/09/17 12:21 +, Jeremy Stanley wrote:
>
> On 2017-09-20 07:51:29 -0400 (-0400), Davanum Srinivas wrote:
> [...]
>>
>> please indicate which file from Nova, so if anyone wanted to cross
>> check for fixes etc can go look in Nova
>
> [...]
>
> While the opportunity has probably passed in this case, the ideal
> method is to start with a Git fork of the original as your seed
> project (perhaps with history pruned to just the files you're
> reusing via git filter-branch or similar). This way the complete
> change history of the files in question is preserved for future
> inspection.


 If it's not too late, I would definitely recommend going with a fork,
 fwiw.

 Flavio

 --
 @flaper87
 Flavio Percoco
>>>
>>>
>>> +1 please fork instead.
>>>
>>>
>>>
>>>
>>> __
>>> OpenStack Development Mailing List (not for usage questions)
>>> Unsubscribe:
>>> openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
>>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>>
>>
>> I'm pretty sure this ship has sailed. Mogan has been around since before
>> the PTG in Atlanta.
>>
>> --
>>
>> Thanks,
>>
>> Matt
>>
>>
>> __
>> OpenStack Development Mailing List (not for usage questions)
>> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
>
> Yes, we are way past that, and there are already 1000+ commits since Mogan
> created,
>
> --
> Best Regards,
> Zhenguo Niu
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>



-- 
Davanum Srinivas :: https://twitter.com/dims

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [tc][nova][mogan] How to show respect to the original authors?

[Zhenguo Niu]

On Thu, Sep 21, 2017 at 1:33 PM, Clint Byrum  wrote:

> Excerpts from Michael Still's message of 2017-09-20 10:25:17 -0600:
> > Dims, I'm not sure that's actually possible though. Many of these files
> > have been through rewrites and developed over a large number of years.
> > Listing all authors isn't practical.
> >
> > Given the horse has bolted on forking these files, I feel like a comment
> > acknowledging the original source file is probably sufficient.
> >
> > What is concerning to me is that some of these files are part of the
> "ABI"
> > of nova, and if mogan diverges from that then I think we're going to see
> > user complaints in the future. Specifically configdrive, and metadata
> seem
> > like examples of this. I don't want to see us end up in another "managed
> > cut and paste" like early oslo where nova continues to develop these and
> > mogan doesn't notice the changes.
> >
> > I'm not sure how we resolve that. One option would be to refactor these
> > files into a shared library.
> >
>
> Agreed 100%. It would be better to have something completely different
> than something that works 97% the same but constantly skews.
>
> Luckily, since these things are part of the ABI of Nova, they are
> versioned in many cases, and in all have a well defined interfaces on
> one side. Seems like it should be relatively straight forward to wrap
> the other side of them and call it a library.
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>

Sounds great if we can call these ABI as a library, but seems still need
some refactoring on Nova side to make other projects be able to leverage it.

-- 
Best Regards,
Zhenguo Niu
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [tc][nova][mogan] How to show respect to the original authors?

[Zhenguo Niu]

On Wed, Sep 20, 2017 at 7:51 PM, Davanum Srinivas  wrote:

> Zhenguo,
>
> Thanks for bringing this up.
>
> For #1, yes please indicate which file from Nova, so if anyone wanted
> to cross check for fixes etc can go look in Nova
> For #2, When you pick up a commit from Nova, please make sure the
> commit message in Mogan has the following
>* The gerrit change id(s) of the original commit, so folks can
> easily go find the original commit in gerritt
>* Add "Co-Authored-By:" tags for each author in the original commit
> so they get credit
>
> Also, Please make sure you do not alter any copyright or license
> related information in the header when you first copy a file from
> another project.
>

Sure, we will keep the original copyright and license in the header.


>
> Thanks,
> Dims
>
> On Wed, Sep 20, 2017 at 4:20 AM, Zhenguo Niu 
> wrote:
> > Hi all,
> >
> > I'm from Mogan team, we copied some codes/frameworks from Nova since we
> want
> > to be a Nova with a bare metal specific API.
> > About why reinventing the wheel, you can find more informations here [1].
> >
> > I would like to know what's the decent way to show our respect to the
> > original authors we copied from.
> >
> > After discussing with the team, we plan to do some improvements as below:
> >
> > 1. Adds some comments to the beginning of such files to indicate that
> they
> > leveraged the implementation of Nova.
> >
> > https://github.com/openstack/mogan/blob/master/mogan/
> baremetal/ironic/driver.py#L19
> > https://github.com/openstack/mogan/blob/master/mogan/
> console/websocketproxy.py#L17-L18
> > https://github.com/openstack/mogan/blob/master/mogan/
> consoleauth/manager.py#L17
> > https://github.com/openstack/mogan/blob/master/mogan/
> engine/configdrive.py#L17
> > https://github.com/openstack/mogan/blob/master/mogan/
> engine/metadata.py#L18
> > https://github.com/openstack/mogan/blob/master/mogan/network/api.py#L18
> > https://github.com/openstack/mogan/blob/master/mogan/
> objects/aggregate.py#L17
> > https://github.com/openstack/mogan/blob/master/mogan/
> objects/keypair.py#L17
> > https://github.com/openstack/mogan/blob/master/mogan/
> objects/server_fault.py#L17
> > https://github.com/openstack/mogan/blob/master/mogan/
> objects/server_group.py#L17
> > https://github.com/openstack/mogan/blob/master/mogan/
> scheduler/client/report.py#L17
> > https://github.com/openstack/mogan/blob/master/mogan/
> scheduler/filter_scheduler.py#L17
> >
> > 2. For the changes we follows what nova changed, should reference to the
> > original authors in the commit messages.
> >
> >
> > Please let me know if there are something else we need to do or there are
> > already some existing principles we can follow, thanks!
> >
> >
> >
> > [1] https://wiki.openstack.org/wiki/Mogan
> >
> >
> > --
> > Best Regards,
> > Zhenguo Niu
> >
> > 
> __
> > OpenStack Development Mailing List (not for usage questions)
> > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:
> unsubscribe
> > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> >
>
>
>
> --
> Davanum Srinivas :: https://twitter.com/dims
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>



-- 
Best Regards,
Zhenguo Niu
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [tc][nova][mogan] How to show respect to the original authors?

[Zhenguo Niu]

Thanks John Dickinson, we can follow Swift's way but as Michael Still
mentioned seems listing all authors isn't practical.

On Thu, Sep 21, 2017 at 5:43 AM, John Dickinson  wrote:

>
>
> On 20 Sep 2017, at 9:25, Michael Still wrote:
>
> > Dims, I'm not sure that's actually possible though. Many of these files
> > have been through rewrites and developed over a large number of years.
> > Listing all authors isn't practical.
> >
> > Given the horse has bolted on forking these files, I feel like a comment
> > acknowledging the original source file is probably sufficient.
>
> In Swift's repo, we acknowledge the original authors in a section of the
> AUTHORS file
>
> https://github.com/openstack/swift/blob/master/AUTHORS
>
> --John
>
>
>
> >
> > What is concerning to me is that some of these files are part of the
> "ABI"
> > of nova, and if mogan diverges from that then I think we're going to see
> > user complaints in the future. Specifically configdrive, and metadata
> seem
> > like examples of this. I don't want to see us end up in another "managed
> > cut and paste" like early oslo where nova continues to develop these and
> > mogan doesn't notice the changes.
> >
> > I'm not sure how we resolve that. One option would be to refactor these
> > files into a shared library.
> >
> > Michael
> >
> >
> >
> >
> > On Wed, Sep 20, 2017 at 5:51 AM, Davanum Srinivas 
> wrote:
> >
> >> Zhenguo,
> >>
> >> Thanks for bringing this up.
> >>
> >> For #1, yes please indicate which file from Nova, so if anyone wanted
> >> to cross check for fixes etc can go look in Nova
> >> For #2, When you pick up a commit from Nova, please make sure the
> >> commit message in Mogan has the following
> >>* The gerrit change id(s) of the original commit, so folks can
> >> easily go find the original commit in gerritt
> >>* Add "Co-Authored-By:" tags for each author in the original commit
> >> so they get credit
> >>
> >> Also, Please make sure you do not alter any copyright or license
> >> related information in the header when you first copy a file from
> >> another project.
> >>
> >> Thanks,
> >> Dims
> >>
> >> On Wed, Sep 20, 2017 at 4:20 AM, Zhenguo Niu 
> >> wrote:
> >>> Hi all,
> >>>
> >>> I'm from Mogan team, we copied some codes/frameworks from Nova since we
> >> want
> >>> to be a Nova with a bare metal specific API.
> >>> About why reinventing the wheel, you can find more informations here
> [1].
> >>>
> >>> I would like to know what's the decent way to show our respect to the
> >>> original authors we copied from.
> >>>
> >>> After discussing with the team, we plan to do some improvements as
> below:
> >>>
> >>> 1. Adds some comments to the beginning of such files to indicate that
> >> they
> >>> leveraged the implementation of Nova.
> >>>
> >>> https://github.com/openstack/mogan/blob/master/mogan/
> >> baremetal/ironic/driver.py#L19
> >>> https://github.com/openstack/mogan/blob/master/mogan/
> >> console/websocketproxy.py#L17-L18
> >>> https://github.com/openstack/mogan/blob/master/mogan/
> >> consoleauth/manager.py#L17
> >>> https://github.com/openstack/mogan/blob/master/mogan/
> >> engine/configdrive.py#L17
> >>> https://github.com/openstack/mogan/blob/master/mogan/
> >> engine/metadata.py#L18
> >>> https://github.com/openstack/mogan/blob/master/mogan/
> network/api.py#L18
> >>> https://github.com/openstack/mogan/blob/master/mogan/
> >> objects/aggregate.py#L17
> >>> https://github.com/openstack/mogan/blob/master/mogan/
> >> objects/keypair.py#L17
> >>> https://github.com/openstack/mogan/blob/master/mogan/
> >> objects/server_fault.py#L17
> >>> https://github.com/openstack/mogan/blob/master/mogan/
> >> objects/server_group.py#L17
> >>> https://github.com/openstack/mogan/blob/master/mogan/
> >> scheduler/client/report.py#L17
> >>> https://github.com/openstack/mogan/blob/master/mogan/
> >> scheduler/filter_scheduler.py#L17
> >>>
> >>> 2. For the changes we follows what nova changed, should reference to
> the
> >>> original authors in the commit messages.
> >>>
> >>>
> >>> Please let me know if there are something else we need to do or there
> are
> >>> already some existing principles we can follow, thanks!
> >>>
> >>>
> >>>
> >>> [1] https://wiki.openstack.org/wiki/Mogan
> >>>
> >>>
> >>> --
> >>> Best Regards,
> >>> Zhenguo Niu
> >>>
> >>> 
> >> __
> >>> OpenStack Development Mailing List (not for usage questions)
> >>> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:
> >> unsubscribe
> >>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> >>>
> >>
> >>
> >>
> >> --
> >> Davanum Srinivas :: https://twitter.com/dims
> >>
> >> 
> __
> >> OpenStack Development Mailing List (not for usage questions)
> >> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:
> unsubscribe
> >> 

Re: [openstack-dev] [tc][nova][mogan] How to show respect to the original authors?

[Zhenguo Niu]

On Fri, Sep 22, 2017 at 5:48 AM, Matt Riedemann  wrote:

> On 9/21/2017 11:55 AM, Mike Perez wrote:
>
>> On 15:56 Sep 20, Flavio Percoco wrote:
>>
>>> On 20/09/17 12:21 +, Jeremy Stanley wrote:
>>>
 On 2017-09-20 07:51:29 -0400 (-0400), Davanum Srinivas wrote:
 [...]

> please indicate which file from Nova, so if anyone wanted to cross
> check for fixes etc can go look in Nova
>
 [...]

 While the opportunity has probably passed in this case, the ideal
 method is to start with a Git fork of the original as your seed
 project (perhaps with history pruned to just the files you're
 reusing via git filter-branch or similar). This way the complete
 change history of the files in question is preserved for future
 inspection.

>>>
>>> If it's not too late, I would definitely recommend going with a fork,
>>> fwiw.
>>>
>>> Flavio
>>>
>>> --
>>> @flaper87
>>> Flavio Percoco
>>>
>>
>> +1 please fork instead.
>>
>>
>>
>> 
>> __
>> OpenStack Development Mailing List (not for usage questions)
>> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscrib
>> e
>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>
>>
> I'm pretty sure this ship has sailed. Mogan has been around since before
> the PTG in Atlanta.
>
> --
>
> Thanks,
>
> Matt
>
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>

Yes, we are way past that, and there are already 1000+ commits since Mogan
created,

-- 
Best Regards,
Zhenguo Niu
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [tc][nova][mogan] How to show respect to the original authors?

[Matt Riedemann]

On 9/21/2017 11:55 AM, Mike Perez wrote:

On 15:56 Sep 20, Flavio Percoco wrote:

On 20/09/17 12:21 +, Jeremy Stanley wrote:

On 2017-09-20 07:51:29 -0400 (-0400), Davanum Srinivas wrote:
[...]

please indicate which file from Nova, so if anyone wanted to cross
check for fixes etc can go look in Nova

[...]

While the opportunity has probably passed in this case, the ideal
method is to start with a Git fork of the original as your seed
project (perhaps with history pruned to just the files you're
reusing via git filter-branch or similar). This way the complete
change history of the files in question is preserved for future
inspection.


If it's not too late, I would definitely recommend going with a fork, fwiw.

Flavio

--
@flaper87
Flavio Percoco


+1 please fork instead.



__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev



I'm pretty sure this ship has sailed. Mogan has been around since before 
the PTG in Atlanta.


--

Thanks,

Matt

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [tc][nova][mogan] How to show respect to the original authors?

[Mike Perez]

On 15:56 Sep 20, Flavio Percoco wrote:
> On 20/09/17 12:21 +, Jeremy Stanley wrote:
> > On 2017-09-20 07:51:29 -0400 (-0400), Davanum Srinivas wrote:
> > [...]
> > > please indicate which file from Nova, so if anyone wanted to cross
> > > check for fixes etc can go look in Nova
> > [...]
> > 
> > While the opportunity has probably passed in this case, the ideal
> > method is to start with a Git fork of the original as your seed
> > project (perhaps with history pruned to just the files you're
> > reusing via git filter-branch or similar). This way the complete
> > change history of the files in question is preserved for future
> > inspection.
> 
> If it's not too late, I would definitely recommend going with a fork, fwiw.
> 
> Flavio
> 
> --
> @flaper87
> Flavio Percoco

+1 please fork instead.

-- 
Mike Perez


signature.asc
Description: PGP signature
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [tc][nova][mogan] How to show respect to the original authors?

[Clint Byrum]

Excerpts from Michael Still's message of 2017-09-20 10:25:17 -0600:
> Dims, I'm not sure that's actually possible though. Many of these files
> have been through rewrites and developed over a large number of years.
> Listing all authors isn't practical.
> 
> Given the horse has bolted on forking these files, I feel like a comment
> acknowledging the original source file is probably sufficient.
> 
> What is concerning to me is that some of these files are part of the "ABI"
> of nova, and if mogan diverges from that then I think we're going to see
> user complaints in the future. Specifically configdrive, and metadata seem
> like examples of this. I don't want to see us end up in another "managed
> cut and paste" like early oslo where nova continues to develop these and
> mogan doesn't notice the changes.
> 
> I'm not sure how we resolve that. One option would be to refactor these
> files into a shared library.
> 

Agreed 100%. It would be better to have something completely different
than something that works 97% the same but constantly skews.

Luckily, since these things are part of the ABI of Nova, they are
versioned in many cases, and in all have a well defined interfaces on
one side. Seems like it should be relatively straight forward to wrap
the other side of them and call it a library.

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [tc][nova][mogan] How to show respect to the original authors?

[John Dickinson]

On 20 Sep 2017, at 9:25, Michael Still wrote:

> Dims, I'm not sure that's actually possible though. Many of these files
> have been through rewrites and developed over a large number of years.
> Listing all authors isn't practical.
>
> Given the horse has bolted on forking these files, I feel like a comment
> acknowledging the original source file is probably sufficient.

In Swift's repo, we acknowledge the original authors in a section of the 
AUTHORS file

https://github.com/openstack/swift/blob/master/AUTHORS

--John



>
> What is concerning to me is that some of these files are part of the "ABI"
> of nova, and if mogan diverges from that then I think we're going to see
> user complaints in the future. Specifically configdrive, and metadata seem
> like examples of this. I don't want to see us end up in another "managed
> cut and paste" like early oslo where nova continues to develop these and
> mogan doesn't notice the changes.
>
> I'm not sure how we resolve that. One option would be to refactor these
> files into a shared library.
>
> Michael
>
>
>
>
> On Wed, Sep 20, 2017 at 5:51 AM, Davanum Srinivas  wrote:
>
>> Zhenguo,
>>
>> Thanks for bringing this up.
>>
>> For #1, yes please indicate which file from Nova, so if anyone wanted
>> to cross check for fixes etc can go look in Nova
>> For #2, When you pick up a commit from Nova, please make sure the
>> commit message in Mogan has the following
>>* The gerrit change id(s) of the original commit, so folks can
>> easily go find the original commit in gerritt
>>* Add "Co-Authored-By:" tags for each author in the original commit
>> so they get credit
>>
>> Also, Please make sure you do not alter any copyright or license
>> related information in the header when you first copy a file from
>> another project.
>>
>> Thanks,
>> Dims
>>
>> On Wed, Sep 20, 2017 at 4:20 AM, Zhenguo Niu 
>> wrote:
>>> Hi all,
>>>
>>> I'm from Mogan team, we copied some codes/frameworks from Nova since we
>> want
>>> to be a Nova with a bare metal specific API.
>>> About why reinventing the wheel, you can find more informations here [1].
>>>
>>> I would like to know what's the decent way to show our respect to the
>>> original authors we copied from.
>>>
>>> After discussing with the team, we plan to do some improvements as below:
>>>
>>> 1. Adds some comments to the beginning of such files to indicate that
>> they
>>> leveraged the implementation of Nova.
>>>
>>> https://github.com/openstack/mogan/blob/master/mogan/
>> baremetal/ironic/driver.py#L19
>>> https://github.com/openstack/mogan/blob/master/mogan/
>> console/websocketproxy.py#L17-L18
>>> https://github.com/openstack/mogan/blob/master/mogan/
>> consoleauth/manager.py#L17
>>> https://github.com/openstack/mogan/blob/master/mogan/
>> engine/configdrive.py#L17
>>> https://github.com/openstack/mogan/blob/master/mogan/
>> engine/metadata.py#L18
>>> https://github.com/openstack/mogan/blob/master/mogan/network/api.py#L18
>>> https://github.com/openstack/mogan/blob/master/mogan/
>> objects/aggregate.py#L17
>>> https://github.com/openstack/mogan/blob/master/mogan/
>> objects/keypair.py#L17
>>> https://github.com/openstack/mogan/blob/master/mogan/
>> objects/server_fault.py#L17
>>> https://github.com/openstack/mogan/blob/master/mogan/
>> objects/server_group.py#L17
>>> https://github.com/openstack/mogan/blob/master/mogan/
>> scheduler/client/report.py#L17
>>> https://github.com/openstack/mogan/blob/master/mogan/
>> scheduler/filter_scheduler.py#L17
>>>
>>> 2. For the changes we follows what nova changed, should reference to the
>>> original authors in the commit messages.
>>>
>>>
>>> Please let me know if there are something else we need to do or there are
>>> already some existing principles we can follow, thanks!
>>>
>>>
>>>
>>> [1] https://wiki.openstack.org/wiki/Mogan
>>>
>>>
>>> --
>>> Best Regards,
>>> Zhenguo Niu
>>>
>>> 
>> __
>>> OpenStack Development Mailing List (not for usage questions)
>>> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:
>> unsubscribe
>>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>>
>>
>>
>>
>> --
>> Davanum Srinivas :: https://twitter.com/dims
>>
>> __
>> OpenStack Development Mailing List (not for usage questions)
>> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>


> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


signature.asc
Description: OpenPGP digital signature

Re: [openstack-dev] [tc][nova][mogan] How to show respect to the original authors?

[Michael Still]

Dims, I'm not sure that's actually possible though. Many of these files
have been through rewrites and developed over a large number of years.
Listing all authors isn't practical.

Given the horse has bolted on forking these files, I feel like a comment
acknowledging the original source file is probably sufficient.

What is concerning to me is that some of these files are part of the "ABI"
of nova, and if mogan diverges from that then I think we're going to see
user complaints in the future. Specifically configdrive, and metadata seem
like examples of this. I don't want to see us end up in another "managed
cut and paste" like early oslo where nova continues to develop these and
mogan doesn't notice the changes.

I'm not sure how we resolve that. One option would be to refactor these
files into a shared library.

Michael




On Wed, Sep 20, 2017 at 5:51 AM, Davanum Srinivas  wrote:

> Zhenguo,
>
> Thanks for bringing this up.
>
> For #1, yes please indicate which file from Nova, so if anyone wanted
> to cross check for fixes etc can go look in Nova
> For #2, When you pick up a commit from Nova, please make sure the
> commit message in Mogan has the following
>* The gerrit change id(s) of the original commit, so folks can
> easily go find the original commit in gerritt
>* Add "Co-Authored-By:" tags for each author in the original commit
> so they get credit
>
> Also, Please make sure you do not alter any copyright or license
> related information in the header when you first copy a file from
> another project.
>
> Thanks,
> Dims
>
> On Wed, Sep 20, 2017 at 4:20 AM, Zhenguo Niu 
> wrote:
> > Hi all,
> >
> > I'm from Mogan team, we copied some codes/frameworks from Nova since we
> want
> > to be a Nova with a bare metal specific API.
> > About why reinventing the wheel, you can find more informations here [1].
> >
> > I would like to know what's the decent way to show our respect to the
> > original authors we copied from.
> >
> > After discussing with the team, we plan to do some improvements as below:
> >
> > 1. Adds some comments to the beginning of such files to indicate that
> they
> > leveraged the implementation of Nova.
> >
> > https://github.com/openstack/mogan/blob/master/mogan/
> baremetal/ironic/driver.py#L19
> > https://github.com/openstack/mogan/blob/master/mogan/
> console/websocketproxy.py#L17-L18
> > https://github.com/openstack/mogan/blob/master/mogan/
> consoleauth/manager.py#L17
> > https://github.com/openstack/mogan/blob/master/mogan/
> engine/configdrive.py#L17
> > https://github.com/openstack/mogan/blob/master/mogan/
> engine/metadata.py#L18
> > https://github.com/openstack/mogan/blob/master/mogan/network/api.py#L18
> > https://github.com/openstack/mogan/blob/master/mogan/
> objects/aggregate.py#L17
> > https://github.com/openstack/mogan/blob/master/mogan/
> objects/keypair.py#L17
> > https://github.com/openstack/mogan/blob/master/mogan/
> objects/server_fault.py#L17
> > https://github.com/openstack/mogan/blob/master/mogan/
> objects/server_group.py#L17
> > https://github.com/openstack/mogan/blob/master/mogan/
> scheduler/client/report.py#L17
> > https://github.com/openstack/mogan/blob/master/mogan/
> scheduler/filter_scheduler.py#L17
> >
> > 2. For the changes we follows what nova changed, should reference to the
> > original authors in the commit messages.
> >
> >
> > Please let me know if there are something else we need to do or there are
> > already some existing principles we can follow, thanks!
> >
> >
> >
> > [1] https://wiki.openstack.org/wiki/Mogan
> >
> >
> > --
> > Best Regards,
> > Zhenguo Niu
> >
> > 
> __
> > OpenStack Development Mailing List (not for usage questions)
> > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:
> unsubscribe
> > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> >
>
>
>
> --
> Davanum Srinivas :: https://twitter.com/dims
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [tc][nova][mogan] How to show respect to the original authors?

[Flavio Percoco]

On 20/09/17 12:21 +, Jeremy Stanley wrote:

On 2017-09-20 07:51:29 -0400 (-0400), Davanum Srinivas wrote:
[...]

please indicate which file from Nova, so if anyone wanted to cross
check for fixes etc can go look in Nova

[...]

While the opportunity has probably passed in this case, the ideal
method is to start with a Git fork of the original as your seed
project (perhaps with history pruned to just the files you're
reusing via git filter-branch or similar). This way the complete
change history of the files in question is preserved for future
inspection.


If it's not too late, I would definitely recommend going with a fork, fwiw.

Flavio

--
@flaper87
Flavio Percoco


signature.asc
Description: PGP signature
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [tc][nova][mogan] How to show respect to the original authors?

[Jeremy Stanley]

On 2017-09-20 07:51:29 -0400 (-0400), Davanum Srinivas wrote:
[...]
> please indicate which file from Nova, so if anyone wanted to cross
> check for fixes etc can go look in Nova
[...]

While the opportunity has probably passed in this case, the ideal
method is to start with a Git fork of the original as your seed
project (perhaps with history pruned to just the files you're
reusing via git filter-branch or similar). This way the complete
change history of the files in question is preserved for future
inspection.
-- 
Jeremy Stanley


signature.asc
Description: Digital signature
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [tc][nova][mogan] How to show respect to the original authors?

[Davanum Srinivas]

Zhenguo,

Thanks for bringing this up.

For #1, yes please indicate which file from Nova, so if anyone wanted
to cross check for fixes etc can go look in Nova
For #2, When you pick up a commit from Nova, please make sure the
commit message in Mogan has the following
   * The gerrit change id(s) of the original commit, so folks can
easily go find the original commit in gerritt
   * Add "Co-Authored-By:" tags for each author in the original commit
so they get credit

Also, Please make sure you do not alter any copyright or license
related information in the header when you first copy a file from
another project.

Thanks,
Dims

On Wed, Sep 20, 2017 at 4:20 AM, Zhenguo Niu  wrote:
> Hi all,
>
> I'm from Mogan team, we copied some codes/frameworks from Nova since we want
> to be a Nova with a bare metal specific API.
> About why reinventing the wheel, you can find more informations here [1].
>
> I would like to know what's the decent way to show our respect to the
> original authors we copied from.
>
> After discussing with the team, we plan to do some improvements as below:
>
> 1. Adds some comments to the beginning of such files to indicate that they
> leveraged the implementation of Nova.
>
> https://github.com/openstack/mogan/blob/master/mogan/baremetal/ironic/driver.py#L19
> https://github.com/openstack/mogan/blob/master/mogan/console/websocketproxy.py#L17-L18
> https://github.com/openstack/mogan/blob/master/mogan/consoleauth/manager.py#L17
> https://github.com/openstack/mogan/blob/master/mogan/engine/configdrive.py#L17
> https://github.com/openstack/mogan/blob/master/mogan/engine/metadata.py#L18
> https://github.com/openstack/mogan/blob/master/mogan/network/api.py#L18
> https://github.com/openstack/mogan/blob/master/mogan/objects/aggregate.py#L17
> https://github.com/openstack/mogan/blob/master/mogan/objects/keypair.py#L17
> https://github.com/openstack/mogan/blob/master/mogan/objects/server_fault.py#L17
> https://github.com/openstack/mogan/blob/master/mogan/objects/server_group.py#L17
> https://github.com/openstack/mogan/blob/master/mogan/scheduler/client/report.py#L17
> https://github.com/openstack/mogan/blob/master/mogan/scheduler/filter_scheduler.py#L17
>
> 2. For the changes we follows what nova changed, should reference to the
> original authors in the commit messages.
>
>
> Please let me know if there are something else we need to do or there are
> already some existing principles we can follow, thanks!
>
>
>
> [1] https://wiki.openstack.org/wiki/Mogan
>
>
> --
> Best Regards,
> Zhenguo Niu
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>



-- 
Davanum Srinivas :: https://twitter.com/dims

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

[openstack-dev] [tc][nova][mogan] How to show respect to the original authors?

[Zhenguo Niu]

Hi all,

I'm from Mogan team, we copied some codes/frameworks from Nova since we
want to be a Nova with a bare metal specific API.
About why reinventing the wheel, you can find more informations here [1].

I would like to know what's the decent way to show our respect to the
original authors we copied from.

After discussing with the team, we plan to do some improvements as below:

1. Adds some comments to the beginning of such files to indicate that they
leveraged the implementation of Nova.

https://github.com/openstack/mogan/blob/master/mogan/baremetal/ironic/driver.py#L19
https://github.com/openstack/mogan/blob/master/mogan/console/websocketproxy.py#L17-L18
https://github.com/openstack/mogan/blob/master/mogan/consoleauth/manager.py#L17
https://github.com/openstack/mogan/blob/master/mogan/engine/configdrive.py#L17
https://github.com/openstack/mogan/blob/master/mogan/engine/metadata.py#L18
https://github.com/openstack/mogan/blob/master/mogan/network/api.py#L18
https://github.com/openstack/mogan/blob/master/mogan/objects/aggregate.py#L17
https://github.com/openstack/mogan/blob/master/mogan/objects/keypair.py#L17
https://github.com/openstack/mogan/blob/master/mogan/objects/server_fault.py#L17
https://github.com/openstack/mogan/blob/master/mogan/objects/server_group.py#L17
https://github.com/openstack/mogan/blob/master/mogan/scheduler/client/report.py#L17
https://github.com/openstack/mogan/blob/master/mogan/scheduler/filter_scheduler.py#L17

2. For the changes we follows what nova changed, should reference to the
original authors in the commit messages.


Please let me know if there are something else we need to do or there are
already some existing principles we can follow, thanks!



[1] https://wiki.openstack.org/wiki/Mogan


-- 
Best Regards,
Zhenguo Niu
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev