Re: [openstack-dev] [trove][neutron][cinder][swift][ceilometer][nova][keystone][sahara][glance][neutron-lbaas][imm] stylistic changes to code, how do we handle them?

2016-01-12 Thread MichaƂ Dulko
On 01/12/2016 03:02 PM, Chris Dent wrote: > On Tue, 12 Jan 2016, Amrith Kumar wrote: > >> if var > 0: >> ... something ... >> >> To >> >> if var: >> ... something ... > > I may be missing something but the above is not a stylistic change > if var can ever be negative. In one of the

Re: [openstack-dev] [trove][neutron][cinder][swift][ceilometer][nova][keystone][sahara][glance][neutron-lbaas][imm] stylistic changes to code, how do we handle them?

2016-01-12 Thread gord chung
not a fan of these changes since it messes up git blame and it becomes harder to track down author if you have questions relating to bug/code. that said, "if var > 0" is not the same as "if var". in the latter, var can be any number (negative or positive) or any other datatype and it'll

Re: [openstack-dev] [trove][neutron][cinder][swift][ceilometer][nova][keystone][sahara][glance][neutron-lbaas][imm] stylistic changes to code, how do we handle them?

2016-01-12 Thread Ihar Hrachyshka
Amrith Kumar wrote: I've tagged this message with the projects impacted by a series of change sets: [trove] https://review.openstack.org/#/c/266220/ [neutron] https://review.openstack.org/#/c/266156/1 [cinder]

Re: [openstack-dev] [trove][neutron][cinder][swift][ceilometer][nova][keystone][sahara][glance][neutron-lbaas][imm] stylistic changes to code, how do we handle them?

2016-01-12 Thread Chris Dent
On Tue, 12 Jan 2016, Amrith Kumar wrote: if var > 0: ... something ... To if var: ... something ... I may be missing something but the above is not a stylistic change if var can ever be negative. In one of the ceilometer changes[1] for example, this change will change the

Re: [openstack-dev] [trove][neutron][cinder][swift][ceilometer][nova][keystone][sahara][glance][neutron-lbaas][imm] stylistic changes to code, how do we handle them?

2016-01-12 Thread David Stanek
On Tue, Jan 12, 2016 at 8:51 AM, Amrith Kumar wrote: > I've tagged this message with the projects impacted by a series of change > sets: > > [trove] https://review.openstack.org/#/c/266220/ > [neutron] https://review.openstack.org/#/c/266156/1 >

[openstack-dev] [trove][neutron][cinder][swift][ceilometer][nova][keystone][sahara][glance][neutron-lbaas][imm] stylistic changes to code, how do we handle them?

2016-01-12 Thread Amrith Kumar
I've tagged this message with the projects impacted by a series of change sets: [trove] https://review.openstack.org/#/c/266220/ [neutron] https://review.openstack.org/#/c/266156/1 [cinder] https://review.openstack.org/#/c/266099/2 [swift]

Re: [openstack-dev] [trove][neutron][cinder][swift][ceilometer][nova][keystone][sahara][glance][neutron-lbaas][imm] stylistic changes to code, how do we handle them?

2016-01-12 Thread Sergey Lukjanov
Hi, IMO if you want to do the stylistic changes - make the hacking rule for it first. Not all of this particular changes are useful and even correct. The explicit comparison with zero in Python where we have number of implicit casts to bool is much better in such cases. Thanks. On Tue, Jan 12,

Re: [openstack-dev] [trove][neutron][cinder][swift][ceilometer][nova][keystone][sahara][glance][neutron-lbaas][imm] stylistic changes to code, how do we handle them?

2016-01-12 Thread Amrith Kumar
Mailing List (not for usage questions) > <openstack-dev@lists.openstack.org> > Subject: Re: [openstack-dev] > [trove][neutron][cinder][swift][ceilometer][nova][keystone][sahara][glance > ][neutron-lbaas][imm] stylistic changes to code, how do we handle them? > > On

Re: [openstack-dev] [trove][neutron][cinder][swift][ceilometer][nova][keystone][sahara][glance][neutron-lbaas][imm] stylistic changes to code, how do we handle them?

2016-01-12 Thread David Stanek
On Tue, Jan 12, 2016 at 9:13 AM, Amrith Kumar wrote: > Chris, Ihar, > > I assumed that this was stylistic based on the fact that in the places > where I was seeing it, it seemed to be the case that the LHS was > intuitively positive (a length, for example). I did not

Re: [openstack-dev] [trove][neutron][cinder][swift][ceilometer][nova][keystone][sahara][glance][neutron-lbaas][imm] stylistic changes to code, how do we handle them?

2016-01-12 Thread Stefano Maffulli
On 01/12/2016 06:13 AM, Amrith Kumar wrote: [...] > I did not exhaustively verify this but [...] A fair question to ask then is, why are you proposing these patches? > I created a quick poll to tally results oh no, not another survey! :) Sometimes I feel that survey-itis[1] is a consequence of

Re: [openstack-dev] [trove][neutron][cinder][swift][ceilometer][nova][keystone][sahara][glance][neutron-lbaas][imm] stylistic changes to code, how do we handle them?

2016-01-12 Thread Amrith Kumar
gt; Subject: Re: [openstack-dev] > [trove][neutron][cinder][swift][ceilometer][nova][keystone][sahara][glance > ][neutron-lbaas][imm] stylistic changes to code, how do we handle them? > > On 01/12/2016 06:13 AM, Amrith Kumar wrote: > [...] > > I did not exhaustively verify t

Re: [openstack-dev] [trove][neutron][cinder][swift][ceilometer][nova][keystone][sahara][glance][neutron-lbaas][imm] stylistic changes to code, how do we handle them?

2016-01-12 Thread Flavio Percoco
On 12/01/16 15:01 +0100, Ihar Hrachyshka wrote: Amrith Kumar wrote: I've tagged this message with the projects impacted by a series of change sets: [trove] https://review.openstack.org/#/c/266220/ [neutron] https://review.openstack.org/#/c/266156/1

Re: [openstack-dev] [trove][neutron][cinder][swift][ceilometer][nova][keystone][sahara][glance][neutron-lbaas][imm] stylistic changes to code, how do we handle them?

2016-01-12 Thread michael mccune
On 01/12/2016 08:51 AM, Amrith Kumar wrote: My question to the ML is this, should stylistic changes of this kind be handled in a consistent way across all projects, maybe with a hacking rule and some discussion on the ML first? After all, if this change is worthwhile, it is worth ensuring