Re: [openstack-dev] [trove] guestagent config for overriding managers

2014-07-02 Thread Denis Makogon
Hi Craig.

Seems like perfect task to use stevedore and its plugin system. I do agree
that it looks very nasty to have huge dict of managers.
I don't like the idea of placing 'manager' under config groups, because
each config group should be registered, and when it's done only then you
can use options.

There should be another way to deal with it. As i already said, we should
take a look at stevedore.

Best regards,
Denis Makogon


On Wed, Jul 2, 2014 at 7:34 AM, Craig Vyvial cp16...@gmail.com wrote:

 If you want to override the trove guestagent managers its looks really
 nasty to have EVERY manager on a single line here.

 datastore_registry_ext =
 mysql:my.guestagent.datastore.mysql.manager.Manager,percona:my.guestagent.datastore.mysql.manager.Manager,...

 This needs to be tidied up and split out some way.
 Ideally each of these should be on a single line.

 datastore_registry_ext =
 mysql:my.guestagent.datastore.mysql.manager.Manager
 datastore_registry_ext =
 percona:my.guestagent.datastore.mysql.manager.Manager

 or maybe...

 datastores = mysql,precona
 [mysql]
 manager = my.guestagent.datastore.mysql.manager.Manager
 [percona]
 manager = my.guestagent.datastore.percona.manager.Manager

 After typing out the second idea i dont like it as much as something like
 the first way.

 Thoughts?

 Thanks,
 - Craig Vyvial

 ___
 OpenStack-dev mailing list
 OpenStack-dev@lists.openstack.org
 http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


[openstack-dev] [trove] guestagent config for overriding managers

2014-07-01 Thread Craig Vyvial
If you want to override the trove guestagent managers its looks really
nasty to have EVERY manager on a single line here.

datastore_registry_ext =
mysql:my.guestagent.datastore.mysql.manager.Manager,percona:my.guestagent.datastore.mysql.manager.Manager,...

This needs to be tidied up and split out some way.
Ideally each of these should be on a single line.

datastore_registry_ext = mysql:my.guestagent.datastore.mysql.manager.Manager
datastore_registry_ext =
percona:my.guestagent.datastore.mysql.manager.Manager

or maybe...

datastores = mysql,precona
[mysql]
manager = my.guestagent.datastore.mysql.manager.Manager
[percona]
manager = my.guestagent.datastore.percona.manager.Manager

After typing out the second idea i dont like it as much as something like
the first way.

Thoughts?

Thanks,
- Craig Vyvial
___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev