Several properties are added to entity in `DriverBase.make_pickleable`[1] but the existence check is only applied in `_add_entity_type`.
I think it may not be necessary after we prepended vitrage namespace[2]. I could not think of a scenario to let user shadow the built-in `entity_type`. Is there any particular reason for keeping it? Or should we remove it? @staticmethod def _add_entity_type(entity, entity_type): if DSProps.ENTITY_TYPE not in entity: entity[DSProps.ENTITY_TYPE] = entity_type [1]: https://github.com/openstack/vitrage/blob/master/vitrage/datasources/driver_base.py#L54 [2]: https://review.openstack.org/#/c/399417/
__________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev