Re: [openstack-dev] [vitrage] input erroneous `vitrage_id` in `vitrage rca show`API or `vitrage topology show` API

2016-05-25 Thread Afek, Ifat (Nokia - IL)
...@zte.com.cn Cc: Shamir, Ohad (Nokia - IL) Subject: Re: [openstack-dev] [vitrage] input erroneous `vitrage_id` in `vitrage rca show`API or `vitrage topology show` API Hi, all I'm not sure if vitrage follows the RESTful API. In RESTful API, it is reasonable to return 404 error when the requested res

Re: [openstack-dev] [vitrage] input erroneous `vitrage_id` in `vitrage rca show`API or `vitrage topology show` API

2016-05-25 Thread Zhang Yujun
Hi, all I'm not sure if vitrage follows the RESTful API. In RESTful API, it is reasonable to return 404 error when the requested resource does not exist. If we want to display a friendly message, it could be implemented in front end. The backend API should remain simple and consistent since we m

Re: [openstack-dev] [vitrage] input erroneous `vitrage_id` in `vitrage rca show`API or `vitrage topology show` API

2016-05-24 Thread Afek, Ifat (Nokia - IL)
Hi dwj, I'm passing the question (and answer) to openstack mailing list. You are right. In case of an invalid vitrage id, we should not return HTTP 404 error. I think the correct behavior would be to return a nice error message like "Alarm XYZ does not exist". You can open a bug about it. Than