On 2013-12-18 22:08, Jay Pipes wrote:
On 12/18/2013 02:14 PM, Brant Knudson wrote:
Matt -
Could a test be added that goes through the models and checks these
things? Other projects could use this too.
Here's an example of a test that checks if the tables are all InnoDB:
http://git.openstack.or
On 12/18/2013 02:14 PM, Brant Knudson wrote:
Matt -
Could a test be added that goes through the models and checks these
things? Other projects could use this too.
Here's an example of a test that checks if the tables are all InnoDB:
http://git.openstack.org/cgit/openstack/nova/tree/nova/tests/d
On 12/18/2013 2:11 PM, Dan Prince wrote:
- Original Message -
From: "Matt Riedemann"
To: "OpenStack Development Mailing List (not for usage questions)"
Sent: Wednesday, December 18, 2013 12:27:49 PM
Subject: [openstack-dev] Adding DB migration items
On 12/18/2013 1:14 PM, Brant Knudson wrote:
Matt -
Could a test be added that goes through the models and checks these
things? Other projects could use this too.
Here's an example of a test that checks if the tables are all InnoDB:
http://git.openstack.org/cgit/openstack/nova/tree/nova/tests/
- Original Message -
> From: "Matt Riedemann"
> To: "OpenStack Development Mailing List (not for usage questions)"
>
> Sent: Wednesday, December 18, 2013 12:27:49 PM
> Subject: [openstack-dev] Adding DB migration items to the common review
&
I don't have a problem with any of these requirements, but I'd like to
explore automating the checks. Would it be possible to write a unit
test that verified this for all migrations? Then we don't need to add
it to the checklist...
Michael
On Thu, Dec 19, 2013 at 4:27 AM, Matt Riedemann
wrote:
>
Matt -
Could a test be added that goes through the models and checks these things?
Other projects could use this too.
Here's an example of a test that checks if the tables are all InnoDB:
http://git.openstack.org/cgit/openstack/nova/tree/nova/tests/db/test_migrations.py?id=6e455cd97f04bf26bbe022b
I've seen this come up a few times in reviews and was thinking we should
put something in the general review checklist wiki for it [1].
Basically I have three things I'd like to have in the list for DB
migrations:
1. Unique constraints should be named. Different DB engines and
SQLAlchemy dia
