Re: [openstack-dev] Beyond IRC (was Re: Cinder Third-Party CI: what next?)
On 03/25/2015 12:14 PM, Kevin L. Mitchell wrote: > On Tue, 2015-03-24 at 21:21 -0400, Doug Hellmann wrote: ·A separate mailing list for project review requests >>> >>> I'm skeptical about this being effective: just another source of >>> incoming email that needs to be filtered out (at which point a mailman >>> topic would have the same effect). >> >> Yes, email notifications scale poorly for really active reviewers. >> Between gerrit and launchpad, there is already a lot of notification >> email being filtered out of inboxes. > > I actually do rely on email notifications for review duties. I use > filtering that moves the messages into dedicated folders per repository, > and I use threading in those folders. When I see a review merge (or > when I see it abandoned), I select the whole thread and delete it; > otherwise I follow changes made to a review and determine whether I need > to re-review it based on whether votes to that point have been +'s or > -'s. I even subscribe to a couple of projects and check out new reviews > submitted there. This is actually partly to blame for me being such a > prolific reviewer in nova and novaclient :) > One thing I have learned from my experiences at many mid-cycles is there is no one size fits all review workflow. I'm glad email works for you. Others don't read a single email gerrit emits. So advising someone that their review would get more attention by using email is not necessarily true. I would get attention from a portion of reviewers and would be totally ignored by others. Projects are all different in their workflows and this includes their review workflows. To understand how any given project prioritizes reviews one must attend the project weekly meeting, participate in discussions, ask questions, listen and follow advice given. All projects genuinely want to help developers succeed. Folks pay more attention to those wanting to participate when they take the trouble to find out what currently exists. Thanks Kevin, Anita. __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] Beyond IRC (was Re: Cinder Third-Party CI: what next?)
On Tue, 2015-03-24 at 21:21 -0400, Doug Hellmann wrote: > > > ·A separate mailing list for project review requests > > > > I'm skeptical about this being effective: just another source of > > incoming email that needs to be filtered out (at which point a mailman > > topic would have the same effect). > > Yes, email notifications scale poorly for really active reviewers. > Between gerrit and launchpad, there is already a lot of notification > email being filtered out of inboxes. I actually do rely on email notifications for review duties. I use filtering that moves the messages into dedicated folders per repository, and I use threading in those folders. When I see a review merge (or when I see it abandoned), I select the whole thread and delete it; otherwise I follow changes made to a review and determine whether I need to re-review it based on whether votes to that point have been +'s or -'s. I even subscribe to a couple of projects and check out new reviews submitted there. This is actually partly to blame for me being such a prolific reviewer in nova and novaclient :) -- Kevin L. Mitchell Rackspace __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] Beyond IRC (was Re: Cinder Third-Party CI: what next?)
Excerpts from Stefano Maffulli's message of 2015-03-24 15:13:09 -0700: > On Tue, 2015-03-24 at 19:01 +, Rochelle Grober wrote: > > So, how do we get timely first core review of patches in areas of the > > world where Core presence in IRC is slim to none? > > I think that most core reviewers use bouncers, so notifying them in the > channel would probably raise a notification in their clients when they > connect back. I understand the feeling though: as the sender of a > message over IRC, I have no good way to understand if the message was > delivered to the recipient as expected. > > I'd start with advising to use the bouncer and ping the core reviewers > on channel with review requests. (more about this below) > > > > I can think of a few options but they don’t seem great: > > > > ·A filter for dashboards that flags reviews with multiple +1s > > and no core along with a commitment of the Core team to perform a > > review within x number of days > > > This might work, modulo the 'committment' of core team which I think > cannot go above a "best effort". We have a few dashboards like this for Oslo: https://wiki.openstack.org/wiki/Oslo#Review_Links > > > ·A separate mailing list for project review requests > > I'm skeptical about this being effective: just another source of > incoming email that needs to be filtered out (at which point a mailman > topic would have the same effect). Yes, email notifications scale poorly for really active reviewers. Between gerrit and launchpad, there is already a lot of notification email being filtered out of inboxes. > > > ·Somehow queueing requests in the IRC channel so that offline > > developers can easily find review requests when looking at channel > > logs > > Maybe we can hack an IRC bot so that it collects review requests and > lists them on eavesdrop? Something like a user on irc writes: > > : please review https://URL because it's needed for GOODREASONS #review > > and on a web page like http://eavesdrop.openstack.org/ we add 'requests > for reviews', maybe an rss feed. We have a section of the weekly Oslo meeting dedicated to discussing reviews that need to be prioritized. Anyone can add an item to the agenda, even if they aren't present at the meeting. (I don't think that was an original idea, but I'm not sure where I saw it first so I can't give credit properly.) > > BTW, Thierry had a similar request a few weeks back for a system to > quickly share 'good news' and create a stream of reasons for > happyness :) ++ > > > > Solving this issue could help not just Third Party developers, but all > > of OpenStack and make the community more inviting to Asian and > > Australian (and maybe European and African) developers. > > In general, make it more resilient and asynchronous, not just because of > timezones. > > /stef > __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] Beyond IRC (was Re: Cinder Third-Party CI: what next?)
Mike Perez on March 24, 2015 16:39 wrote: On 15:13 Tue 24 Mar , Stefano Maffulli wrote: > On Tue, 2015-03-24 at 19:01 +, Rochelle Grober wrote: > > *Somehow queueing requests in the IRC channel so that offline > > developers can easily find review requests when looking at channel > > logs > > Maybe we can hack an IRC bot so that it collects review requests and > lists them on eavesdrop? Something like a user on irc writes: > > : please review https://URL because it's needed for GOODREASONS #review > > and on a web page like http://eavesdrop.openstack.org/ we add 'requests > for reviews', maybe an rss feed. > > BTW, Thierry had a similar request a few weeks back for a system to > quickly share 'good news' and create a stream of reasons for > happyness :) Python core has an issue summary sent to their list every week [1]. Could do something like this, but with review requests. Using similar filters from the dashboard [2] like open review requests updated that week, what was merged, what's close to being merged (has at least one +2) or has a lot of support (x number of +1's). Could be a bit much on the dev ML with every project, but maybe acceptable if we continue to prefix the subject with [project] + filters. [Rockyg] This actually sounds like a good idea, especially if the subject is identical except for the project filters. That would make it easy to filter out even if you read the whole mailing list, but don't want to track the review lists. --Rocky [1] - https://mail.python.org/pipermail/python-dev/2015-March/138628.html [2] - https://wiki.openstack.org/wiki/Cinder#Review_Links -- Mike Perez __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] Beyond IRC (was Re: Cinder Third-Party CI: what next?)
On 15:13 Tue 24 Mar , Stefano Maffulli wrote: > On Tue, 2015-03-24 at 19:01 +, Rochelle Grober wrote: > > ·Somehow queueing requests in the IRC channel so that offline > > developers can easily find review requests when looking at channel > > logs > > Maybe we can hack an IRC bot so that it collects review requests and > lists them on eavesdrop? Something like a user on irc writes: > > : please review https://URL because it's needed for GOODREASONS #review > > and on a web page like http://eavesdrop.openstack.org/ we add 'requests > for reviews', maybe an rss feed. > > BTW, Thierry had a similar request a few weeks back for a system to > quickly share 'good news' and create a stream of reasons for > happyness :) Python core has an issue summary sent to their list every week [1]. Could do something like this, but with review requests. Using similar filters from the dashboard [2] like open review requests updated that week, what was merged, what's close to being merged (has at least one +2) or has a lot of support (x number of +1's). Could be a bit much on the dev ML with every project, but maybe acceptable if we continue to prefix the subject with [project] + filters. [1] - https://mail.python.org/pipermail/python-dev/2015-March/138628.html [2] - https://wiki.openstack.org/wiki/Cinder#Review_Links -- Mike Perez __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
[openstack-dev] Beyond IRC (was Re: Cinder Third-Party CI: what next?)
On Tue, 2015-03-24 at 19:01 +, Rochelle Grober wrote: > So, how do we get timely first core review of patches in areas of the > world where Core presence in IRC is slim to none? I think that most core reviewers use bouncers, so notifying them in the channel would probably raise a notification in their clients when they connect back. I understand the feeling though: as the sender of a message over IRC, I have no good way to understand if the message was delivered to the recipient as expected. I'd start with advising to use the bouncer and ping the core reviewers on channel with review requests. (more about this below) > > I can think of a few options but they don’t seem great: > > ·A filter for dashboards that flags reviews with multiple +1s > and no core along with a commitment of the Core team to perform a > review within x number of days > This might work, modulo the 'committment' of core team which I think cannot go above a "best effort". > ·A separate mailing list for project review requests I'm skeptical about this being effective: just another source of incoming email that needs to be filtered out (at which point a mailman topic would have the same effect). > ·Somehow queueing requests in the IRC channel so that offline > developers can easily find review requests when looking at channel > logs Maybe we can hack an IRC bot so that it collects review requests and lists them on eavesdrop? Something like a user on irc writes: : please review https://URL because it's needed for GOODREASONS #review and on a web page like http://eavesdrop.openstack.org/ we add 'requests for reviews', maybe an rss feed. BTW, Thierry had a similar request a few weeks back for a system to quickly share 'good news' and create a stream of reasons for happyness :) > > Solving this issue could help not just Third Party developers, but all > of OpenStack and make the community more inviting to Asian and > Australian (and maybe European and African) developers. In general, make it more resilient and asynchronous, not just because of timezones. /stef __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
