Re: [openstack-dev] Cinder unit test failure
On Tue, Jan 21, 2014 at 4:06 PM, Jay Pipes wrote: > On Tue, 2014-01-21 at 08:29 +0530, iKhan wrote: >> I am worried which one is better in terms of performance? iniparse or >> ConfigParser? >> >> I am aware iniparse will do a better job of maintaining INI file's >> structure, but I am more interested in performance. > > The parsing of INI files is the last thing you should be worried about > from a performance perspective. It's not as if your project is built > around the constant parsing and writing of INI files. It's done once on > startup. Who cares about the performance of this? > > Best, > -jay > Have to second Jay's comments, I haven't seen what you're doing but if you're constantly parsing an INI file lord help us :) I'd really focus on getting the unit tests in and verifying that the tempest tests all work properly. > > > ___ > OpenStack-dev mailing list > OpenStack-dev@lists.openstack.org > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] Cinder unit test failure
On Tue, 2014-01-21 at 08:29 +0530, iKhan wrote: > I am worried which one is better in terms of performance? iniparse or > ConfigParser? > > I am aware iniparse will do a better job of maintaining INI file's > structure, but I am more interested in performance. The parsing of INI files is the last thing you should be worried about from a performance perspective. It's not as if your project is built around the constant parsing and writing of INI files. It's done once on startup. Who cares about the performance of this? Best, -jay ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] Cinder unit test failure
I am worried which one is better in terms of performance? iniparse or ConfigParser? I am aware iniparse will do a better job of maintaining INI file's structure, but I am more interested in performance. Can anyone shed some light about parser that can be used to perform INI parsing? On Tue, Jan 21, 2014 at 1:11 AM, iKhan wrote: > Continued with ConfigParser, nothing much difference apart from clean way > of maintaining INI file in iniparse. I think unless a solution is thought, > good to go with this. > > Thanks again John. > > > On Mon, Jan 20, 2014 at 11:47 PM, John Griffith < > john.griff...@solidfire.com> wrote: > >> On Mon, Jan 20, 2014 at 11:15 AM, John Griffith >> wrote: >> > On Mon, Jan 20, 2014 at 10:30 AM, iKhan wrote: >> >> Thanks John, >> >> >> >> It worked earlier while executing because iniparse was installed, tho >> this >> >> wasn't present in virtual environment. Installing iniparse via pip did >> work. >> >> Since I didn't install iniparse specifically, I was under impression >> it was >> >> there by default. Probably now I have to take care of this in >> >> test-requirement.txt as you mentioned. >> >> >> >> I wonder if there is an alternative to iniparse by default. >> >> >> >> Regards >> >> >> >> >> >> On Mon, Jan 20, 2014 at 10:47 PM, John Griffith >> >> wrote: >> >>> >> >>> On Mon, Jan 20, 2014 at 10:07 AM, iKhan >> wrote: >> >>> > Hi, >> >>> > >> >>> > I have imported iniparse to my cinder code, it works fine when I >> perform >> >>> > execution. But when I run the unit test, it fails while importing >> >>> > iniparse. >> >>> > It says "No module named iniparse". Do I have to take care of >> something >> >>> > here? >> >>> > >> >>> > -- >> >>> > Thanks, >> >>> > Ibad Khan >> >>> > 9686594607 >> >>> > >> >>> > ___ >> >>> > OpenStack-dev mailing list >> >>> > OpenStack-dev@lists.openstack.org >> >>> > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev >> >>> > >> >>> >> >>> It sounds like it's not installed on your system. You'd need to do a >> >>> "pip install iniparse", but if you're adding this to your unit tests >> >>> you'll need to have a look at the common test-requires file. Also >> >>> keep in mind if your driver is going to rely on it you'll need it in >> >>> requirements. We can work through the details via IRC if you like. >> >>> >> >>> John >> >>> >> >>> ___ >> >>> OpenStack-dev mailing list >> >>> OpenStack-dev@lists.openstack.org >> >>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev >> >> >> >> >> >> >> >> >> >> -- >> >> Thanks, >> >> Ibad Khan >> >> 9686594607 >> >> >> >> ___ >> >> OpenStack-dev mailing list >> >> OpenStack-dev@lists.openstack.org >> >> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev >> >> >> > >> > there is check out openstack.common.iniparser, not sure if it'll fit >> > your needs or not. >> DOH!! Disregard that >> >> ___ >> OpenStack-dev mailing list >> OpenStack-dev@lists.openstack.org >> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev >> > > > > -- > Thanks, > Ibad Khan > 9686594607 > -- Thanks, Ibad Khan 9686594607 ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] Cinder unit test failure
Continued with ConfigParser, nothing much difference apart from clean way of maintaining INI file in iniparse. I think unless a solution is thought, good to go with this. Thanks again John. On Mon, Jan 20, 2014 at 11:47 PM, John Griffith wrote: > On Mon, Jan 20, 2014 at 11:15 AM, John Griffith > wrote: > > On Mon, Jan 20, 2014 at 10:30 AM, iKhan wrote: > >> Thanks John, > >> > >> It worked earlier while executing because iniparse was installed, tho > this > >> wasn't present in virtual environment. Installing iniparse via pip did > work. > >> Since I didn't install iniparse specifically, I was under impression it > was > >> there by default. Probably now I have to take care of this in > >> test-requirement.txt as you mentioned. > >> > >> I wonder if there is an alternative to iniparse by default. > >> > >> Regards > >> > >> > >> On Mon, Jan 20, 2014 at 10:47 PM, John Griffith > >> wrote: > >>> > >>> On Mon, Jan 20, 2014 at 10:07 AM, iKhan wrote: > >>> > Hi, > >>> > > >>> > I have imported iniparse to my cinder code, it works fine when I > perform > >>> > execution. But when I run the unit test, it fails while importing > >>> > iniparse. > >>> > It says "No module named iniparse". Do I have to take care of > something > >>> > here? > >>> > > >>> > -- > >>> > Thanks, > >>> > Ibad Khan > >>> > 9686594607 > >>> > > >>> > ___ > >>> > OpenStack-dev mailing list > >>> > OpenStack-dev@lists.openstack.org > >>> > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > >>> > > >>> > >>> It sounds like it's not installed on your system. You'd need to do a > >>> "pip install iniparse", but if you're adding this to your unit tests > >>> you'll need to have a look at the common test-requires file. Also > >>> keep in mind if your driver is going to rely on it you'll need it in > >>> requirements. We can work through the details via IRC if you like. > >>> > >>> John > >>> > >>> ___ > >>> OpenStack-dev mailing list > >>> OpenStack-dev@lists.openstack.org > >>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > >> > >> > >> > >> > >> -- > >> Thanks, > >> Ibad Khan > >> 9686594607 > >> > >> ___ > >> OpenStack-dev mailing list > >> OpenStack-dev@lists.openstack.org > >> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > >> > > > > there is check out openstack.common.iniparser, not sure if it'll fit > > your needs or not. > DOH!! Disregard that > > ___ > OpenStack-dev mailing list > OpenStack-dev@lists.openstack.org > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > -- Thanks, Ibad Khan 9686594607 ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] Cinder unit test failure
On Mon, Jan 20, 2014 at 11:15 AM, John Griffith wrote: > On Mon, Jan 20, 2014 at 10:30 AM, iKhan wrote: >> Thanks John, >> >> It worked earlier while executing because iniparse was installed, tho this >> wasn't present in virtual environment. Installing iniparse via pip did work. >> Since I didn't install iniparse specifically, I was under impression it was >> there by default. Probably now I have to take care of this in >> test-requirement.txt as you mentioned. >> >> I wonder if there is an alternative to iniparse by default. >> >> Regards >> >> >> On Mon, Jan 20, 2014 at 10:47 PM, John Griffith >> wrote: >>> >>> On Mon, Jan 20, 2014 at 10:07 AM, iKhan wrote: >>> > Hi, >>> > >>> > I have imported iniparse to my cinder code, it works fine when I perform >>> > execution. But when I run the unit test, it fails while importing >>> > iniparse. >>> > It says "No module named iniparse". Do I have to take care of something >>> > here? >>> > >>> > -- >>> > Thanks, >>> > Ibad Khan >>> > 9686594607 >>> > >>> > ___ >>> > OpenStack-dev mailing list >>> > OpenStack-dev@lists.openstack.org >>> > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev >>> > >>> >>> It sounds like it's not installed on your system. You'd need to do a >>> "pip install iniparse", but if you're adding this to your unit tests >>> you'll need to have a look at the common test-requires file. Also >>> keep in mind if your driver is going to rely on it you'll need it in >>> requirements. We can work through the details via IRC if you like. >>> >>> John >>> >>> ___ >>> OpenStack-dev mailing list >>> OpenStack-dev@lists.openstack.org >>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev >> >> >> >> >> -- >> Thanks, >> Ibad Khan >> 9686594607 >> >> ___ >> OpenStack-dev mailing list >> OpenStack-dev@lists.openstack.org >> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev >> > > there is check out openstack.common.iniparser, not sure if it'll fit > your needs or not. DOH!! Disregard that ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] Cinder unit test failure
On Mon, Jan 20, 2014 at 10:30 AM, iKhan wrote: > Thanks John, > > It worked earlier while executing because iniparse was installed, tho this > wasn't present in virtual environment. Installing iniparse via pip did work. > Since I didn't install iniparse specifically, I was under impression it was > there by default. Probably now I have to take care of this in > test-requirement.txt as you mentioned. > > I wonder if there is an alternative to iniparse by default. > > Regards > > > On Mon, Jan 20, 2014 at 10:47 PM, John Griffith > wrote: >> >> On Mon, Jan 20, 2014 at 10:07 AM, iKhan wrote: >> > Hi, >> > >> > I have imported iniparse to my cinder code, it works fine when I perform >> > execution. But when I run the unit test, it fails while importing >> > iniparse. >> > It says "No module named iniparse". Do I have to take care of something >> > here? >> > >> > -- >> > Thanks, >> > Ibad Khan >> > 9686594607 >> > >> > ___ >> > OpenStack-dev mailing list >> > OpenStack-dev@lists.openstack.org >> > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev >> > >> >> It sounds like it's not installed on your system. You'd need to do a >> "pip install iniparse", but if you're adding this to your unit tests >> you'll need to have a look at the common test-requires file. Also >> keep in mind if your driver is going to rely on it you'll need it in >> requirements. We can work through the details via IRC if you like. >> >> John >> >> ___ >> OpenStack-dev mailing list >> OpenStack-dev@lists.openstack.org >> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > > > > > -- > Thanks, > Ibad Khan > 9686594607 > > ___ > OpenStack-dev mailing list > OpenStack-dev@lists.openstack.org > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > there is check out openstack.common.iniparser, not sure if it'll fit your needs or not. ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] Cinder unit test failure
Thanks John, It worked earlier while executing because iniparse was installed, tho this wasn't present in virtual environment. Installing iniparse via pip did work. Since I didn't install iniparse specifically, I was under impression it was there by default. Probably now I have to take care of this in test-requirement.txt as you mentioned. I wonder if there is an alternative to iniparse by default. Regards On Mon, Jan 20, 2014 at 10:47 PM, John Griffith wrote: > On Mon, Jan 20, 2014 at 10:07 AM, iKhan wrote: > > Hi, > > > > I have imported iniparse to my cinder code, it works fine when I perform > > execution. But when I run the unit test, it fails while importing > iniparse. > > It says "No module named iniparse". Do I have to take care of something > > here? > > > > -- > > Thanks, > > Ibad Khan > > 9686594607 > > > > ___ > > OpenStack-dev mailing list > > OpenStack-dev@lists.openstack.org > > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > > > > It sounds like it's not installed on your system. You'd need to do a > "pip install iniparse", but if you're adding this to your unit tests > you'll need to have a look at the common test-requires file. Also > keep in mind if your driver is going to rely on it you'll need it in > requirements. We can work through the details via IRC if you like. > > John > > ___ > OpenStack-dev mailing list > OpenStack-dev@lists.openstack.org > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > -- Thanks, Ibad Khan 9686594607 ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] Cinder unit test failure
On Mon, Jan 20, 2014 at 10:07 AM, iKhan wrote: > Hi, > > I have imported iniparse to my cinder code, it works fine when I perform > execution. But when I run the unit test, it fails while importing iniparse. > It says "No module named iniparse". Do I have to take care of something > here? > > -- > Thanks, > Ibad Khan > 9686594607 > > ___ > OpenStack-dev mailing list > OpenStack-dev@lists.openstack.org > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > It sounds like it's not installed on your system. You'd need to do a "pip install iniparse", but if you're adding this to your unit tests you'll need to have a look at the common test-requires file. Also keep in mind if your driver is going to rely on it you'll need it in requirements. We can work through the details via IRC if you like. John ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
[openstack-dev] Cinder unit test failure
Hi, I have imported iniparse to my cinder code, it works fine when I perform execution. But when I run the unit test, it fails while importing iniparse. It says "No module named iniparse". Do I have to take care of something here? -- Thanks, Ibad Khan 9686594607 ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
