Re: [openstack-dev] Gerrit tooling improvements(was Re: auto-abandon changesets considered harmful)

2015-03-03 Thread James E. Blair
Sean Dague s...@dague.net writes: Right, I think this is the 'procedural -2' case, which feels like we need another state for things that are being held for procedural reasons, which is unrelated to normal code-review. We have been looking into that and believe we may be able to do something

[openstack-dev] Gerrit tooling improvements(was Re: auto-abandon changesets considered harmful)

2015-03-03 Thread Duncan Thomas
I feel the need to abandon changes that seem abandoned. I believe this has been covered to death now, so I'm going to shelve that conversation for a while, and talk about missing tooling in gerrit. One of the examples of something that was auto-abandoned wrongly was a patch on hold until some

Re: [openstack-dev] Gerrit tooling improvements(was Re: auto-abandon changesets considered harmful)

2015-03-03 Thread Duncan Thomas
On 3 March 2015 at 17:23, Doug Hellmann d...@doughellmann.com wrote: Does the tool ignore patches with Workflow-1 set (work in progress)? So if it doesn't then we can easily change it to do so, however, I think a WIP progress patch that hasn't been updated for months counts as abandoned for