Re: [openstack-dev] Hacking and PEP 257: Extra blank line at end of multi-line docstring

2014-03-03 Thread Ziad Sawalha
Guido kindly updated PEP-257 for us[1]. So now the hacking guide content accurately matches PEP-257 (no extra line required at the end of a multi-line docstring). This alone should resolve the patch and comments that initiated this discussion. With regards to automating the checks and gates, we

Re: [openstack-dev] Hacking and PEP 257: Extra blank line at end of multi-line docstring

2014-02-27 Thread Joe Gordon
On Thu, Feb 27, 2014 at 9:29 AM, Ben Nemec wrote: > On 2014-02-27 08:05, Ziad Sawalha wrote: >> >> On Feb 26, 2014, at 11:47 AM, Joe Gordon wrote: >> >>> On Wed, Feb 26, 2014 at 9:05 AM, David Ripton wrote: On 02/26/2014 11:40 AM, Joe Gordon wrote: > This is missing the point

Re: [openstack-dev] Hacking and PEP 257: Extra blank line at end of multi-line docstring

2014-02-27 Thread Joe Gordon
On Thu, Feb 27, 2014 at 6:05 AM, Ziad Sawalha wrote: > > On Feb 26, 2014, at 11:47 AM, Joe Gordon wrote: > >> On Wed, Feb 26, 2014 at 9:05 AM, David Ripton wrote: >>> On 02/26/2014 11:40 AM, Joe Gordon wrote: >>> This is missing the point about manually enforcing style. If you pass the

Re: [openstack-dev] Hacking and PEP 257: Extra blank line at end of multi-line docstring

2014-02-27 Thread Ben Nemec
On 2014-02-27 08:05, Ziad Sawalha wrote: On Feb 26, 2014, at 11:47 AM, Joe Gordon wrote: On Wed, Feb 26, 2014 at 9:05 AM, David Ripton wrote: On 02/26/2014 11:40 AM, Joe Gordon wrote: This is missing the point about manually enforcing style. If you pass the 'pep8' job there is no need to

Re: [openstack-dev] Hacking and PEP 257: Extra blank line at end of multi-line docstring

2014-02-27 Thread Ziad Sawalha
On Feb 26, 2014, at 11:47 AM, Joe Gordon wrote: > On Wed, Feb 26, 2014 at 9:05 AM, David Ripton wrote: >> On 02/26/2014 11:40 AM, Joe Gordon wrote: >> >>> This is missing the point about manually enforcing style. If you pass >>> the 'pep8' job there is no need to change any style. >> >> >> I

Re: [openstack-dev] Hacking and PEP 257: Extra blank line at end of multi-line docstring

2014-02-26 Thread Joe Gordon
On Wed, Feb 26, 2014 at 9:05 AM, David Ripton wrote: > On 02/26/2014 11:40 AM, Joe Gordon wrote: > >> This is missing the point about manually enforcing style. If you pass >> the 'pep8' job there is no need to change any style. > > > In a perfect world, yes. While there are exceptions to this, t

Re: [openstack-dev] Hacking and PEP 257: Extra blank line at end of multi-line docstring

2014-02-26 Thread David Ripton
On 02/26/2014 11:40 AM, Joe Gordon wrote: This is missing the point about manually enforcing style. If you pass the 'pep8' job there is no need to change any style. In a perfect world, yes. In the real world, there are several things in PEP8 or our project guidelines that the tools don't enf

Re: [openstack-dev] Hacking and PEP 257: Extra blank line at end of multi-line docstring

2014-02-26 Thread Joe Gordon
On Wed, Feb 26, 2014 at 6:39 AM, Ziad Sawalha wrote: > > On Feb 25, 2014, at 5:18 PM, Kevin L. Mitchell > wrote: > >> On Tue, 2014-02-25 at 00:56 +, Ziad Sawalha wrote: >>> Seeking some clarification on the OpenStack hacking guidelines for >>> multi-string docstrings. >>> >>> >>> Q: In OpenS

Re: [openstack-dev] Hacking and PEP 257: Extra blank line at end of multi-line docstring

2014-02-26 Thread Ziad Sawalha
On Feb 25, 2014, at 5:18 PM, Kevin L. Mitchell wrote: > On Tue, 2014-02-25 at 00:56 +, Ziad Sawalha wrote: >> Seeking some clarification on the OpenStack hacking guidelines for >> multi-string docstrings. >> >> >> Q: In OpenStack projects, is a blank line before the triple closing >> quo

Re: [openstack-dev] Hacking and PEP 257: Extra blank line at end of multi-line docstring

2014-02-26 Thread Ziad Sawalha
On Feb 25, 2014, at 4:08 PM, Joe Gordon wrote: > On Mon, Feb 24, 2014 at 4:56 PM, Ziad Sawalha > wrote: >> Seeking some clarification on the OpenStack hacking guidelines for >> multi-string docstrings. >> >> Q: In OpenStack projects, is a blank line before the triple closing quotes >> recommen

Re: [openstack-dev] Hacking and PEP 257: Extra blank line at end of multi-line docstring

2014-02-25 Thread Kevin L. Mitchell
On Tue, 2014-02-25 at 00:56 +, Ziad Sawalha wrote: > Seeking some clarification on the OpenStack hacking guidelines for > multi-string docstrings. > > > Q: In OpenStack projects, is a blank line before the triple closing > quotes recommended (and therefore optional - this is what PEP-257 > s

Re: [openstack-dev] Hacking and PEP 257: Extra blank line at end of multi-line docstring

2014-02-25 Thread Joe Gordon
On Mon, Feb 24, 2014 at 4:56 PM, Ziad Sawalha wrote: > Seeking some clarification on the OpenStack hacking guidelines for > multi-string docstrings. > > Q: In OpenStack projects, is a blank line before the triple closing quotes > recommended (and therefore optional - this is what PEP-257 seems to

[openstack-dev] Hacking and PEP 257: Extra blank line at end of multi-line docstring

2014-02-24 Thread Ziad Sawalha
Seeking some clarification on the OpenStack hacking guidelines for multi-string docstrings. Q: In OpenStack projects, is a blank line before the triple closing quotes recommended (and therefore optional - this is what PEP-257 seems to suggest), required, or explicitly rejected (which could be o