Re: [openstack-dev] How to add a periodic check for typos?
So, just for grins, I took this approach out for a spin on Trove and noticed this as part of the change proposed by topy. - "hebrew": ["hebrew_general_ci", "hebrew_bin"], + "Hebrew": ["hebrew_general_ci", "hebrew_bin"], - "greek": ["greek_general_ci", "greek_bin"], + "Greek": ["greek_general_ci", "greek_bin"], In this particular case the change is being proposed in something that is a set of collation sequences and while "Hebrew" is the correct capitalization in the English language, what we need is "hebrew" in this case. Similarly for Greek and greek. If there were some way to specify a set of "required typos" I would be OK running this manually before I checked in code. I'm not sure I'd like it either as a tox or a hacking rule though because the pain may outweigh the gain. -amrith > -Original Message- > From: Gareth [mailto:academicgar...@gmail.com] > Sent: Thursday, November 19, 2015 10:13 PM > To: OpenStack Development Mailing List (not for usage questions) > > Subject: Re: [openstack-dev] How to add a periodic check for typos? > > Just talking about the idea of auto-spelling-fix. > > My example patch https://review.openstack.org/#/c/247261/ doesn't work. > Topy fixes something and break others. So it is just okay to do auto-spelling- > check now, not fix :( > > > > On Fri, Nov 20, 2015 at 6:31 AM, Matt Riedemann > wrote: > > > > > > On 11/18/2015 8:00 PM, Gareth wrote: > >> > >> Hi stacker, > >> > >> We could use some 3rd tools like topy: > >> pip install topy > >> topy -a > >> git commit & git review > >> > >> Here is an example: https://review.openstack.org/#/c/247261/ > >> > >> Could we have a periodic job like Jenkins users updating our > >> requirement.txt? > >> > > > > Are you asking for all projects or just a specific project you work on > > and you forgot to tag the subject line? > > > > I wouldn't have a bot doing this, if I were going to do it (which I > > wouldn't for nova). You could have it built into your pep8 job, or a > > separate job that is voting on your project, if you really care about > > spelling. > > > > -- > > > > Thanks, > > > > Matt Riedemann > > > > > > > > > __ > > > OpenStack Development Mailing List (not for usage questions) > > Unsubscribe: > > openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > > > > -- > Gareth > > Cloud Computing, OpenStack, Distributed Storage, Fitness, Basketball > OpenStack contributor, kun_huang@freenode My promise: if you find any > spelling or grammar mistakes in my email from Mar 1 2013, notify me and I'll > donate $1 or ￥1 to an open organization you specify. > > __ > > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: OpenStack-dev- > requ...@lists.openstack.org?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] How to add a periodic check for typos?
Just talking about the idea of auto-spelling-fix. My example patch https://review.openstack.org/#/c/247261/ doesn't work. Topy fixes something and break others. So it is just okay to do auto-spelling-check now, not fix :( On Fri, Nov 20, 2015 at 6:31 AM, Matt Riedemann wrote: > > > On 11/18/2015 8:00 PM, Gareth wrote: >> >> Hi stacker, >> >> We could use some 3rd tools like topy: >> pip install topy >> topy -a >> git commit & git review >> >> Here is an example: https://review.openstack.org/#/c/247261/ >> >> Could we have a periodic job like Jenkins users updating our >> requirement.txt? >> > > Are you asking for all projects or just a specific project you work on and > you forgot to tag the subject line? > > I wouldn't have a bot doing this, if I were going to do it (which I wouldn't > for nova). You could have it built into your pep8 job, or a separate job > that is voting on your project, if you really care about spelling. > > -- > > Thanks, > > Matt Riedemann > > > > __ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev -- Gareth Cloud Computing, OpenStack, Distributed Storage, Fitness, Basketball OpenStack contributor, kun_huang@freenode My promise: if you find any spelling or grammar mistakes in my email from Mar 1 2013, notify me and I'll donate $1 or ￥1 to an open organization you specify. __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] How to add a periodic check for typos?
On 11/18/2015 8:00 PM, Gareth wrote: Hi stacker, We could use some 3rd tools like topy: pip install topy topy -a git commit & git review Here is an example: https://review.openstack.org/#/c/247261/ Could we have a periodic job like Jenkins users updating our requirement.txt? Are you asking for all projects or just a specific project you work on and you forgot to tag the subject line? I wouldn't have a bot doing this, if I were going to do it (which I wouldn't for nova). You could have it built into your pep8 job, or a separate job that is voting on your project, if you really care about spelling. -- Thanks, Matt Riedemann __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] How to add a periodic check for typos?
So since requirements usually has an 's' on the end, would you make my cheque for $1.00 payable to the Campaign Against Smog Hazard please? Just use our initials. -- MC __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] How to add a periodic check for typos?
On 11/18/2015 8:00 PM, Gareth wrote: Hi stacker, We could use some 3rd tools like topy: pip install topy topy -a git commit & git review Here is an example: https://review.openstack.org/#/c/247261/ Could we have a periodic job like Jenkins users updating our requirement.txt? Let the list trolling begin! -- Thanks, Matt Riedemann __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
[openstack-dev] How to add a periodic check for typos?
Hi stacker, We could use some 3rd tools like topy: pip install topy topy -a git commit & git review Here is an example: https://review.openstack.org/#/c/247261/ Could we have a periodic job like Jenkins users updating our requirement.txt? -- Gareth Cloud Computing, OpenStack, Distributed Storage, Fitness, Basketball OpenStack contributor, kun_huang@freenode My promise: if you find any spelling or grammar mistakes in my email from Mar 1 2013, notify me and I'll donate $1 or ￥1 to an open organization you specify. __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
