Re: [openstack-dev] ML2 TypeManager question

2015-12-09 Thread Kevin Benton 
It does not appear to be used. I suspect maybe the original intention is
that this could be passed to the type driver which might do something
special depending on the tenant_id. However, the type driver interface does
not include the tenant_id in 'allocate_tenant_segment' so we should either
update the type driver interface to include that or just remove it from
create_network_segments.

On Mon, Dec 7, 2015 at 9:28 AM, Sławek Kapłoński 
wrote:

> Hello,
>
> Recently I was checking something in code of ML2 Type manager
> (neutron.plugins.ml2.managers) and I found in TypeManager class in method
> create_network_segments that to this method as argument is passed
> "tenant_id"
> but I can't find where it is used.
> Can someone more experienced explain me why this tenant_id is passed there
> and
> where it is used? Thx in advance :)
>
> --
> Pozdrawiam / Best regards
> Sławek Kapłoński
> sla...@kaplonski.pl
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
>


-- 
Kevin Benton
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] ML2 TypeManager question

2015-12-09 Thread Kevin Benton 
So in that case don't we need to update the type driver API to pass that
through to the allocation call?

On Wed, Dec 9, 2015 at 12:45 PM, Sławek Kapłoński 
wrote:

> Hello,
>
> In fact we were creating our own type driver and we want to use this
> tenant_id
> so it was good that it is here :) But I was just curious why it is like
> that.
> Thanks.
>
> --
> Pozdrawiam / Best regards
> Sławek Kapłoński
> sla...@kaplonski.pl
>
> Dnia Wednesday 09 of December 2015 09:55:36 Kevin Benton pisze:
> > It does not appear to be used. I suspect maybe the original intention is
> > that this could be passed to the type driver which might do something
> > special depending on the tenant_id. However, the type driver interface
> does
> > not include the tenant_id in 'allocate_tenant_segment' so we should
> either
> > update the type driver interface to include that or just remove it from
> > create_network_segments.
> >
> > On Mon, Dec 7, 2015 at 9:28 AM, Sławek Kapłoński 
> >
> > wrote:
> > > Hello,
> > >
> > > Recently I was checking something in code of ML2 Type manager
> > > (neutron.plugins.ml2.managers) and I found in TypeManager class in
> method
> > > create_network_segments that to this method as argument is passed
> > > "tenant_id"
> > > but I can't find where it is used.
> > > Can someone more experienced explain me why this tenant_id is passed
> there
> > > and
> > > where it is used? Thx in advance :)
> > >
> > > --
> > > Pozdrawiam / Best regards
> > > Sławek Kapłoński
> > > sla...@kaplonski.pl
> > >
> __
> > > OpenStack Development Mailing List (not for usage questions)
> > > Unsubscribe:
> openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> > > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
>


-- 
Kevin Benton
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] ML2 TypeManager question

2015-12-09 Thread Sławek Kapłoński 
Hello,

In fact we were creating our own type driver and we want to use this tenant_id 
so it was good that it is here :) But I was just curious why it is like that. 
Thanks.

--
Pozdrawiam / Best regards
Sławek Kapłoński
sla...@kaplonski.pl

Dnia Wednesday 09 of December 2015 09:55:36 Kevin Benton pisze:
> It does not appear to be used. I suspect maybe the original intention is
> that this could be passed to the type driver which might do something
> special depending on the tenant_id. However, the type driver interface does
> not include the tenant_id in 'allocate_tenant_segment' so we should either
> update the type driver interface to include that or just remove it from
> create_network_segments.
> 
> On Mon, Dec 7, 2015 at 9:28 AM, Sławek Kapłoński 
> 
> wrote:
> > Hello,
> > 
> > Recently I was checking something in code of ML2 Type manager
> > (neutron.plugins.ml2.managers) and I found in TypeManager class in method
> > create_network_segments that to this method as argument is passed
> > "tenant_id"
> > but I can't find where it is used.
> > Can someone more experienced explain me why this tenant_id is passed there
> > and
> > where it is used? Thx in advance :)
> > 
> > --
> > Pozdrawiam / Best regards
> > Sławek Kapłoński
> > sla...@kaplonski.pl
> > __
> > OpenStack Development Mailing List (not for usage questions)
> > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

signature.asc
Description: This is a digitally signed message part.
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

[openstack-dev] ML2 TypeManager question

2015-12-07 Thread Sławek Kapłoński 
Hello,

Recently I was checking something in code of ML2 Type manager 
(neutron.plugins.ml2.managers) and I found in TypeManager class in method 
create_network_segments that to this method as argument is passed "tenant_id" 
but I can't find where it is used.
Can someone more experienced explain me why this tenant_id is passed there and 
where it is used? Thx in advance :)

--
Pozdrawiam / Best regards
Sławek Kapłoński
sla...@kaplonski.pl

signature.asc
Description: This is a digitally signed message part.
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev