Re: [openstack-dev] Missing column in Gerrit overview page showing a -1 review after/with a +2 review

2015-02-16 Thread Jeremy Stanley
On 2015-02-16 15:29:55 +0100 (+0100), Christian Berendt wrote: > This way I can display review requests with -1 reviews, yes. On the > overview page a +2 review will still hide any -1 reviews. But a -1 > review will hide all +1 reviews. I think -1 reviews should be visible > regardless of +2 review

Re: [openstack-dev] Missing column in Gerrit overview page showing a -1 review after/with a +2 review

2015-02-16 Thread Christian Berendt
On 02/14/2015 04:46 PM, Anita Kuno wrote: > Using gerrit queries might come in handy here. > > https://review.openstack.org/Documentation/user-search.html > > For a start, this gets me all reviews that are open for which I am not > the author, where I voted +1 (or better) and someone else voted -

Re: [openstack-dev] Missing column in Gerrit overview page showing a -1 review after/with a +2 review

2015-02-14 Thread Anita Kuno
On 02/14/2015 07:12 AM, Romil Gupta wrote: > Awesome, I like the idea. > > On Sat, Feb 14, 2015 at 3:18 PM, Christian Berendt > wrote: > >> At the moment there are three columns in the Gerrit overiew page showing >> the status of a review request: >> >> * CR (Code-Review) >> * V (Verified) >> *

Re: [openstack-dev] Missing column in Gerrit overview page showing a -1 review after/with a +2 review

2015-02-14 Thread Romil Gupta
Awesome, I like the idea. On Sat, Feb 14, 2015 at 3:18 PM, Christian Berendt wrote: > At the moment there are three columns in the Gerrit overiew page showing > the status of a review request: > > * CR (Code-Review) > * V (Verified) > * Workflow (WF). > > After a core reviewer +2 (CR) a review r

[openstack-dev] Missing column in Gerrit overview page showing a -1 review after/with a +2 review

2015-02-14 Thread Christian Berendt
At the moment there are three columns in the Gerrit overiew page showing the status of a review request: * CR (Code-Review) * V (Verified) * Workflow (WF). After a core reviewer +2 (CR) a review request there will be a green hook in the CR column in the overview page, regardless of -1 reviews. S