Re: [openstack-dev] Opinions needed: Changing method signature in RPC callback ...

2013-07-19 Thread Sandy Walsh
On 07/18/2013 05:56 PM, Eric Windisch wrote: These callback methods are part of the Kombu driver (and maybe part of Qpid), but are NOT part of the RPC abstraction. These are private methods. They can be broken for external consumers of these methods, because there

[openstack-dev] Opinions needed: Changing method signature in RPC callback ...

2013-07-18 Thread Sandy Walsh
Hey y'all! Running into an interesting little dilemma with a branch I'm working on. Recently, I introduced a branch in oslo-common to optionally .reject() a kombu message on an exception. Currently, we always .ack() all messages even if the processing callback fails. For Ceilometer, this is a

Re: [openstack-dev] Opinions needed: Changing method signature in RPC callback ...

2013-07-18 Thread Sandy Walsh
On 07/18/2013 11:09 AM, Sandy Walsh wrote: 2. make a generic CallContext() object to include with message that has anything else we need (a one-time signature break) call_context = CallContext({delivery_info: {...}, wait: False}) callback(message, call_context) or just callback(message,

Re: [openstack-dev] Opinions needed: Changing method signature in RPC callback ...

2013-07-18 Thread Kevin L. Mitchell
On Thu, 2013-07-18 at 11:09 -0300, Sandy Walsh wrote: 3. some other ugly python hack that I haven't thought of yet. I have two possibilities, though neither is really ideal. One is to provide a duplicate call for registering the callback, but where the callback has the extra arguments. The

Re: [openstack-dev] Opinions needed: Changing method signature in RPC callback ...

2013-07-18 Thread Jay Pipes
On 07/18/2013 10:09 AM, Sandy Walsh wrote: Hey y'all! Running into an interesting little dilemma with a branch I'm working on. Recently, I introduced a branch in oslo-common to optionally .reject() a kombu message on an exception. Currently, we always .ack() all messages even if the processing

Re: [openstack-dev] Opinions needed: Changing method signature in RPC callback ...

2013-07-18 Thread Eric Windisch
On Thu, Jul 18, 2013 at 10:09 AM, Sandy Walsh sandy.wa...@rackspace.comwrote: My worry is busting all the other callbacks out there that use olso-common.rpc These callback methods are part of the Kombu driver (and maybe part of Qpid), but are NOT part of the RPC abstraction. These are

Re: [openstack-dev] Opinions needed: Changing method signature in RPC callback ...

2013-07-18 Thread Sandy Walsh
On 07/18/2013 03:55 PM, Eric Windisch wrote: On Thu, Jul 18, 2013 at 10:09 AM, Sandy Walsh sandy.wa...@rackspace.com mailto:sandy.wa...@rackspace.com wrote: My worry is busting all the other callbacks out there that use olso-common.rpc These callback methods are part of the

Re: [openstack-dev] Opinions needed: Changing method signature in RPC callback ...

2013-07-18 Thread Eric Windisch
These callback methods are part of the Kombu driver (and maybe part of Qpid), but are NOT part of the RPC abstraction. These are private methods. They can be broken for external consumers of these methods, because there shouldn't be any. It will be a good lesson to anyone that tries to