Re: [openstack-dev] Toward SQLAlchemy 0.9.x compatibility everywhere for Icehouse

2014-03-04 Thread Matt Riedemann
On 3/3/2014 8:59 AM, Thomas Goirand wrote: On 03/03/2014 01:14 PM, Thomas Goirand wrote: On 03/03/2014 11:24 AM, Thomas Goirand wrote: It looks like my patch fixes the first unit test failure. Though we still need a fix for the 2nd problem: AttributeError: 'module' object has no attribute

Re: [openstack-dev] Toward SQLAlchemy 0.9.x compatibility everywhere for Icehouse

2014-03-03 Thread Thomas Goirand
On 03/03/2014 01:14 PM, Thomas Goirand wrote: On 03/03/2014 11:24 AM, Thomas Goirand wrote: It looks like my patch fixes the first unit test failure. Though we still need a fix for the 2nd problem: AttributeError: 'module' object has no attribute 'AbstractType' Replying to myself... It

Re: [openstack-dev] Toward SQLAlchemy 0.9.x compatibility everywhere for Icehouse

2014-03-03 Thread David Ripton
On 03/02/2014 03:12 AM, Thomas Goirand wrote: On 03/02/2014 12:03 PM, Thomas Goirand wrote: I hope to get support from core reviewers here, so that we can fix-up the SQLA 0.9.x compat ASAP, preferably before b3. Of course, I'll make sure all we do works with both 0.8 and 0.9 version of SQLA.

Re: [openstack-dev] Toward SQLAlchemy 0.9.x compatibility everywhere for Icehouse

2014-03-03 Thread Thomas Goirand
On 03/03/2014 11:17 PM, David Ripton wrote: On 03/02/2014 03:12 AM, Thomas Goirand wrote: On 03/02/2014 12:03 PM, Thomas Goirand wrote: I hope to get support from core reviewers here, so that we can fix-up the SQLA 0.9.x compat ASAP, preferably before b3. Of course, I'll make sure all we do

Re: [openstack-dev] Toward SQLAlchemy 0.9.x compatibility everywhere for Icehouse

2014-03-02 Thread Thomas Goirand
On 03/02/2014 12:03 PM, Thomas Goirand wrote: Hi, About a week ago, the maintainer of SQLAlchemy uploaded version 0.9.3 in Debian Sid. This of course broke a lot of OpenStack packages, including python-migrate. I do not intend to let this continue on for 7 months like it happened for

Re: [openstack-dev] Toward SQLAlchemy 0.9.x compatibility everywhere for Icehouse

2014-03-02 Thread Sean Dague
On 03/02/2014 03:12 AM, Thomas Goirand wrote: On 03/02/2014 12:03 PM, Thomas Goirand wrote: Hi, About a week ago, the maintainer of SQLAlchemy uploaded version 0.9.3 in Debian Sid. This of course broke a lot of OpenStack packages, including python-migrate. I do not intend to let this

Re: [openstack-dev] Toward SQLAlchemy 0.9.x compatibility everywhere for Icehouse

2014-03-02 Thread Thomas Goirand
On 03/03/2014 08:20 AM, Sean Dague wrote: I restacked the final 2 changes to just be the tox fixes to actually run this code - https://review.openstack.org/#/c/66156/ It looks like there are still 2 unit test failures in there even after the 4 changes above. Did you see those in your

Re: [openstack-dev] Toward SQLAlchemy 0.9.x compatibility everywhere for Icehouse

2014-03-02 Thread Thomas Goirand
On 03/03/2014 11:24 AM, Thomas Goirand wrote: It looks like my patch fixes the first unit test failure. Though we still need a fix for the 2nd problem: AttributeError: 'module' object has no attribute 'AbstractType' Replying to myself... It looks like AbstractType is not needed except for

[openstack-dev] Toward SQLAlchemy 0.9.x compatibility everywhere for Icehouse

2014-03-01 Thread Thomas Goirand
Hi, About a week ago, the maintainer of SQLAlchemy uploaded version 0.9.3 in Debian Sid. This of course broke a lot of OpenStack packages, including python-migrate. I do not intend to let this continue on for 7 months like it happened for SQLA 0.8.x. Over the last week, I worked, together with

Re: [openstack-dev] Toward SQLAlchemy 0.9.x compatibility everywhere for Icehouse

2014-03-01 Thread Morgan Fainberg
Hi Thomas, I’ll take a look at that tonight and see if it’s an easy solve. Hopefully I can have something posted by Monday for you. —Morgan — Morgan Fainberg Principal Software Engineer Core Developer, Keystone m...@metacloud.com On March 1, 2014 at 20:06:54, Thomas Goirand (z...@debian.org)