[openstack-dev] Usage of @author tags in the header of Python files

2014-10-08 Thread Christian Berendt
After proposing a change to Horizon to remove the @author tags from the header of Python files (https://review.openstack.org/#/c/126656/) Matthias Runge proposed to discuss this first on the mailing list. Is it necessary to track the authorship of a file inside the file using @author tags? The

Re: [openstack-dev] Usage of @author tags in the header of Python files

2014-10-08 Thread Ihar Hrachyshka
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 08/10/14 09:30, Christian Berendt wrote: After proposing a change to Horizon to remove the @author tags from the header of Python files (https://review.openstack.org/#/c/126656/) Matthias Runge proposed to discuss this first on the mailing

Re: [openstack-dev] Usage of @author tags in the header of Python files

2014-10-08 Thread Daniel P. Berrange
On Wed, Oct 08, 2014 at 09:30:42AM +0200, Christian Berendt wrote: After proposing a change to Horizon to remove the @author tags from the header of Python files (https://review.openstack.org/#/c/126656/) Matthias Runge proposed to discuss this first on the mailing list. Is it necessary to

Re: [openstack-dev] Usage of @author tags in the header of Python files

2014-10-08 Thread Sam Betts (sambetts)
On 08/10/2014 10:39, Ihar Hrachyshka ihrac...@redhat.com wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 08/10/14 09:30, Christian Berendt wrote: After proposing a change to Horizon to remove the @author tags from the header of Python files

Re: [openstack-dev] Usage of @author tags in the header of Python files

2014-10-08 Thread Duncan Thomas
On 8 October 2014 10:39, Ihar Hrachyshka ihrac...@redhat.com wrote: On 08/10/14 09:30, Christian Berendt wrote: After proposing a change to Horizon to remove the @author tags from the header of Python files (https://review.openstack.org/#/c/126656/) Matthias Runge proposed to discuss this

Re: [openstack-dev] Usage of @author tags in the header of Python files

2014-10-08 Thread David Lyle
I don't see any need nor benefit from the tags. We should remove them if convenient. David On Oct 8, 2014 3:02 AM, Duncan Thomas duncan.tho...@gmail.com wrote: On 8 October 2014 10:39, Ihar Hrachyshka ihrac...@redhat.com wrote: On 08/10/14 09:30, Christian Berendt wrote: After proposing a

Re: [openstack-dev] Usage of @author tags in the header of Python files

2014-10-08 Thread John Griffith
On Wed, Oct 8, 2014 at 11:15 AM, David Lyle dkly...@gmail.com wrote: I don't see any need nor benefit from the tags. We should remove them if convenient. David On Oct 8, 2014 3:02 AM, Duncan Thomas duncan.tho...@gmail.com wrote: On 8 October 2014 10:39, Ihar Hrachyshka ihrac...@redhat.com

Re: [openstack-dev] Usage of @author tags in the header of Python files

2014-10-08 Thread Monty Taylor
On 10/08/2014 10:45 AM, John Griffith wrote: On Wed, Oct 8, 2014 at 11:15 AM, David Lyle dkly...@gmail.com wrote: I don't see any need nor benefit from the tags. We should remove them if convenient. David On Oct 8, 2014 3:02 AM, Duncan Thomas duncan.tho...@gmail.com wrote: On 8 October

Re: [openstack-dev] Usage of @author tags in the header of Python files

2014-10-08 Thread Chris Buccella
Nova has a hacking check for this (N315): https://git.openstack.org/cgit/openstack/nova/tree/nova/hacking/checks.py#n220 Based on the general sentiment around the issue, maybe other projects should consider enforcing this similarly. On Wed, Oct 8, 2014 at 1:56 PM, Monty Taylor