Re: [openstack-dev] Virtio-scsi settings nova-specs exception
On Wed, Jul 23, 2014 at 09:09:52AM +1000, Michael Still wrote: Ok, I am going to take Daniel and Dan's comments as agreement that this spec freeze exception should go ahead, so the exception is approved. The exception is in the form of another week to get the spec merged, so quick iterations are the key. I'm withdrawing my sponsorship of this. I thought it was going to be a trivial addition, but it is turning into a huge can of worms. I think it is best to push it to Kilo to allow sufficient time to address the questions marks over it. Regards, Daniel -- |: http://berrange.com -o-http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] Virtio-scsi settings nova-specs exception
Fair enough. Let's roll with that then. Michael On Tue, Jul 22, 2014 at 6:33 AM, Sean Dague s...@dague.net wrote: On 07/21/2014 03:35 PM, Dan Smith wrote: We've already approved many other blueprints for Juno that involve features from new libvirt, so I don't think it is credible to reject this or any other feature that requires new libvirt in Juno. Furthermore this proposal for Nova is a targetted feature which is not enabled by default, so the risk of regression for people not using it is negligible. So I see no reason not to accept this feature. Yep, the proposal that started this discussion was never aimed at creating new test requirements for already-approved nova specs anyway. I definitely don't think we need to hold up something relatively simple like this on those grounds, given where we are in the discussion. --Dan Agreed. This was mostly about figuring out a future path for ensuring that the features that we say work in OpenStack either have some validation behind them, or some appropriate disclaimers so that people realize they aren't really tested in our normal system. I'm fine with the virtio-scsi settings moving forward. -Sean -- Sean Dague http://dague.net -- Rackspace Australia ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] Virtio-scsi settings nova-specs exception
Ok, I am going to take Daniel and Dan's comments as agreement that this spec freeze exception should go ahead, so the exception is approved. The exception is in the form of another week to get the spec merged, so quick iterations are the key. Cheers, Michael On Tue, Jul 22, 2014 at 6:36 PM, Michael Still mi...@stillhq.com wrote: Fair enough. Let's roll with that then. Michael On Tue, Jul 22, 2014 at 6:33 AM, Sean Dague s...@dague.net wrote: On 07/21/2014 03:35 PM, Dan Smith wrote: We've already approved many other blueprints for Juno that involve features from new libvirt, so I don't think it is credible to reject this or any other feature that requires new libvirt in Juno. Furthermore this proposal for Nova is a targetted feature which is not enabled by default, so the risk of regression for people not using it is negligible. So I see no reason not to accept this feature. Yep, the proposal that started this discussion was never aimed at creating new test requirements for already-approved nova specs anyway. I definitely don't think we need to hold up something relatively simple like this on those grounds, given where we are in the discussion. --Dan Agreed. This was mostly about figuring out a future path for ensuring that the features that we say work in OpenStack either have some validation behind them, or some appropriate disclaimers so that people realize they aren't really tested in our normal system. I'm fine with the virtio-scsi settings moving forward. -Sean -- Sean Dague http://dague.net -- Rackspace Australia -- Rackspace Australia ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] Virtio-scsi settings nova-specs exception
On Mon, Jul 21, 2014 at 10:21:20AM +1000, Michael Still wrote: I just want to check my understanding -- it seems to me that this depends on a feature that's very new to libvirt (merged there 22 May 2014). Is that right? http://libvirt.org/git/?p=libvirt.git;a=commit;h=d950494129513558a303387e26a2bab057012c5e We've had some concerns about adding features to the libvirt driver for features represented only in very new versions of libvirt. https://review.openstack.org/#/c/72038/ is an example. Now, its clear to me that we don't yet have a consensus on nova-core on how to handle features depending on very new libvirts. There are certainly CI concerns at the least. So, I think approving this exception is tied up in that whole debate. We've already approved many other blueprints for Juno that involve features from new libvirt, so I don't think it is credible to reject this or any other feature that requires new libvirt in Juno. Furthermore this proposal for Nova is a targetted feature which is not enabled by default, so the risk of regression for people not using it is negligible. So I see no reason not to accept this feature. Regards, Daniel -- |: http://berrange.com -o-http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] Virtio-scsi settings nova-specs exception
We've already approved many other blueprints for Juno that involve features from new libvirt, so I don't think it is credible to reject this or any other feature that requires new libvirt in Juno. Furthermore this proposal for Nova is a targetted feature which is not enabled by default, so the risk of regression for people not using it is negligible. So I see no reason not to accept this feature. Yep, the proposal that started this discussion was never aimed at creating new test requirements for already-approved nova specs anyway. I definitely don't think we need to hold up something relatively simple like this on those grounds, given where we are in the discussion. --Dan ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] Virtio-scsi settings nova-specs exception
On 07/21/2014 03:35 PM, Dan Smith wrote: We've already approved many other blueprints for Juno that involve features from new libvirt, so I don't think it is credible to reject this or any other feature that requires new libvirt in Juno. Furthermore this proposal for Nova is a targetted feature which is not enabled by default, so the risk of regression for people not using it is negligible. So I see no reason not to accept this feature. Yep, the proposal that started this discussion was never aimed at creating new test requirements for already-approved nova specs anyway. I definitely don't think we need to hold up something relatively simple like this on those grounds, given where we are in the discussion. --Dan Agreed. This was mostly about figuring out a future path for ensuring that the features that we say work in OpenStack either have some validation behind them, or some appropriate disclaimers so that people realize they aren't really tested in our normal system. I'm fine with the virtio-scsi settings moving forward. -Sean -- Sean Dague http://dague.net signature.asc Description: OpenPGP digital signature ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] Virtio-scsi settings nova-specs exception
I just want to check my understanding -- it seems to me that this depends on a feature that's very new to libvirt (merged there 22 May 2014). Is that right? http://libvirt.org/git/?p=libvirt.git;a=commit;h=d950494129513558a303387e26a2bab057012c5e We've had some concerns about adding features to the libvirt driver for features represented only in very new versions of libvirt. https://review.openstack.org/#/c/72038/ is an example. Now, its clear to me that we don't yet have a consensus on nova-core on how to handle features depending on very new libvirts. There are certainly CI concerns at the least. So, I think approving this exception is tied up in that whole debate. Hopefully we can get that sorted out soon (and possibly unblock https://review.openstack.org/#/c/72038/ depending on the outcome). Michael On Sat, Jul 19, 2014 at 3:52 AM, Vishvananda Ishaya vishvana...@gmail.com wrote: I will also sponsor this. Vish On Jul 17, 2014, at 2:47 PM, Mike Perez thin...@gmail.com wrote: As requested from the #openstack-meeting for Nova, I'm posting my nova-spec exception proposal to the ML. Spec: https://review.openstack.org/#/c/103797/3/specs/juno/virtio-scsi-settings.rst Code: https://review.openstack.org/#/c/107650/ - Nikola Dipanov was kind to be the first core sponsor. [1] - This is an optional feature, which should make it a low risk for Nova. - The spec was posted before the spec freeze deadline. - Code change is reasonable and available now. Thank you! [1] - https://etherpad.openstack.org/p/nova-juno-spec-priorities -- Mike Perez ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev -- Rackspace Australia ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] Virtio-scsi settings nova-specs exception
On 10:21 Mon 21 Jul , Michael Still wrote: I just want to check my understanding -- it seems to me that this depends on a feature that's very new to libvirt (merged there 22 May 2014). Is that right? http://libvirt.org/git/?p=libvirt.git;a=commit;h=d950494129513558a303387e26a2bab057012c5e Yes, this was mentioned in the Nova spec itself. We've had some concerns about adding features to the libvirt driver for features represented only in very new versions of libvirt. https://review.openstack.org/#/c/72038/ is an example. Now, its clear to me that we don't yet have a consensus on nova-core on how to handle features depending on very new libvirts. There are certainly CI concerns at the least. So, I think approving this exception is tied up in that whole debate. Hopefully we can get that sorted out soon (and possibly unblock https://review.openstack.org/#/c/72038/ depending on the outcome). Michael For what it's worth, it's optional and the administrator would have to really go out of their way to enable this in two ways: * You have to be using a Cinder driver that uses the vhost connector to pass the connection data to Nova. * Glance metadata of an image has to have these options set. The review you provided with the debate raised by Dan Smith has been stale for 19 days with Daniel waiting for a reply. Should we have this listed for the next Nova meeting? -- Mike Perez ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] Virtio-scsi settings nova-specs exception
I agree this has stalled for too long, although I feel like http://lists.openstack.org/pipermail/openstack-dev/2014-July/040421.html has progressed the topic a little. On the other hand, its been a busy patch in the cycle and I think we can get this conversation back on track now. That's why I cc'ed the main protagonists into my email on this thread. Michael On Mon, Jul 21, 2014 at 10:55 AM, Mike Perez thin...@gmail.com wrote: On 10:21 Mon 21 Jul , Michael Still wrote: I just want to check my understanding -- it seems to me that this depends on a feature that's very new to libvirt (merged there 22 May 2014). Is that right? http://libvirt.org/git/?p=libvirt.git;a=commit;h=d950494129513558a303387e26a2bab057012c5e Yes, this was mentioned in the Nova spec itself. We've had some concerns about adding features to the libvirt driver for features represented only in very new versions of libvirt. https://review.openstack.org/#/c/72038/ is an example. Now, its clear to me that we don't yet have a consensus on nova-core on how to handle features depending on very new libvirts. There are certainly CI concerns at the least. So, I think approving this exception is tied up in that whole debate. Hopefully we can get that sorted out soon (and possibly unblock https://review.openstack.org/#/c/72038/ depending on the outcome). Michael For what it's worth, it's optional and the administrator would have to really go out of their way to enable this in two ways: * You have to be using a Cinder driver that uses the vhost connector to pass the connection data to Nova. * Glance metadata of an image has to have these options set. The review you provided with the debate raised by Dan Smith has been stale for 19 days with Daniel waiting for a reply. Should we have this listed for the next Nova meeting? -- Mike Perez ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev -- Rackspace Australia ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] Virtio-scsi settings nova-specs exception
I will also sponsor this. Vish On Jul 17, 2014, at 2:47 PM, Mike Perez thin...@gmail.com wrote: As requested from the #openstack-meeting for Nova, I'm posting my nova-spec exception proposal to the ML. Spec: https://review.openstack.org/#/c/103797/3/specs/juno/virtio-scsi-settings.rst Code: https://review.openstack.org/#/c/107650/ - Nikola Dipanov was kind to be the first core sponsor. [1] - This is an optional feature, which should make it a low risk for Nova. - The spec was posted before the spec freeze deadline. - Code change is reasonable and available now. Thank you! [1] - https://etherpad.openstack.org/p/nova-juno-spec-priorities -- Mike Perez ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev signature.asc Description: Message signed with OpenPGP using GPGMail ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
[openstack-dev] Virtio-scsi settings nova-specs exception
As requested from the #openstack-meeting for Nova, I'm posting my nova-spec exception proposal to the ML. Spec: https://review.openstack.org/#/c/103797/3/specs/juno/virtio-scsi-settings.rst Code: https://review.openstack.org/#/c/107650/ - Nikola Dipanov was kind to be the first core sponsor. [1] - This is an optional feature, which should make it a low risk for Nova. - The spec was posted before the spec freeze deadline. - Code change is reasonable and available now. Thank you! [1] - https://etherpad.openstack.org/p/nova-juno-spec-priorities -- Mike Perez ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
